blob: f334784bfa55299467bfcc836b2238f6e084cebd [file] [log] [blame]
Yuta HIGUCHIf9808442014-03-20 15:56:50 -07001<?xml version="1.0"?>
2<!DOCTYPE module PUBLIC
Ray Milkey3f5ef562014-03-25 17:11:19 -07003 "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
4 "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
Yuta HIGUCHIf9808442014-03-20 15:56:50 -07005
6
7<!--
8
9 Checkstyle configuration that checks the sun coding conventions from:
10
11 - the Java Language Specification at
12 http://java.sun.com/docs/books/jls/second_edition/html/index.html
13
14 - the Sun Code Conventions at http://java.sun.com/docs/codeconv/
15
16 - the Javadoc guidelines at
17 http://java.sun.com/j2se/javadoc/writingdoccomments/index.html
18
19 - the JDK Api documentation http://java.sun.com/j2se/docs/api/index.html
20
21 - some best practices
22
23 Checkstyle is very configurable. Be sure to read the documentation at
24 http://checkstyle.sf.net (or in your downloaded distribution).
25
26 Most Checks are configurable, be sure to consult the documentation.
27
28 To completely disable a check, just comment it out or delete it from the file.
29
30 Finally, it is worth reading the documentation.
31
32-->
33
Ray Milkeyb5716c52014-04-07 11:38:27 -070034
35<!--
36 The default severity setting in checkstyle is 'error', so some
37 of the rules below are configured to change the severity to
38 'warning'. Over time, these 'warning' settings should be
39 removed as more of the ONOS source code is modified to
40 follow the recommended rules.
41-->
42
43
44
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070045<module name="Checker">
Yuta HIGUCHIcbbaed32014-05-14 20:27:43 -070046 <module name="SuppressionFilter">
47 <property name="file" value="${config_loc}/onos_suppressions.xml"/>
48 </module>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070049 <!--
50 If you set the basedir property below, then all reported file
51 names will be relative to the specified directory. See
52 http://checkstyle.sourceforge.net/5.x/config.html#Checker
53
54 <property name="basedir" value="${basedir}"/>
55 -->
56 <!-- Checks that a package-info.java file exists for each package. -->
57 <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage -->
58 <!-- ONOS does not currently supply package level Javadoc information
Ray Milkeyb5716c52014-04-07 11:38:27 -070059 in package-info files -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070060 <!-- <module name="JavadocPackage"/> -->
61
62 <!-- Checks whether files end with a new line. -->
63 <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
Ray Milkey0f913a02014-04-07 20:58:17 -070064 <module name="NewlineAtEndOfFile"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070065
66 <!-- Checks that property files contain the same keys. -->
67 <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
68 <module name="Translation"/>
Ray Milkey3f5ef562014-03-25 17:11:19 -070069
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070070 <!-- Checks for Size Violations. -->
71 <!-- See http://checkstyle.sf.net/config_sizes.html -->
Ray Milkey0b122ed2014-04-14 10:06:03 -070072 <module name="FileLength"/>
Ray Milkey3f5ef562014-03-25 17:11:19 -070073
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070074 <!-- Checks for whitespace -->
75 <!-- See http://checkstyle.sf.net/config_whitespace.html -->
76 <module name="FileTabCharacter"/>
77
78 <!-- Miscellaneous other checks. -->
79 <!-- See http://checkstyle.sf.net/config_misc.html -->
80 <module name="RegexpSingleline">
Ray Milkey3f5ef562014-03-25 17:11:19 -070081 <property name="format" value="\s+$"/>
82 <property name="minimum" value="0"/>
83 <property name="maximum" value="0"/>
84 <property name="message" value="Line has trailing spaces."/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070085 </module>
86
87 <!-- Checks for Headers -->
88 <!-- See http://checkstyle.sf.net/config_header.html -->
89 <!-- <module name="Header"> -->
90 <!-- <property name="headerFile" value="${checkstyle.header.file}"/> -->
91 <!-- <property name="fileExtensions" value="java"/> -->
92 <!-- </module> -->
93
Ray Milkey5df613b2014-04-15 10:50:56 -070094 <module name="SuppressionCommentFilter">
Ray Milkey098466c2014-04-22 11:36:46 -070095 <property name="offCommentFormat" value="CHECKSTYLE:OFF"/>
96 <property name="onCommentFormat" value="CHECKSTYLE:ON"/>
Ray Milkey5df613b2014-04-15 10:50:56 -070097 </module>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -070098 <module name="TreeWalker">
99
Ray Milkey5df613b2014-04-15 10:50:56 -0700100 <module name="FileContentsHolder"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700101 <!-- Checks for Javadoc comments. -->
102 <!-- See http://checkstyle.sf.net/config_javadoc.html -->
Ray Milkeyb5716c52014-04-07 11:38:27 -0700103 <module name="JavadocMethod">
Ray Milkey098466c2014-04-22 11:36:46 -0700104 <property name="severity" value="warning"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700105 </module>
106 <module name="JavadocType">
Ray Milkey098466c2014-04-22 11:36:46 -0700107 <property name="severity" value="warning"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700108 </module>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700109 <module name="JavadocVariable">
Ray Milkey3f5ef562014-03-25 17:11:19 -0700110 <!-- Suppress check for private member Javadocs.
111 Possibly revist fixing these. -->
112 <property name="scope" value="public"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700113 <property name="severity" value="warning"/>
Ray Milkey3f5ef562014-03-25 17:11:19 -0700114 </module>
Ray Milkeyb41100a2014-04-10 10:42:15 -0700115 <module name="JavadocStyle"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700116
117
118 <!-- Checks for Naming Conventions. -->
119 <!-- See http://checkstyle.sf.net/config_naming.html -->
Ray Milkeyec497712014-03-20 17:51:22 -0700120 <module name="ConstantName">
Ray Milkey3f5ef562014-03-25 17:11:19 -0700121 <!-- ONOS allows the name "log" for static final Loggers -->
122 <property name="format"
123 value="^log$|^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/>
124 </module>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700125 <module name="LocalFinalVariableName"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700126
Ray Milkey2476cac2014-04-08 11:03:21 -0700127 <module name="LocalVariableName"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700128
Ray Milkey2476cac2014-04-08 11:03:21 -0700129 <module name="MemberName"/>
Ray Milkey7531a342014-04-11 15:08:12 -0700130 <module name="MethodName"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700131 <module name="PackageName"/>
Ray Milkey9526d6f2014-04-10 14:54:15 -0700132 <module name="ParameterName"/>
Ray Milkey94b41b52014-04-10 11:13:06 -0700133 <module name="StaticVariableName"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700134 <module name="TypeName"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700135
136 <!-- Checks for imports -->
137 <!-- See http://checkstyle.sf.net/config_import.html -->
138 <module name="AvoidStarImport"/>
Ray Milkey3f5ef562014-03-25 17:11:19 -0700139 <module name="IllegalImport"/>
140 <!-- defaults to sun.* packages -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700141 <module name="RedundantImport"/>
142 <module name="UnusedImports"/>
143
144
145 <!-- Checks for Size Violations. -->
146 <!-- See http://checkstyle.sf.net/config_sizes.html -->
147 <module name="LineLength">
Ray Milkey3f5ef562014-03-25 17:11:19 -0700148 <!-- ONOS standard usage is 80 columns, but we allow up
149 to 120 to not break the build. -->
150 <property name="max" value="120"/>
Yuta HIGUCHI927a3fe2014-06-11 22:14:43 -0700151 <property name="ignorePattern" value="^import"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700152 </module>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700153 <module name="MethodLength">
Ray Milkey098466c2014-04-22 11:36:46 -0700154 <property name="max" value="200"/>
155 </module>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700156
Ray Milkeya5450cc2014-04-17 14:31:30 -0700157 <module name="ParameterNumber"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700158
159 <!-- Checks for whitespace -->
160 <!-- See http://checkstyle.sf.net/config_whitespace.html -->
Ray Milkey7f1567c2014-04-08 13:53:32 -0700161 <module name="EmptyForIteratorPad"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700162 <module name="GenericWhitespace"/>
163 <module name="MethodParamPad"/>
Ray Milkey7f1567c2014-04-08 13:53:32 -0700164 <module name="NoWhitespaceAfter"/>
165 <module name="NoWhitespaceBefore"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700166
Ray Milkey3f5ef562014-03-25 17:11:19 -0700167 <!-- Disabled for ONOS. Default rules specify undesired behavior for the '?' operator -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700168 <!-- <module name="OperatorWrap"/> -->
169 <module name="ParenPad"/>
170 <module name="TypecastParenPad"/>
Ray Milkey7f1567c2014-04-08 13:53:32 -0700171 <module name="WhitespaceAfter"/>
Yuta HIGUCHI5a3e2cf2014-05-20 10:46:35 -0700172 <module name="WhitespaceAround">
173 <property name="allowEmptyConstructors" value="true"/>
174 <property name="allowEmptyMethods" value="true"/>
175 </module>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700176
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700177
178
179 <!-- Modifier Checks -->
180 <!-- See http://checkstyle.sf.net/config_modifiers.html -->
Ray Milkeyec838942014-04-09 11:28:43 -0700181 <module name="ModifierOrder"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700182
Ray Milkey3f5ef562014-03-25 17:11:19 -0700183 <!-- Disabled for ONOS to allow use of public -->
184 <!-- modifiers in interfaces. -->
185 <!-- <module name="RedundantModifier"/> -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700186
187
188 <!-- Checks for blocks. You know, those {}'s -->
189 <!-- See http://checkstyle.sf.net/config_blocks.html -->
190 <module name="AvoidNestedBlocks">
Ray Milkey3f5ef562014-03-25 17:11:19 -0700191 <!-- ONOS alows declarations inside of switch case blocks -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700192 <property name="allowInSwitchCase" value="true"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700193 </module>
Ray Milkey1aa71f82014-04-08 16:23:24 -0700194 <module name="EmptyBlock"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700195 <module name="LeftCurly"/>
Ray Milkeyb29e6262014-04-09 16:02:14 -0700196 <module name="NeedBraces"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700197 <module name="RightCurly"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700198
199 <!-- Checks for common coding problems -->
200 <!-- See http://checkstyle.sf.net/config_coding.html -->
Ray Milkey3f5ef562014-03-25 17:11:19 -0700201 <!-- ONOS allows conditional operators -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700202 <!-- <module name="AvoidInlineConditionals"/> -->
Ray Milkey043daa22014-04-08 14:13:16 -0700203 <module name="EmptyStatement"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700204 <module name="EqualsHashCode"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700205
206 <module name="HiddenField">
Ray Milkey098466c2014-04-22 11:36:46 -0700207 <property name="ignoreSetter" value="true"/>
208 <property name="ignoreConstructorParameter" value="true"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700209 </module>
210
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700211 <module name="IllegalInstantiation"/>
Ray Milkeyb6e0ac82014-04-09 13:21:42 -0700212 <module name="InnerAssignment"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700213
Ray Milkey3f5ef562014-03-25 17:11:19 -0700214 <!-- Many violations of this rule present, revist in a
215 subsequent round of cleanups -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700216 <!-- <module name="MagicNumber"/> -->
Ray Milkey0b122ed2014-04-14 10:06:03 -0700217 <module name="MissingSwitchDefault"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700218
219 <module name="RedundantThrows">
Ray Milkey098466c2014-04-22 11:36:46 -0700220 <property name="allowSubclasses" value="true"/>
221 </module>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700222
Ray Milkey6c4f2fe2014-04-11 09:47:23 -0700223 <module name="SimplifyBooleanExpression"/>
Ray Milkey4985f212014-04-10 16:57:05 -0700224 <module name="SimplifyBooleanReturn"/>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700225
226 <!-- Checks for class design -->
227 <!-- See http://checkstyle.sf.net/config_design.html -->
Ray Milkey3f5ef562014-03-25 17:11:19 -0700228 <!-- ONOS produces many warnings of this type.
229 Fixing all of these is outside the scope of the current cleanup. -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700230 <!-- <module name="DesignForExtension"/> -->
Ray Milkey1584ec82014-04-10 11:58:30 -0700231 <module name="FinalClass"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700232
Ray Milkeya2e21462014-04-10 13:21:44 -0700233 <module name="HideUtilityClassConstructor"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700234
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700235 <module name="InterfaceIsType"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700236
237 <module name="VisibilityModifier">
Ray Milkey098466c2014-04-22 11:36:46 -0700238 <property name="severity" value="warning"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700239 </module>
240
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700241
242
243 <!-- Miscellaneous other checks. -->
244 <!-- See http://checkstyle.sf.net/config_misc.html -->
Ray Milkey45614c52014-04-07 16:30:54 -0700245 <module name="ArrayTypeStyle"/>
Ray Milkeyb5716c52014-04-07 11:38:27 -0700246
Ray Milkey3f5ef562014-03-25 17:11:19 -0700247 <!-- Many violations of this rule currently, too many to fix
248 in the current cleanup. -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700249 <!-- <module name="FinalParameters"/> -->
Ray Milkey3f5ef562014-03-25 17:11:19 -0700250 <!-- ONOS allows TODO markers in checked in source code -->
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700251 <!-- <module name="TodoComment"/> -->
252 <module name="UpperEll"/>
253
Ray Milkeyb5716c52014-04-07 11:38:27 -0700254 </module>
Yuta HIGUCHIf9808442014-03-20 15:56:50 -0700255
Ray Milkeyb5716c52014-04-07 11:38:27 -0700256 </module>