commit a5450cc68e1f1961987b89074bf9aee1f46e554a
author Ray Milkey <ray@onlab.us> Thu Apr 17 14:31:30 2014 -0700
committer Gerrit Code Review <gerrit2@gerrit.onos.onlab.us> Fri Apr 18 10:31:16 2014 -0700
tree f6a20940b483b63e70884c9e461db9a765b608d4
parent 7ff30d03968d66946a50a4c165feb969dd349189

Enable checkstyle rule for too many formal parameters

Enable the "ParameterNumber" checkstyle rule and fix
any violations it uncovers.

There were 4 places in the code that violated this rule.
Changing these APIs was outside of the scope of the current work,
so suppressions were put in place for these 4 classes:

net.onrc.onos.core.intent.ConstrainedShortestPathIntent
net.onrc.onos.core.intent.runtime.PathCalcRuntimeModule
net.onrc.onos.core.linkdiscovery.internal.LinkDiscoveryManager
net.onrc.onos.core.topology.INetworkGraphListener

Change-Id: Iedc4177668efa33347f5c2300005dece68c36925

conf/checkstyle/sun_checks.xml

diff --git a/conf/checkstyle/sun_checks.xml b/conf/checkstyle/sun_checks.xml
index 9460b7c..d2eea90 100644
--- a/conf/checkstyle/sun_checks.xml
+++ b/conf/checkstyle/sun_checks.xml
@@ -151,10 +151,7 @@
           <property name="severity" value="warning"/>
         </module>
 
-        <module name="ParameterNumber">
-          <property name="severity" value="warning"/>
-        </module>
-
+        <module name="ParameterNumber"/>
 
         <!-- Checks for whitespace                               -->
         <!-- See http://checkstyle.sf.net/config_whitespace.html -->