Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 1 | /* |
Brian O'Connor | a09fe5b | 2017-08-03 21:12:30 -0700 | [diff] [blame] | 2 | * Copyright 2016-present Open Networking Foundation |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | package org.onosproject.segmentrouting; |
| 18 | |
Saurav Das | 7bcbe70 | 2017-06-13 15:35:54 -0700 | [diff] [blame] | 19 | import com.google.common.collect.Sets; |
| 20 | |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 21 | import org.onlab.packet.IpPrefix; |
| 22 | import org.onlab.packet.MacAddress; |
Charles Chan | 7ffd81f | 2017-02-08 15:52:08 -0800 | [diff] [blame] | 23 | import org.onlab.packet.VlanId; |
Charles Chan | 9640c81 | 2017-08-23 13:55:39 -0700 | [diff] [blame] | 24 | import org.onosproject.net.ConnectPoint; |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 25 | import org.onosproject.net.HostLocation; |
| 26 | import org.onosproject.net.PortNumber; |
| 27 | import org.onosproject.net.host.HostEvent; |
Ray Milkey | 69ec871 | 2017-08-08 13:00:43 -0700 | [diff] [blame] | 28 | import org.onosproject.routeservice.ResolvedRoute; |
| 29 | import org.onosproject.routeservice.RouteEvent; |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 30 | import org.onosproject.net.DeviceId; |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 31 | import org.onosproject.routeservice.RouteInfo; |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 32 | import org.slf4j.Logger; |
| 33 | import org.slf4j.LoggerFactory; |
| 34 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 35 | import java.util.Collection; |
Charles Chan | b8664b8 | 2017-06-22 14:15:05 -0700 | [diff] [blame] | 36 | import java.util.Objects; |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 37 | import java.util.Optional; |
| 38 | import java.util.Set; |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 39 | import java.util.stream.Collectors; |
Charles Chan | b8664b8 | 2017-06-22 14:15:05 -0700 | [diff] [blame] | 40 | |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 41 | /** |
| 42 | * Handles RouteEvent and manages routing entries. |
| 43 | */ |
| 44 | public class RouteHandler { |
| 45 | private static final Logger log = LoggerFactory.getLogger(RouteHandler.class); |
| 46 | private final SegmentRoutingManager srManager; |
| 47 | |
Charles Chan | 9640c81 | 2017-08-23 13:55:39 -0700 | [diff] [blame] | 48 | RouteHandler(SegmentRoutingManager srManager) { |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 49 | this.srManager = srManager; |
| 50 | } |
| 51 | |
| 52 | protected void init(DeviceId deviceId) { |
Charles Chan | 097029f | 2018-04-13 14:01:49 -0400 | [diff] [blame] | 53 | Optional<DeviceId> pairDeviceId = srManager.getPairDeviceId(deviceId); |
| 54 | |
| 55 | srManager.routeService.getRouteTables().stream() |
| 56 | .map(srManager.routeService::getRoutes) |
| 57 | .flatMap(Collection::stream) |
| 58 | .map(RouteInfo::allRoutes) |
| 59 | .filter(allRoutes -> allRoutes.stream().allMatch(resolvedRoute -> |
| 60 | srManager.nextHopLocations(resolvedRoute).stream().allMatch(cp -> |
| 61 | deviceId.equals(cp.deviceId()) || |
| 62 | (pairDeviceId.isPresent() && pairDeviceId.get().equals(cp.deviceId())) |
| 63 | ))) |
| 64 | .forEach(this::processRouteAddedInternal); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 65 | } |
| 66 | |
Charles Chan | 9640c81 | 2017-08-23 13:55:39 -0700 | [diff] [blame] | 67 | void processRouteAdded(RouteEvent event) { |
Charles Chan | bc11666 | 2018-04-18 18:41:05 -0700 | [diff] [blame] | 68 | processRouteAddedInternal(event.alternatives()); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 69 | } |
| 70 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 71 | private void processRouteAddedInternal(Collection<ResolvedRoute> routes) { |
Charles Chan | b8664b8 | 2017-06-22 14:15:05 -0700 | [diff] [blame] | 72 | if (!isReady()) { |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 73 | log.info("System is not ready. Skip adding route for {}", routes); |
Charles Chan | b8664b8 | 2017-06-22 14:15:05 -0700 | [diff] [blame] | 74 | return; |
| 75 | } |
| 76 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 77 | log.info("processRouteAddedInternal. routes={}", routes); |
Charles Chan | 9640c81 | 2017-08-23 13:55:39 -0700 | [diff] [blame] | 78 | |
Charles Chan | e800860 | 2018-04-09 11:52:08 -0400 | [diff] [blame] | 79 | if (routes.size() > 2) { |
| 80 | log.info("Route {} has more than two next hops. Do not process route change", routes); |
| 81 | return; |
| 82 | } |
| 83 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 84 | Set<ConnectPoint> allLocations = Sets.newHashSet(); |
| 85 | Set<IpPrefix> allPrefixes = Sets.newHashSet(); |
| 86 | routes.forEach(route -> { |
| 87 | allLocations.addAll(srManager.nextHopLocations(route)); |
| 88 | allPrefixes.add(route.prefix()); |
| 89 | }); |
| 90 | log.debug("RouteAdded. populateSubnet {}, {}", allLocations, allPrefixes); |
| 91 | srManager.defaultRoutingHandler.populateSubnet(allLocations, allPrefixes); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 92 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 93 | routes.forEach(route -> { |
| 94 | IpPrefix prefix = route.prefix(); |
| 95 | MacAddress nextHopMac = route.nextHopMac(); |
| 96 | VlanId nextHopVlan = route.nextHopVlan(); |
| 97 | Set<ConnectPoint> locations = srManager.nextHopLocations(route); |
| 98 | |
| 99 | locations.forEach(location -> { |
| 100 | log.debug("RouteAdded. addSubnet {}, {}", location, prefix); |
| 101 | srManager.deviceConfiguration.addSubnet(location, prefix); |
| 102 | log.debug("RouteAdded populateRoute {}, {}, {}, {}", location, prefix, nextHopMac, nextHopVlan); |
| 103 | srManager.defaultRoutingHandler.populateRoute(location.deviceId(), prefix, |
| 104 | nextHopMac, nextHopVlan, location.port()); |
| 105 | }); |
| 106 | }); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 107 | } |
| 108 | |
Charles Chan | 9640c81 | 2017-08-23 13:55:39 -0700 | [diff] [blame] | 109 | void processRouteUpdated(RouteEvent event) { |
Charles Chan | bc11666 | 2018-04-18 18:41:05 -0700 | [diff] [blame] | 110 | processRouteUpdatedInternal(Sets.newHashSet(event.alternatives()), |
| 111 | Sets.newHashSet(event.prevAlternatives())); |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 112 | } |
| 113 | |
| 114 | void processAlternativeRoutesChanged(RouteEvent event) { |
Charles Chan | bc11666 | 2018-04-18 18:41:05 -0700 | [diff] [blame] | 115 | processRouteUpdatedInternal(Sets.newHashSet(event.alternatives()), |
| 116 | Sets.newHashSet(event.prevAlternatives())); |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 117 | } |
| 118 | |
| 119 | private void processRouteUpdatedInternal(Set<ResolvedRoute> routes, Set<ResolvedRoute> oldRoutes) { |
| 120 | if (!isReady()) { |
| 121 | log.info("System is not ready. Skip updating route for {} -> {}", oldRoutes, routes); |
| 122 | return; |
| 123 | } |
| 124 | |
| 125 | log.info("processRouteUpdatedInternal. routes={}, oldRoutes={}", routes, oldRoutes); |
| 126 | |
Charles Chan | e800860 | 2018-04-09 11:52:08 -0400 | [diff] [blame] | 127 | if (routes.size() > 2) { |
| 128 | log.info("Route {} has more than two next hops. Do not process route change", routes); |
| 129 | return; |
| 130 | } |
| 131 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 132 | Set<ConnectPoint> allLocations = Sets.newHashSet(); |
| 133 | Set<IpPrefix> allPrefixes = Sets.newHashSet(); |
| 134 | routes.forEach(route -> { |
| 135 | allLocations.addAll(srManager.nextHopLocations(route)); |
| 136 | allPrefixes.add(route.prefix()); |
| 137 | }); |
Charles Chan | e800860 | 2018-04-09 11:52:08 -0400 | [diff] [blame] | 138 | |
| 139 | // Just come back from an invalid next hop count |
| 140 | // Revoke subnet from all locations and reset oldRoutes such that system will be reprogrammed from scratch |
| 141 | if (oldRoutes.size() > 2) { |
| 142 | log.info("Revoke subnet {} and reset oldRoutes"); |
| 143 | srManager.defaultRoutingHandler.revokeSubnet(allPrefixes); |
| 144 | oldRoutes = Sets.newHashSet(); |
| 145 | } |
| 146 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 147 | log.debug("RouteUpdated. populateSubnet {}, {}", allLocations, allPrefixes); |
| 148 | srManager.defaultRoutingHandler.populateSubnet(allLocations, allPrefixes); |
| 149 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 150 | Set<ResolvedRoute> toBeRemoved = Sets.difference(oldRoutes, routes).immutableCopy(); |
| 151 | Set<ResolvedRoute> toBeAdded = Sets.difference(routes, oldRoutes).immutableCopy(); |
| 152 | |
| 153 | toBeRemoved.forEach(route -> { |
| 154 | srManager.nextHopLocations(route).forEach(oldLocation -> { |
Charles Chan | 9cd528f | 2018-02-05 17:20:05 -0800 | [diff] [blame] | 155 | if (toBeAdded.stream().map(srManager::nextHopLocations) |
| 156 | .flatMap(Set::stream).map(ConnectPoint::deviceId) |
| 157 | .noneMatch(deviceId -> deviceId.equals(oldLocation.deviceId()))) { |
| 158 | IpPrefix prefix = route.prefix(); |
| 159 | log.debug("RouteUpdated. removeSubnet {}, {}", oldLocation, prefix); |
| 160 | srManager.deviceConfiguration.removeSubnet(oldLocation, prefix); |
| 161 | // We don't remove the flow on the old location in occasion of two next hops becoming one |
| 162 | // since the populateSubnet will point the old location to the new location via spine. |
| 163 | } |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 164 | }); |
| 165 | }); |
| 166 | |
| 167 | toBeAdded.forEach(route -> { |
| 168 | IpPrefix prefix = route.prefix(); |
| 169 | MacAddress nextHopMac = route.nextHopMac(); |
| 170 | VlanId nextHopVlan = route.nextHopVlan(); |
| 171 | Set<ConnectPoint> locations = srManager.nextHopLocations(route); |
| 172 | |
| 173 | locations.forEach(location -> { |
| 174 | log.debug("RouteUpdated. addSubnet {}, {}", location, prefix); |
| 175 | srManager.deviceConfiguration.addSubnet(location, prefix); |
| 176 | log.debug("RouteUpdated. populateRoute {}, {}, {}, {}", location, prefix, nextHopMac, nextHopVlan); |
| 177 | srManager.defaultRoutingHandler.populateRoute(location.deviceId(), prefix, |
| 178 | nextHopMac, nextHopVlan, location.port()); |
| 179 | }); |
| 180 | }); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 181 | } |
| 182 | |
Charles Chan | 9640c81 | 2017-08-23 13:55:39 -0700 | [diff] [blame] | 183 | void processRouteRemoved(RouteEvent event) { |
Charles Chan | bc11666 | 2018-04-18 18:41:05 -0700 | [diff] [blame] | 184 | processRouteRemovedInternal(event.alternatives()); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 185 | } |
| 186 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 187 | private void processRouteRemovedInternal(Collection<ResolvedRoute> routes) { |
Charles Chan | b8664b8 | 2017-06-22 14:15:05 -0700 | [diff] [blame] | 188 | if (!isReady()) { |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 189 | log.info("System is not ready. Skip removing route for {}", routes); |
Charles Chan | b8664b8 | 2017-06-22 14:15:05 -0700 | [diff] [blame] | 190 | return; |
| 191 | } |
| 192 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 193 | log.info("processRouteRemovedInternal. routes={}", routes); |
Charles Chan | 9640c81 | 2017-08-23 13:55:39 -0700 | [diff] [blame] | 194 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 195 | Set<IpPrefix> allPrefixes = Sets.newHashSet(); |
| 196 | routes.forEach(route -> { |
| 197 | allPrefixes.add(route.prefix()); |
| 198 | }); |
| 199 | log.debug("RouteRemoved. revokeSubnet {}", allPrefixes); |
| 200 | srManager.defaultRoutingHandler.revokeSubnet(allPrefixes); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 201 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 202 | routes.forEach(route -> { |
| 203 | IpPrefix prefix = route.prefix(); |
| 204 | MacAddress nextHopMac = route.nextHopMac(); |
| 205 | VlanId nextHopVlan = route.nextHopVlan(); |
| 206 | Set<ConnectPoint> locations = srManager.nextHopLocations(route); |
| 207 | |
| 208 | locations.forEach(location -> { |
| 209 | log.debug("RouteRemoved. removeSubnet {}, {}", location, prefix); |
| 210 | srManager.deviceConfiguration.removeSubnet(location, prefix); |
Charles Chan | 1a1a407 | 2018-03-15 16:41:10 -0700 | [diff] [blame] | 211 | // We don't need to call revokeRoute again since revokeSubnet will remove the prefix |
| 212 | // from all devices, including the ones that next hop attaches to. |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 213 | |
| 214 | // Also remove redirection flows on the pair device if exists. |
| 215 | Optional<DeviceId> pairDeviceId = srManager.getPairDeviceId(location.deviceId()); |
Saurav Das | 9062a7f | 2018-04-27 18:42:30 -0700 | [diff] [blame] | 216 | Optional<PortNumber> pairLocalPort = srManager.getPairLocalPort(location.deviceId()); |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 217 | if (pairDeviceId.isPresent() && pairLocalPort.isPresent()) { |
| 218 | // NOTE: Since the pairLocalPort is trunk port, use assigned vlan of original port |
| 219 | // when the host is untagged |
| 220 | VlanId vlanId = Optional.ofNullable(srManager.getInternalVlanId(location)).orElse(nextHopVlan); |
| 221 | |
| 222 | log.debug("RouteRemoved. revokeRoute {}, {}, {}, {}", location, prefix, nextHopMac, nextHopVlan); |
| 223 | srManager.defaultRoutingHandler.revokeRoute(pairDeviceId.get(), prefix, |
| 224 | nextHopMac, vlanId, pairLocalPort.get()); |
| 225 | } |
| 226 | }); |
| 227 | }); |
| 228 | } |
| 229 | |
| 230 | void processHostMovedEvent(HostEvent event) { |
| 231 | log.info("processHostMovedEvent {}", event); |
| 232 | MacAddress hostMac = event.subject().mac(); |
| 233 | VlanId hostVlanId = event.subject().vlan(); |
| 234 | |
| 235 | affectedRoutes(hostMac, hostVlanId).forEach(affectedRoute -> { |
| 236 | IpPrefix prefix = affectedRoute.prefix(); |
| 237 | Set<HostLocation> prevLocations = event.prevSubject().locations(); |
| 238 | Set<HostLocation> newLocations = event.subject().locations(); |
| 239 | |
Charles Chan | f4c2a4d | 2018-07-17 16:33:11 -0700 | [diff] [blame] | 240 | Set<ConnectPoint> connectPoints = newLocations.stream() |
| 241 | .map(l -> (ConnectPoint) l).collect(Collectors.toSet()); |
| 242 | log.debug("HostMoved. populateSubnet {}, {}", newLocations, prefix); |
| 243 | srManager.defaultRoutingHandler.populateSubnet(connectPoints, Sets.newHashSet(prefix)); |
| 244 | |
Charles Chan | bc11666 | 2018-04-18 18:41:05 -0700 | [diff] [blame] | 245 | Set<DeviceId> newDeviceIds = newLocations.stream().map(HostLocation::deviceId) |
| 246 | .collect(Collectors.toSet()); |
| 247 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 248 | // For each old location |
Charles Chan | 880275c | 2018-03-29 16:03:41 -0700 | [diff] [blame] | 249 | Sets.difference(prevLocations, newLocations).forEach(prevLocation -> { |
Charles Chan | bc11666 | 2018-04-18 18:41:05 -0700 | [diff] [blame] | 250 | // Remove flows for unchanged IPs only when the host moves from a switch to another. |
| 251 | // Otherwise, do not remove and let the adding part update the old flow |
Charles Chan | 53eae19 | 2019-02-28 15:40:57 -0800 | [diff] [blame^] | 252 | if (newDeviceIds.contains(prevLocation.deviceId())) { |
| 253 | return; |
Charles Chan | bc11666 | 2018-04-18 18:41:05 -0700 | [diff] [blame] | 254 | } |
Charles Chan | 53eae19 | 2019-02-28 15:40:57 -0800 | [diff] [blame^] | 255 | |
| 256 | log.debug("HostMoved. removeSubnet {}, {}", prevLocation, prefix); |
| 257 | srManager.deviceConfiguration.removeSubnet(prevLocation, prefix); |
| 258 | |
| 259 | // Do not remove flow from a device if the route is still reachable via its pair device. |
| 260 | // populateSubnet will update the flow to point to its pair device via spine. |
| 261 | DeviceId pairDeviceId = srManager.getPairDeviceId(prevLocation.deviceId()).orElse(null); |
| 262 | if (newLocations.stream().anyMatch(n -> n.deviceId().equals(pairDeviceId))) { |
| 263 | return; |
| 264 | } |
| 265 | |
| 266 | log.debug("HostMoved. revokeRoute {}, {}, {}, {}", prevLocation, prefix, hostMac, hostVlanId); |
| 267 | srManager.defaultRoutingHandler.revokeRoute(prevLocation.deviceId(), prefix, |
| 268 | hostMac, hostVlanId, prevLocation.port()); |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 269 | }); |
| 270 | |
| 271 | // For each new location, add all new IPs. |
Charles Chan | 880275c | 2018-03-29 16:03:41 -0700 | [diff] [blame] | 272 | Sets.difference(newLocations, prevLocations).forEach(newLocation -> { |
Charles Chan | f4c2a4d | 2018-07-17 16:33:11 -0700 | [diff] [blame] | 273 | log.debug("HostMoved. addSubnet {}, {}", newLocation, prefix); |
| 274 | srManager.deviceConfiguration.addSubnet(newLocation, prefix); |
| 275 | |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 276 | log.debug("HostMoved. populateRoute {}, {}, {}, {}", newLocation, prefix, hostMac, hostVlanId); |
| 277 | srManager.defaultRoutingHandler.populateRoute(newLocation.deviceId(), prefix, |
| 278 | hostMac, hostVlanId, newLocation.port()); |
| 279 | }); |
| 280 | |
| 281 | }); |
| 282 | } |
| 283 | |
| 284 | private Set<ResolvedRoute> affectedRoutes(MacAddress mac, VlanId vlanId) { |
| 285 | return srManager.routeService.getRouteTables().stream() |
| 286 | .map(routeTableId -> srManager.routeService.getRoutes(routeTableId)) |
| 287 | .flatMap(Collection::stream) |
| 288 | .map(RouteInfo::allRoutes) |
| 289 | .flatMap(Collection::stream) |
| 290 | .filter(resolvedRoute -> mac.equals(resolvedRoute.nextHopMac()) && |
| 291 | vlanId.equals(resolvedRoute.nextHopVlan())).collect(Collectors.toSet()); |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 292 | } |
Charles Chan | b8664b8 | 2017-06-22 14:15:05 -0700 | [diff] [blame] | 293 | |
| 294 | private boolean isReady() { |
| 295 | return Objects.nonNull(srManager.deviceConfiguration) && |
Charles Chan | 2fde6d4 | 2017-08-23 14:46:43 -0700 | [diff] [blame] | 296 | Objects.nonNull(srManager.defaultRoutingHandler); |
| 297 | } |
Charles Chan | 03a73e0 | 2016-10-24 14:52:01 -0700 | [diff] [blame] | 298 | } |