commit fe5d8dfd52aa73fb13c977623d35d74e8f440363
author Andrea Campanella <andrea@opennetworking.org> Mon Mar 12 11:07:35 2018 -0700
committer Ray Milkey <ray@opennetworking.org> Tue Mar 13 01:50:38 2018 +0000
tree 3edc89458ec251efdf2846fff2c049a8635000c8
parent 7fa8f0ac01a5f8ff7af52bbe4f3e6b72f93516dc

T3: bugfixes and avoid override of finalize

Change-Id: I7e0ddcec59ae75dae30d083b7d873255ad5991f1
(cherry picked from commit 3577bae12a5b395e2113c6035edca08a6339c1a0)

src/main/java/org/onosproject/t3/impl/Generator.java

diff --git a/src/main/java/org/onosproject/t3/impl/Generator.java b/src/main/java/org/onosproject/t3/impl/Generator.java
index 95e4d4e..82ad628 100644
--- a/src/main/java/org/onosproject/t3/impl/Generator.java
+++ b/src/main/java/org/onosproject/t3/impl/Generator.java
@@ -97,6 +97,14 @@
                     itemAvailableOrHasFinished.await();
                 } catch (InterruptedException e) {
                     hasFinished = true;
+                    producer.interrupt();
+                    try {
+                        producer.join();
+                    } catch (InterruptedException e1) {
+                        // Interrupting the broken thread
+                        Thread.currentThread().interrupt();
+                        throw new IllegalStateException(e1);
+                    }
                 }
                 if (exceptionRaisedByProducer != null) {
                     throw exceptionRaisedByProducer;
@@ -137,11 +145,4 @@
         producer.setDaemon(true);
         producer.start();
     }
-
-    @Override
-    protected void finalize() throws Throwable {
-        producer.interrupt();
-        producer.join();
-        super.finalize();
-    }
 }
\ No newline at end of file

src/main/java/org/onosproject/t3/impl/TroubleshootManager.java

diff --git a/src/main/java/org/onosproject/t3/impl/TroubleshootManager.java b/src/main/java/org/onosproject/t3/impl/TroubleshootManager.java
index 74933f6..3564750 100644
--- a/src/main/java/org/onosproject/t3/impl/TroubleshootManager.java
+++ b/src/main/java/org/onosproject/t3/impl/TroubleshootManager.java
@@ -424,8 +424,9 @@
                     && ((VlanIdCriterion) trace.getInitialPacket().getCriterion(Criterion.Type.VLAN_VID)).vlanId()
                     .equals(((VlanIdCriterion) outputPath.getFinalPacket().getCriterion(Criterion.Type.VLAN_VID))
                             .vlanId())) {
-                trace.addResultMessage("Connect point out " + cp + " is same as initial input " +
-                        trace.getInitialConnectPoint());
+                if (computePath(completePath, trace, outputPath.getOutput())) {
+                    trace.addResultMessage("Connect point out " + cp + " is same as initial input " + in);
+                }
                 break;
             }