Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 1 | <?xml version="1.0"?> |
| 2 | <!DOCTYPE module PUBLIC |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 3 | "-//Puppy Crawl//DTD Check Configuration 1.3//EN" |
| 4 | "http://www.puppycrawl.com/dtds/configuration_1_3.dtd"> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 5 | |
| 6 | |
| 7 | <!-- |
| 8 | |
| 9 | Checkstyle configuration that checks the sun coding conventions from: |
| 10 | |
| 11 | - the Java Language Specification at |
| 12 | http://java.sun.com/docs/books/jls/second_edition/html/index.html |
| 13 | |
| 14 | - the Sun Code Conventions at http://java.sun.com/docs/codeconv/ |
| 15 | |
| 16 | - the Javadoc guidelines at |
| 17 | http://java.sun.com/j2se/javadoc/writingdoccomments/index.html |
| 18 | |
| 19 | - the JDK Api documentation http://java.sun.com/j2se/docs/api/index.html |
| 20 | |
| 21 | - some best practices |
| 22 | |
| 23 | Checkstyle is very configurable. Be sure to read the documentation at |
| 24 | http://checkstyle.sf.net (or in your downloaded distribution). |
| 25 | |
| 26 | Most Checks are configurable, be sure to consult the documentation. |
| 27 | |
| 28 | To completely disable a check, just comment it out or delete it from the file. |
| 29 | |
| 30 | Finally, it is worth reading the documentation. |
| 31 | |
| 32 | --> |
| 33 | |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 34 | |
| 35 | <!-- |
| 36 | The default severity setting in checkstyle is 'error', so some |
| 37 | of the rules below are configured to change the severity to |
| 38 | 'warning'. Over time, these 'warning' settings should be |
| 39 | removed as more of the ONOS source code is modified to |
| 40 | follow the recommended rules. |
| 41 | --> |
| 42 | |
| 43 | |
| 44 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 45 | <module name="Checker"> |
Yuta HIGUCHI | cbbaed3 | 2014-05-14 20:27:43 -0700 | [diff] [blame] | 46 | <module name="SuppressionFilter"> |
| 47 | <property name="file" value="${config_loc}/onos_suppressions.xml"/> |
| 48 | </module> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 49 | <!-- |
| 50 | If you set the basedir property below, then all reported file |
| 51 | names will be relative to the specified directory. See |
| 52 | http://checkstyle.sourceforge.net/5.x/config.html#Checker |
| 53 | |
| 54 | <property name="basedir" value="${basedir}"/> |
| 55 | --> |
| 56 | <!-- Checks that a package-info.java file exists for each package. --> |
| 57 | <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage --> |
| 58 | <!-- ONOS does not currently supply package level Javadoc information |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 59 | in package-info files --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 60 | <!-- <module name="JavadocPackage"/> --> |
| 61 | |
| 62 | <!-- Checks whether files end with a new line. --> |
| 63 | <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile --> |
Ray Milkey | 0f913a0 | 2014-04-07 20:58:17 -0700 | [diff] [blame] | 64 | <module name="NewlineAtEndOfFile"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 65 | |
| 66 | <!-- Checks that property files contain the same keys. --> |
| 67 | <!-- See http://checkstyle.sf.net/config_misc.html#Translation --> |
| 68 | <module name="Translation"/> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 69 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 70 | <!-- Checks for Size Violations. --> |
| 71 | <!-- See http://checkstyle.sf.net/config_sizes.html --> |
Ray Milkey | 0b122ed | 2014-04-14 10:06:03 -0700 | [diff] [blame] | 72 | <module name="FileLength"/> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 73 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 74 | <!-- Checks for whitespace --> |
| 75 | <!-- See http://checkstyle.sf.net/config_whitespace.html --> |
| 76 | <module name="FileTabCharacter"/> |
| 77 | |
| 78 | <!-- Miscellaneous other checks. --> |
| 79 | <!-- See http://checkstyle.sf.net/config_misc.html --> |
| 80 | <module name="RegexpSingleline"> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 81 | <property name="format" value="\s+$"/> |
| 82 | <property name="minimum" value="0"/> |
| 83 | <property name="maximum" value="0"/> |
| 84 | <property name="message" value="Line has trailing spaces."/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 85 | </module> |
| 86 | |
| 87 | <!-- Checks for Headers --> |
| 88 | <!-- See http://checkstyle.sf.net/config_header.html --> |
| 89 | <!-- <module name="Header"> --> |
| 90 | <!-- <property name="headerFile" value="${checkstyle.header.file}"/> --> |
| 91 | <!-- <property name="fileExtensions" value="java"/> --> |
| 92 | <!-- </module> --> |
| 93 | |
Ray Milkey | 5df613b | 2014-04-15 10:50:56 -0700 | [diff] [blame] | 94 | <module name="SuppressionCommentFilter"> |
Yuta HIGUCHI | a4d51d4 | 2014-06-19 17:54:09 -0700 | [diff] [blame] | 95 | <property name="offCommentFormat" value="(CHECKSTYLE\:OFF|Generated by the protocol buffer compiler.)"/> |
Ray Milkey | 098466c | 2014-04-22 11:36:46 -0700 | [diff] [blame] | 96 | <property name="onCommentFormat" value="CHECKSTYLE:ON"/> |
Ray Milkey | 5df613b | 2014-04-15 10:50:56 -0700 | [diff] [blame] | 97 | </module> |
Yuta HIGUCHI | 5dc8664 | 2014-06-25 14:13:45 -0700 | [diff] [blame] | 98 | |
| 99 | <module name="SuppressWithNearbyCommentFilter"> |
| 100 | <property name="commentFormat" value="CHECKSTYLE IGNORE THIS LINE" /> |
| 101 | <property name="checkFormat" value=".*" /> |
| 102 | <property name="influenceFormat" value="0" /> |
| 103 | </module> |
| 104 | |
| 105 | <!-- Example: // CHECKSTYLE IGNORE FinalClass FOR NEXT 1 LINES --> |
| 106 | <module name="SuppressWithNearbyCommentFilter"> |
| 107 | <property name="commentFormat" value="CHECKSTYLE IGNORE (\w+) FOR NEXT (\d+) LINES"/> |
| 108 | <property name="checkFormat" value="$1"/> |
| 109 | <property name="influenceFormat" value="$2"/> |
| 110 | </module> |
| 111 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 112 | <module name="TreeWalker"> |
| 113 | |
Ray Milkey | 5df613b | 2014-04-15 10:50:56 -0700 | [diff] [blame] | 114 | <module name="FileContentsHolder"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 115 | <!-- Checks for Javadoc comments. --> |
| 116 | <!-- See http://checkstyle.sf.net/config_javadoc.html --> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 117 | <module name="JavadocMethod"> |
Ray Milkey | 098466c | 2014-04-22 11:36:46 -0700 | [diff] [blame] | 118 | <property name="severity" value="warning"/> |
Yuta HIGUCHI | cd0f042 | 2014-08-02 16:33:39 -0700 | [diff] [blame] | 119 | <property name="allowUndeclaredRTE" value="true"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 120 | </module> |
| 121 | <module name="JavadocType"> |
Ray Milkey | 098466c | 2014-04-22 11:36:46 -0700 | [diff] [blame] | 122 | <property name="severity" value="warning"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 123 | </module> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 124 | <module name="JavadocVariable"> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 125 | <!-- Suppress check for private member Javadocs. |
| 126 | Possibly revist fixing these. --> |
| 127 | <property name="scope" value="public"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 128 | <property name="severity" value="warning"/> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 129 | </module> |
Ray Milkey | b41100a | 2014-04-10 10:42:15 -0700 | [diff] [blame] | 130 | <module name="JavadocStyle"/> |
Yuta HIGUCHI | aa132f5 | 2014-06-26 10:18:39 -0700 | [diff] [blame] | 131 | <!-- @author tag should not be used --> |
| 132 | <module name="WriteTag"> |
| 133 | <property name="tag" value="@author"/> |
| 134 | <property name="tagFormat" value="\S"/> |
| 135 | <property name="severity" value="ignore"/> |
| 136 | <property name="tagSeverity" value="error"/> |
| 137 | </module> |
| 138 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 139 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 140 | <!-- Checks for Naming Conventions. --> |
| 141 | <!-- See http://checkstyle.sf.net/config_naming.html --> |
Ray Milkey | ec49771 | 2014-03-20 17:51:22 -0700 | [diff] [blame] | 142 | <module name="ConstantName"> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 143 | <!-- ONOS allows the name "log" for static final Loggers --> |
| 144 | <property name="format" |
| 145 | value="^log$|^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/> |
| 146 | </module> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 147 | <module name="LocalFinalVariableName"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 148 | |
Ray Milkey | 2476cac | 2014-04-08 11:03:21 -0700 | [diff] [blame] | 149 | <module name="LocalVariableName"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 150 | |
Ray Milkey | 2476cac | 2014-04-08 11:03:21 -0700 | [diff] [blame] | 151 | <module name="MemberName"/> |
Ray Milkey | 7531a34 | 2014-04-11 15:08:12 -0700 | [diff] [blame] | 152 | <module name="MethodName"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 153 | <module name="PackageName"/> |
Ray Milkey | 9526d6f | 2014-04-10 14:54:15 -0700 | [diff] [blame] | 154 | <module name="ParameterName"/> |
Ray Milkey | 94b41b5 | 2014-04-10 11:13:06 -0700 | [diff] [blame] | 155 | <module name="StaticVariableName"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 156 | <module name="TypeName"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 157 | |
| 158 | <!-- Checks for imports --> |
| 159 | <!-- See http://checkstyle.sf.net/config_import.html --> |
Yuta HIGUCHI | 91a8f50 | 2014-06-17 10:15:29 -0700 | [diff] [blame] | 160 | <module name="AvoidStarImport"> |
| 161 | <property name="allowStaticMemberImports" value="true"/> |
| 162 | </module> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 163 | <module name="IllegalImport"/> |
| 164 | <!-- defaults to sun.* packages --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 165 | <module name="RedundantImport"/> |
| 166 | <module name="UnusedImports"/> |
| 167 | |
| 168 | |
| 169 | <!-- Checks for Size Violations. --> |
| 170 | <!-- See http://checkstyle.sf.net/config_sizes.html --> |
| 171 | <module name="LineLength"> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 172 | <!-- ONOS standard usage is 80 columns, but we allow up |
| 173 | to 120 to not break the build. --> |
| 174 | <property name="max" value="120"/> |
Yuta HIGUCHI | 927a3fe | 2014-06-11 22:14:43 -0700 | [diff] [blame] | 175 | <property name="ignorePattern" value="^import"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 176 | </module> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 177 | <module name="MethodLength"> |
Ray Milkey | 098466c | 2014-04-22 11:36:46 -0700 | [diff] [blame] | 178 | <property name="max" value="200"/> |
| 179 | </module> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 180 | |
Ray Milkey | 5bf7f6f | 2014-08-15 10:20:40 -0700 | [diff] [blame] | 181 | <!-- This rule modification should be removed when the code that |
| 182 | uses long parameter lists is refactored. Intents and Topology |
| 183 | violate this standard. --> |
| 184 | <module name="ParameterNumber"> |
| 185 | <property name="max" value="10"/> |
| 186 | <property name="tokens" value="METHOD_DEF"/> |
| 187 | </module> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 188 | |
| 189 | <!-- Checks for whitespace --> |
| 190 | <!-- See http://checkstyle.sf.net/config_whitespace.html --> |
Ray Milkey | 7f1567c | 2014-04-08 13:53:32 -0700 | [diff] [blame] | 191 | <module name="EmptyForIteratorPad"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 192 | <module name="GenericWhitespace"/> |
| 193 | <module name="MethodParamPad"/> |
Ray Milkey | 7f1567c | 2014-04-08 13:53:32 -0700 | [diff] [blame] | 194 | <module name="NoWhitespaceAfter"/> |
| 195 | <module name="NoWhitespaceBefore"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 196 | |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 197 | <!-- Disabled for ONOS. Default rules specify undesired behavior for the '?' operator --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 198 | <!-- <module name="OperatorWrap"/> --> |
| 199 | <module name="ParenPad"/> |
| 200 | <module name="TypecastParenPad"/> |
Ray Milkey | 7f1567c | 2014-04-08 13:53:32 -0700 | [diff] [blame] | 201 | <module name="WhitespaceAfter"/> |
Yuta HIGUCHI | 5a3e2cf | 2014-05-20 10:46:35 -0700 | [diff] [blame] | 202 | <module name="WhitespaceAround"> |
| 203 | <property name="allowEmptyConstructors" value="true"/> |
| 204 | <property name="allowEmptyMethods" value="true"/> |
Yuta HIGUCHI | 04f16a6 | 2014-09-02 15:00:01 -0700 | [diff] [blame] | 205 | <property name="ignoreEnhancedForColon" value="false"/> |
Yuta HIGUCHI | 5a3e2cf | 2014-05-20 10:46:35 -0700 | [diff] [blame] | 206 | </module> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 207 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 208 | |
| 209 | |
| 210 | <!-- Modifier Checks --> |
| 211 | <!-- See http://checkstyle.sf.net/config_modifiers.html --> |
Ray Milkey | ec83894 | 2014-04-09 11:28:43 -0700 | [diff] [blame] | 212 | <module name="ModifierOrder"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 213 | |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 214 | <!-- Disabled for ONOS to allow use of public --> |
| 215 | <!-- modifiers in interfaces. --> |
| 216 | <!-- <module name="RedundantModifier"/> --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 217 | |
| 218 | |
| 219 | <!-- Checks for blocks. You know, those {}'s --> |
| 220 | <!-- See http://checkstyle.sf.net/config_blocks.html --> |
| 221 | <module name="AvoidNestedBlocks"> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 222 | <!-- ONOS alows declarations inside of switch case blocks --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 223 | <property name="allowInSwitchCase" value="true"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 224 | </module> |
Ray Milkey | 1aa71f8 | 2014-04-08 16:23:24 -0700 | [diff] [blame] | 225 | <module name="EmptyBlock"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 226 | <module name="LeftCurly"/> |
Ray Milkey | b29e626 | 2014-04-09 16:02:14 -0700 | [diff] [blame] | 227 | <module name="NeedBraces"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 228 | <module name="RightCurly"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 229 | |
| 230 | <!-- Checks for common coding problems --> |
| 231 | <!-- See http://checkstyle.sf.net/config_coding.html --> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 232 | <!-- ONOS allows conditional operators --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 233 | <!-- <module name="AvoidInlineConditionals"/> --> |
Ray Milkey | 043daa2 | 2014-04-08 14:13:16 -0700 | [diff] [blame] | 234 | <module name="EmptyStatement"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 235 | <module name="EqualsHashCode"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 236 | |
| 237 | <module name="HiddenField"> |
Ray Milkey | 098466c | 2014-04-22 11:36:46 -0700 | [diff] [blame] | 238 | <property name="ignoreSetter" value="true"/> |
| 239 | <property name="ignoreConstructorParameter" value="true"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 240 | </module> |
| 241 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 242 | <module name="IllegalInstantiation"/> |
Ray Milkey | b6e0ac8 | 2014-04-09 13:21:42 -0700 | [diff] [blame] | 243 | <module name="InnerAssignment"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 244 | |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 245 | <!-- Many violations of this rule present, revist in a |
| 246 | subsequent round of cleanups --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 247 | <!-- <module name="MagicNumber"/> --> |
Ray Milkey | 0b122ed | 2014-04-14 10:06:03 -0700 | [diff] [blame] | 248 | <module name="MissingSwitchDefault"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 249 | |
| 250 | <module name="RedundantThrows"> |
Ray Milkey | 098466c | 2014-04-22 11:36:46 -0700 | [diff] [blame] | 251 | <property name="allowSubclasses" value="true"/> |
| 252 | </module> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 253 | |
Ray Milkey | 6c4f2fe | 2014-04-11 09:47:23 -0700 | [diff] [blame] | 254 | <module name="SimplifyBooleanExpression"/> |
Ray Milkey | 4985f21 | 2014-04-10 16:57:05 -0700 | [diff] [blame] | 255 | <module name="SimplifyBooleanReturn"/> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 256 | |
| 257 | <!-- Checks for class design --> |
| 258 | <!-- See http://checkstyle.sf.net/config_design.html --> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 259 | <!-- ONOS produces many warnings of this type. |
| 260 | Fixing all of these is outside the scope of the current cleanup. --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 261 | <!-- <module name="DesignForExtension"/> --> |
Ray Milkey | 1584ec8 | 2014-04-10 11:58:30 -0700 | [diff] [blame] | 262 | <module name="FinalClass"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 263 | |
Ray Milkey | a2e2146 | 2014-04-10 13:21:44 -0700 | [diff] [blame] | 264 | <module name="HideUtilityClassConstructor"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 265 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 266 | <module name="InterfaceIsType"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 267 | |
| 268 | <module name="VisibilityModifier"> |
Ray Milkey | 098466c | 2014-04-22 11:36:46 -0700 | [diff] [blame] | 269 | <property name="severity" value="warning"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 270 | </module> |
| 271 | |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 272 | |
| 273 | |
| 274 | <!-- Miscellaneous other checks. --> |
| 275 | <!-- See http://checkstyle.sf.net/config_misc.html --> |
Ray Milkey | 45614c5 | 2014-04-07 16:30:54 -0700 | [diff] [blame] | 276 | <module name="ArrayTypeStyle"/> |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 277 | |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 278 | <!-- Many violations of this rule currently, too many to fix |
| 279 | in the current cleanup. --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 280 | <!-- <module name="FinalParameters"/> --> |
Ray Milkey | 3f5ef56 | 2014-03-25 17:11:19 -0700 | [diff] [blame] | 281 | <!-- ONOS allows TODO markers in checked in source code --> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 282 | <!-- <module name="TodoComment"/> --> |
| 283 | <module name="UpperEll"/> |
| 284 | |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 285 | </module> |
Yuta HIGUCHI | f980844 | 2014-03-20 15:56:50 -0700 | [diff] [blame] | 286 | |
Ray Milkey | b5716c5 | 2014-04-07 11:38:27 -0700 | [diff] [blame] | 287 | </module> |