Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 1 | /* |
Jian Li | 8e7e6cd | 2018-03-30 13:33:08 +0900 | [diff] [blame] | 2 | * Copyright 2016-present Open Networking Foundation |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
Hyunsun Moon | 0540087 | 2017-02-07 17:11:25 +0900 | [diff] [blame] | 16 | package org.onosproject.openstacknetworking.impl; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 17 | |
| 18 | import com.google.common.base.Strings; |
| 19 | import com.google.common.collect.Sets; |
| 20 | import org.apache.felix.scr.annotations.Activate; |
| 21 | import org.apache.felix.scr.annotations.Component; |
| 22 | import org.apache.felix.scr.annotations.Deactivate; |
| 23 | import org.apache.felix.scr.annotations.Modified; |
| 24 | import org.apache.felix.scr.annotations.Property; |
| 25 | import org.apache.felix.scr.annotations.Reference; |
| 26 | import org.apache.felix.scr.annotations.ReferenceCardinality; |
| 27 | import org.onlab.packet.ARP; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 28 | import org.onlab.packet.EthType; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 29 | import org.onlab.packet.Ethernet; |
| 30 | import org.onlab.packet.Ip4Address; |
| 31 | import org.onlab.packet.IpAddress; |
| 32 | import org.onlab.packet.MacAddress; |
| 33 | import org.onlab.util.Tools; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 34 | import org.onosproject.cfg.ComponentConfigService; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 35 | import org.onosproject.cluster.ClusterService; |
| 36 | import org.onosproject.cluster.LeadershipService; |
| 37 | import org.onosproject.cluster.NodeId; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 38 | import org.onosproject.core.ApplicationId; |
| 39 | import org.onosproject.core.CoreService; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 40 | import org.onosproject.mastership.MastershipService; |
| 41 | import org.onosproject.net.PortNumber; |
| 42 | import org.onosproject.net.device.DeviceService; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 43 | import org.onosproject.net.flow.DefaultTrafficSelector; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 44 | import org.onosproject.net.flow.DefaultTrafficTreatment; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 45 | import org.onosproject.net.flow.TrafficSelector; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 46 | import org.onosproject.net.flow.TrafficTreatment; |
| 47 | import org.onosproject.net.packet.DefaultOutboundPacket; |
| 48 | import org.onosproject.net.packet.PacketContext; |
| 49 | import org.onosproject.net.packet.PacketProcessor; |
| 50 | import org.onosproject.net.packet.PacketService; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 51 | import org.onosproject.openstacknetworking.api.InstancePort; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 52 | import org.onosproject.openstacknetworking.api.InstancePortEvent; |
| 53 | import org.onosproject.openstacknetworking.api.InstancePortListener; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 54 | import org.onosproject.openstacknetworking.api.InstancePortService; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 55 | import org.onosproject.openstacknetworking.api.OpenstackFlowRuleService; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 56 | import org.onosproject.openstacknetworking.api.OpenstackNetworkEvent; |
| 57 | import org.onosproject.openstacknetworking.api.OpenstackNetworkListener; |
| 58 | import org.onosproject.openstacknetworking.api.OpenstackNetworkService; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 59 | import org.onosproject.openstacknode.api.OpenstackNode; |
| 60 | import org.onosproject.openstacknode.api.OpenstackNodeEvent; |
| 61 | import org.onosproject.openstacknode.api.OpenstackNodeListener; |
| 62 | import org.onosproject.openstacknode.api.OpenstackNodeService; |
| 63 | import org.openstack4j.model.network.Network; |
| 64 | import org.openstack4j.model.network.NetworkType; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 65 | import org.openstack4j.model.network.Subnet; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 66 | import org.osgi.service.component.ComponentContext; |
| 67 | import org.slf4j.Logger; |
| 68 | import org.slf4j.LoggerFactory; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 69 | |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 70 | import java.nio.ByteBuffer; |
| 71 | import java.util.Dictionary; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 72 | import java.util.Objects; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 73 | import java.util.Set; |
| 74 | |
| 75 | import static com.google.common.base.Preconditions.checkNotNull; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 76 | import static org.onosproject.openstacknetworking.api.Constants.ARP_BROADCAST_MODE; |
| 77 | import static org.onosproject.openstacknetworking.api.Constants.ARP_PROXY_MODE; |
| 78 | import static org.onosproject.openstacknetworking.api.Constants.DEFAULT_ARP_MODE_STR; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 79 | import static org.onosproject.openstacknetworking.api.Constants.DEFAULT_GATEWAY_MAC_STR; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 80 | import static org.onosproject.openstacknetworking.api.Constants.DHCP_ARP_TABLE; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 81 | import static org.onosproject.openstacknetworking.api.Constants.OPENSTACK_NETWORKING_APP_ID; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 82 | import static org.onosproject.openstacknetworking.api.Constants.PRIORITY_ARP_CONTROL_RULE; |
| 83 | import static org.onosproject.openstacknetworking.api.Constants.PRIORITY_ARP_GATEWAY_RULE; |
| 84 | import static org.onosproject.openstacknetworking.api.Constants.PRIORITY_ARP_REPLY_RULE; |
| 85 | import static org.onosproject.openstacknetworking.api.Constants.PRIORITY_ARP_REQUEST_RULE; |
| 86 | import static org.onosproject.openstacknetworking.api.Constants.PRIORITY_ARP_SUBNET_RULE; |
| 87 | import static org.onosproject.openstacknetworking.util.RulePopulatorUtil.buildExtension; |
| 88 | import static org.onosproject.openstacknode.api.OpenstackNode.NodeType.COMPUTE; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 89 | |
| 90 | /** |
| 91 | * Handles ARP packet from VMs. |
| 92 | */ |
| 93 | @Component(immediate = true) |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 94 | public final class OpenstackSwitchingArpHandler { |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 95 | |
| 96 | private final Logger log = LoggerFactory.getLogger(getClass()); |
| 97 | |
| 98 | private static final String GATEWAY_MAC = "gatewayMac"; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 99 | private static final String ARP_MODE = "arpMode"; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 100 | |
| 101 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 102 | CoreService coreService; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 103 | |
| 104 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 105 | PacketService packetService; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 106 | |
| 107 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 108 | OpenstackFlowRuleService osFlowRuleService; |
| 109 | |
| 110 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 111 | ComponentConfigService configService; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 112 | |
| 113 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 114 | ClusterService clusterService; |
| 115 | |
| 116 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 117 | LeadershipService leadershipService; |
| 118 | |
| 119 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 120 | DeviceService deviceService; |
| 121 | |
| 122 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 123 | MastershipService mastershipService; |
| 124 | |
| 125 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 126 | InstancePortService instancePortService; |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 127 | |
| 128 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 129 | OpenstackNetworkService osNetworkService; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 130 | |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 131 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 132 | protected OpenstackNodeService osNodeService; |
| 133 | |
Hyunsun Moon | b3eb84d | 2016-07-27 19:10:52 -0700 | [diff] [blame] | 134 | @Property(name = GATEWAY_MAC, value = DEFAULT_GATEWAY_MAC_STR, |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 135 | label = "Fake MAC address for virtual network subnet gateway") |
Hyunsun Moon | b3eb84d | 2016-07-27 19:10:52 -0700 | [diff] [blame] | 136 | private String gatewayMac = DEFAULT_GATEWAY_MAC_STR; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 137 | |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 138 | @Property(name = ARP_MODE, value = DEFAULT_ARP_MODE_STR, |
Daniel Park | 6041f10 | 2018-07-06 18:49:45 +0900 | [diff] [blame] | 139 | label = "ARP processing mode, broadcast | proxy (default)") |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 140 | protected String arpMode = DEFAULT_ARP_MODE_STR; |
| 141 | |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 142 | private final InternalPacketProcessor packetProcessor = new InternalPacketProcessor(); |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 143 | private final InternalOpenstackNetworkListener osNetworkListener = |
| 144 | new InternalOpenstackNetworkListener(); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 145 | private final InstancePortListener instancePortListener = new InternalInstancePortListener(); |
| 146 | private final OpenstackNodeListener osNodeListener = new InternalNodeEventListener(); |
| 147 | |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 148 | private final Set<IpAddress> gateways = Sets.newConcurrentHashSet(); |
| 149 | |
| 150 | private ApplicationId appId; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 151 | private NodeId localNodeId; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 152 | |
| 153 | @Activate |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 154 | void activate() { |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 155 | appId = coreService.registerApplication(OPENSTACK_NETWORKING_APP_ID); |
| 156 | configService.registerProperties(getClass()); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 157 | localNodeId = clusterService.getLocalNode().id(); |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 158 | osNetworkService.addListener(osNetworkListener); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 159 | osNodeService.addListener(osNodeListener); |
| 160 | leadershipService.runForLeadership(appId.name()); |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 161 | packetService.addProcessor(packetProcessor, PacketProcessor.director(0)); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 162 | |
| 163 | instancePortService.addListener(instancePortListener); |
| 164 | |
| 165 | osNetworkService.networks().forEach(n -> { |
| 166 | if (n.getNetworkType() != NetworkType.FLAT) { |
| 167 | osNetworkService.subnets().forEach(s -> { |
| 168 | if (s.getNetworkId().equals(n.getId())) { |
| 169 | addSubnetGateway(s); |
| 170 | } |
| 171 | }); |
| 172 | } |
| 173 | }); |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 174 | |
| 175 | log.info("Started"); |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 176 | } |
| 177 | |
| 178 | @Deactivate |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 179 | void deactivate() { |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 180 | packetService.removeProcessor(packetProcessor); |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 181 | osNetworkService.removeListener(osNetworkListener); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 182 | osNodeService.removeListener(osNodeListener); |
| 183 | instancePortService.removeListener(instancePortListener); |
| 184 | leadershipService.withdraw(appId.name()); |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 185 | configService.unregisterProperties(getClass(), false); |
| 186 | |
| 187 | log.info("Stopped"); |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 188 | } |
| 189 | |
| 190 | @Modified |
Ray Milkey | 9c9cde4 | 2018-01-12 14:22:06 -0800 | [diff] [blame] | 191 | void modified(ComponentContext context) { |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 192 | Dictionary<?, ?> properties = context.getProperties(); |
| 193 | String updatedMac; |
| 194 | |
| 195 | updatedMac = Tools.get(properties, GATEWAY_MAC); |
| 196 | if (!Strings.isNullOrEmpty(updatedMac) && !updatedMac.equals(gatewayMac)) { |
| 197 | gatewayMac = updatedMac; |
| 198 | } |
| 199 | |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 200 | String updateArpMode; |
| 201 | |
| 202 | updateArpMode = Tools.get(properties, ARP_MODE); |
| 203 | if (!Strings.isNullOrEmpty(updateArpMode) && !updateArpMode.equals(arpMode)) { |
| 204 | arpMode = updateArpMode; |
| 205 | } |
| 206 | |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 207 | log.info("Modified"); |
| 208 | } |
| 209 | |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 210 | private void addSubnetGateway(Subnet osSubnet) { |
| 211 | if (Strings.isNullOrEmpty(osSubnet.getGateway())) { |
| 212 | return; |
| 213 | } |
| 214 | IpAddress gatewayIp = IpAddress.valueOf(osSubnet.getGateway()); |
| 215 | gateways.add(gatewayIp); |
| 216 | log.debug("Added ARP proxy entry IP:{}", gatewayIp); |
| 217 | } |
| 218 | |
| 219 | private void removeSubnetGateway(Subnet osSubnet) { |
| 220 | if (Strings.isNullOrEmpty(osSubnet.getGateway())) { |
| 221 | return; |
| 222 | } |
| 223 | IpAddress gatewayIp = IpAddress.valueOf(osSubnet.getGateway()); |
| 224 | gateways.remove(gatewayIp); |
| 225 | log.debug("Removed ARP proxy entry IP:{}", gatewayIp); |
| 226 | } |
| 227 | |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 228 | /** |
| 229 | * Processes ARP request packets. |
| 230 | * It checks if the target IP is owned by a known host first and then ask to |
| 231 | * OpenStack if it's not. This ARP proxy does not support overlapping IP. |
| 232 | * |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 233 | * @param context packet context |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 234 | * @param ethPacket ethernet packet |
| 235 | */ |
| 236 | private void processPacketIn(PacketContext context, Ethernet ethPacket) { |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 237 | |
| 238 | // if the ARP mode is configured as broadcast mode, we simply ignore ARP packet_in |
| 239 | if (arpMode.equals(ARP_BROADCAST_MODE)) { |
| 240 | return; |
| 241 | } |
| 242 | |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 243 | ARP arpPacket = (ARP) ethPacket.getPayload(); |
| 244 | if (arpPacket.getOpCode() != ARP.OP_REQUEST) { |
| 245 | return; |
| 246 | } |
| 247 | |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 248 | InstancePort srcInstPort = instancePortService.instancePort(ethPacket.getSourceMAC()); |
| 249 | if (srcInstPort == null) { |
| 250 | log.trace("Failed to find source instance port(MAC:{})", |
| 251 | ethPacket.getSourceMAC()); |
| 252 | return; |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 253 | } |
| 254 | |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 255 | IpAddress targetIp = Ip4Address.valueOf(arpPacket.getTargetProtocolAddress()); |
| 256 | MacAddress replyMac = gateways.contains(targetIp) ? MacAddress.valueOf(gatewayMac) : |
| 257 | getMacFromHostOpenstack(targetIp, srcInstPort.networkId()); |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 258 | if (replyMac == MacAddress.NONE) { |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 259 | log.trace("Failed to find MAC address for {}", targetIp); |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 260 | return; |
| 261 | } |
| 262 | |
| 263 | Ethernet ethReply = ARP.buildArpReply( |
| 264 | targetIp.getIp4Address(), |
| 265 | replyMac, |
| 266 | ethPacket); |
| 267 | |
| 268 | TrafficTreatment treatment = DefaultTrafficTreatment.builder() |
| 269 | .setOutput(context.inPacket().receivedFrom().port()) |
| 270 | .build(); |
| 271 | |
| 272 | packetService.emit(new DefaultOutboundPacket( |
| 273 | context.inPacket().receivedFrom().deviceId(), |
| 274 | treatment, |
| 275 | ByteBuffer.wrap(ethReply.serialize()))); |
| 276 | } |
| 277 | |
| 278 | /** |
| 279 | * Returns MAC address of a host with a given target IP address by asking to |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 280 | * instance port service. |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 281 | * |
| 282 | * @param targetIp target ip |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 283 | * @param osNetId openstack network id of the source instance port |
| 284 | * @return mac address, or none mac address if it fails to find the mac |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 285 | */ |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 286 | private MacAddress getMacFromHostOpenstack(IpAddress targetIp, String osNetId) { |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 287 | checkNotNull(targetIp); |
| 288 | |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 289 | InstancePort instPort = instancePortService.instancePort(targetIp, osNetId); |
| 290 | if (instPort != null) { |
| 291 | log.trace("Found MAC from host service for {}", targetIp); |
| 292 | return instPort.macAddress(); |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 293 | } else { |
| 294 | return MacAddress.NONE; |
| 295 | } |
| 296 | } |
| 297 | |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 298 | /** |
Daniel Park | 613ac37 | 2018-06-28 14:30:11 +0900 | [diff] [blame] | 299 | * Installs flow rules which convert ARP request packet into ARP reply |
| 300 | * by adding a fake gateway MAC address as Source Hardware Address. |
| 301 | * |
| 302 | * @param osSubnet openstack subnet |
| 303 | * @param install flag which indicates whether to install rule or remove rule |
| 304 | */ |
| 305 | private void setFakeGatewayArpRule(Subnet osSubnet, boolean install, OpenstackNode osNode) { |
| 306 | |
| 307 | if (arpMode.equals(ARP_BROADCAST_MODE)) { |
| 308 | String gateway = osSubnet.getGateway(); |
| 309 | |
| 310 | TrafficSelector selector = DefaultTrafficSelector.builder() |
| 311 | .matchEthType(EthType.EtherType.ARP.ethType().toShort()) |
| 312 | .matchArpOp(ARP.OP_REQUEST) |
| 313 | .matchArpTpa(Ip4Address.valueOf(gateway)) |
| 314 | .build(); |
| 315 | |
| 316 | TrafficTreatment treatment = DefaultTrafficTreatment.builder() |
| 317 | .setArpOp(ARP.OP_REPLY) |
| 318 | .setArpSha(MacAddress.valueOf(gatewayMac)) |
| 319 | .setArpSpa(Ip4Address.valueOf(gateway)) |
| 320 | .setOutput(PortNumber.IN_PORT) |
| 321 | .build(); |
| 322 | |
| 323 | if (osNode == null) { |
| 324 | osNodeService.completeNodes(COMPUTE).forEach(n -> |
| 325 | osFlowRuleService.setRule( |
| 326 | appId, |
| 327 | n.intgBridge(), |
| 328 | selector, |
| 329 | treatment, |
| 330 | PRIORITY_ARP_GATEWAY_RULE, |
| 331 | DHCP_ARP_TABLE, |
| 332 | install |
| 333 | ) |
| 334 | ); |
| 335 | } else { |
| 336 | osFlowRuleService.setRule( |
| 337 | appId, |
| 338 | osNode.intgBridge(), |
| 339 | selector, |
| 340 | treatment, |
| 341 | PRIORITY_ARP_GATEWAY_RULE, |
| 342 | DHCP_ARP_TABLE, |
| 343 | install |
| 344 | ); |
| 345 | } |
| 346 | |
| 347 | } |
| 348 | } |
| 349 | |
| 350 | /** |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 351 | * An internal packet processor which processes ARP request, and results in |
| 352 | * packet-out ARP reply. |
| 353 | */ |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 354 | private class InternalPacketProcessor implements PacketProcessor { |
| 355 | |
| 356 | @Override |
| 357 | public void process(PacketContext context) { |
| 358 | if (context.isHandled()) { |
| 359 | return; |
| 360 | } |
| 361 | |
| 362 | Ethernet ethPacket = context.inPacket().parsed(); |
| 363 | if (ethPacket == null || ethPacket.getEtherType() != Ethernet.TYPE_ARP) { |
| 364 | return; |
| 365 | } |
| 366 | processPacketIn(context, ethPacket); |
| 367 | } |
| 368 | } |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 369 | |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 370 | /** |
| 371 | * An internal network listener which listens to openstack network event, |
| 372 | * manages the gateway collection and installs flow rule that handles |
| 373 | * ARP request in data plane. |
| 374 | */ |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 375 | private class InternalOpenstackNetworkListener implements OpenstackNetworkListener { |
| 376 | |
| 377 | @Override |
| 378 | public boolean isRelevant(OpenstackNetworkEvent event) { |
| 379 | Subnet osSubnet = event.subnet(); |
| 380 | if (osSubnet == null) { |
| 381 | return false; |
| 382 | } |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 383 | |
Jian Li | bb4f541 | 2018-04-12 09:48:50 +0900 | [diff] [blame] | 384 | Network network = osNetworkService.network(osSubnet.getNetworkId()); |
| 385 | |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 386 | if (network == null) { |
| 387 | log.warn("Network is not specified."); |
| 388 | return false; |
| 389 | } else { |
| 390 | if (network.getNetworkType().equals(NetworkType.FLAT)) { |
| 391 | return false; |
| 392 | } |
| 393 | } |
| 394 | |
| 395 | // do not allow to proceed without leadership |
| 396 | NodeId leader = leadershipService.getLeader(appId.name()); |
| 397 | if (!Objects.equals(localNodeId, leader)) { |
| 398 | return false; |
| 399 | } |
| 400 | |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 401 | return !Strings.isNullOrEmpty(osSubnet.getGateway()); |
| 402 | } |
| 403 | |
| 404 | @Override |
| 405 | public void event(OpenstackNetworkEvent event) { |
| 406 | switch (event.type()) { |
| 407 | case OPENSTACK_SUBNET_CREATED: |
| 408 | case OPENSTACK_SUBNET_UPDATED: |
| 409 | addSubnetGateway(event.subnet()); |
Daniel Park | 613ac37 | 2018-06-28 14:30:11 +0900 | [diff] [blame] | 410 | setFakeGatewayArpRule(event.subnet(), true, null); |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 411 | break; |
| 412 | case OPENSTACK_SUBNET_REMOVED: |
| 413 | removeSubnetGateway(event.subnet()); |
Daniel Park | 613ac37 | 2018-06-28 14:30:11 +0900 | [diff] [blame] | 414 | setFakeGatewayArpRule(event.subnet(), false, null); |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 415 | break; |
| 416 | case OPENSTACK_NETWORK_CREATED: |
| 417 | case OPENSTACK_NETWORK_UPDATED: |
| 418 | case OPENSTACK_NETWORK_REMOVED: |
| 419 | case OPENSTACK_PORT_CREATED: |
| 420 | case OPENSTACK_PORT_UPDATED: |
| 421 | case OPENSTACK_PORT_REMOVED: |
| 422 | default: |
| 423 | // do nothing for the other events |
| 424 | break; |
| 425 | } |
| 426 | } |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 427 | } |
| 428 | |
| 429 | /** |
| 430 | * An internal openstack node listener which is used for listening openstack |
| 431 | * node activity. As long as a node is in complete state, we will install |
| 432 | * default ARP rule to handle ARP request. |
| 433 | */ |
| 434 | private class InternalNodeEventListener implements OpenstackNodeListener { |
| 435 | |
| 436 | @Override |
| 437 | public boolean isRelevant(OpenstackNodeEvent event) { |
| 438 | // do not allow to proceed without leadership |
| 439 | NodeId leader = leadershipService.getLeader(appId.name()); |
Jian Li | 51b844c | 2018-05-31 10:59:03 +0900 | [diff] [blame] | 440 | return Objects.equals(localNodeId, leader) && event.subject().type() == COMPUTE; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 441 | } |
| 442 | |
| 443 | @Override |
| 444 | public void event(OpenstackNodeEvent event) { |
| 445 | OpenstackNode osNode = event.subject(); |
| 446 | switch (event.type()) { |
| 447 | case OPENSTACK_NODE_COMPLETE: |
Jian Li | 51b844c | 2018-05-31 10:59:03 +0900 | [diff] [blame] | 448 | setDefaultArpRule(osNode, true); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 449 | break; |
| 450 | case OPENSTACK_NODE_INCOMPLETE: |
Jian Li | 51b844c | 2018-05-31 10:59:03 +0900 | [diff] [blame] | 451 | setDefaultArpRule(osNode, false); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 452 | break; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 453 | default: |
| 454 | break; |
| 455 | } |
| 456 | } |
| 457 | |
Jian Li | f96685c | 2018-05-21 14:14:16 +0900 | [diff] [blame] | 458 | private void setDefaultArpRule(OpenstackNode osNode, boolean install) { |
| 459 | switch (arpMode) { |
| 460 | case ARP_PROXY_MODE: |
| 461 | setDefaultArpRuleForProxyMode(osNode, install); |
| 462 | break; |
| 463 | case ARP_BROADCAST_MODE: |
| 464 | setDefaultArpRuleForBroadcastMode(osNode, install); |
Jian Li | e2e03a5 | 2018-07-05 23:35:02 +0900 | [diff] [blame] | 465 | |
| 466 | // we do not add fake gateway ARP rules for FLAT network |
| 467 | // ARP packets generated by FLAT typed VM should not be |
| 468 | // delegated to switch to handle |
| 469 | osNetworkService.subnets().stream().filter(subnet -> |
| 470 | osNetworkService.network(subnet.getNetworkId()) != null && |
| 471 | osNetworkService.network(subnet.getNetworkId()) |
| 472 | .getNetworkType() == NetworkType.FLAT) |
| 473 | .forEach(subnet -> |
| 474 | setFakeGatewayArpRule(subnet, install, osNode)); |
Jian Li | f96685c | 2018-05-21 14:14:16 +0900 | [diff] [blame] | 475 | break; |
| 476 | default: |
| 477 | log.warn("Invalid ARP mode {}. Please use either " + |
| 478 | "broadcast or proxy mode.", arpMode); |
| 479 | break; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 480 | } |
| 481 | } |
Jian Li | f96685c | 2018-05-21 14:14:16 +0900 | [diff] [blame] | 482 | |
| 483 | private void setDefaultArpRuleForProxyMode(OpenstackNode osNode, boolean install) { |
| 484 | TrafficSelector selector = DefaultTrafficSelector.builder() |
| 485 | .matchEthType(EthType.EtherType.ARP.ethType().toShort()) |
| 486 | .build(); |
| 487 | |
| 488 | TrafficTreatment treatment = DefaultTrafficTreatment.builder() |
| 489 | .punt() |
| 490 | .build(); |
| 491 | |
| 492 | osFlowRuleService.setRule( |
| 493 | appId, |
| 494 | osNode.intgBridge(), |
| 495 | selector, |
| 496 | treatment, |
| 497 | PRIORITY_ARP_CONTROL_RULE, |
| 498 | DHCP_ARP_TABLE, |
| 499 | install |
| 500 | ); |
| 501 | } |
| 502 | |
| 503 | private void setDefaultArpRuleForBroadcastMode(OpenstackNode osNode, boolean install) { |
| 504 | TrafficSelector selector = DefaultTrafficSelector.builder() |
| 505 | .matchEthType(EthType.EtherType.ARP.ethType().toShort()) |
| 506 | .matchArpOp(ARP.OP_REQUEST) |
| 507 | .build(); |
| 508 | |
| 509 | TrafficTreatment treatment = DefaultTrafficTreatment.builder() |
| 510 | .setOutput(PortNumber.FLOOD) |
| 511 | .build(); |
| 512 | |
| 513 | osFlowRuleService.setRule( |
| 514 | appId, |
| 515 | osNode.intgBridge(), |
| 516 | selector, |
| 517 | treatment, |
| 518 | PRIORITY_ARP_SUBNET_RULE, |
| 519 | DHCP_ARP_TABLE, |
| 520 | install |
| 521 | ); |
| 522 | } |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 523 | } |
| 524 | |
| 525 | /** |
| 526 | * An internal instance port listener which listens the port events generated |
| 527 | * from VM. When ARP a host which located in a remote compute node, we specify |
| 528 | * both ARP OP mode as REQUEST and Target Protocol Address (TPA) with |
| 529 | * host IP address. When ARP a host which located in a local compute node, |
| 530 | * we specify only ARP OP mode as REQUEST. |
| 531 | */ |
| 532 | private class InternalInstancePortListener implements InstancePortListener { |
| 533 | |
| 534 | @Override |
| 535 | public boolean isRelevant(InstancePortEvent event) { |
| 536 | |
| 537 | if (arpMode.equals(ARP_PROXY_MODE)) { |
| 538 | return false; |
| 539 | } |
| 540 | |
| 541 | InstancePort instPort = event.subject(); |
| 542 | return mastershipService.isLocalMaster(instPort.deviceId()); |
| 543 | } |
| 544 | |
| 545 | @Override |
| 546 | public void event(InstancePortEvent event) { |
| 547 | switch (event.type()) { |
| 548 | case OPENSTACK_INSTANCE_PORT_UPDATED: |
| 549 | case OPENSTACK_INSTANCE_PORT_DETECTED: |
| 550 | setArpRequestRule(event.subject(), true); |
| 551 | setArpReplyRule(event.subject(), true); |
| 552 | break; |
| 553 | case OPENSTACK_INSTANCE_PORT_VANISHED: |
| 554 | setArpRequestRule(event.subject(), false); |
| 555 | setArpReplyRule(event.subject(), false); |
| 556 | break; |
Jian Li | 24ec59f | 2018-05-23 19:01:25 +0900 | [diff] [blame] | 557 | case OPENSTACK_INSTANCE_MIGRATION_ENDED: |
| 558 | setArpRequestRule(event.subject(), false); |
| 559 | break; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 560 | default: |
| 561 | break; |
| 562 | } |
| 563 | } |
| 564 | |
| 565 | /** |
| 566 | * Installs flow rules to match ARP request packets. |
| 567 | * |
| 568 | * @param port instance port |
| 569 | * @param install installation flag |
| 570 | */ |
| 571 | private void setArpRequestRule(InstancePort port, boolean install) { |
| 572 | NetworkType type = osNetworkService.network(port.networkId()).getNetworkType(); |
| 573 | |
| 574 | switch (type) { |
| 575 | case VXLAN: |
| 576 | setRemoteArpRequestRuleForVxlan(port, install); |
| 577 | break; |
| 578 | case VLAN: |
Jian Li | 5965788 | 2018-05-10 13:13:06 +0900 | [diff] [blame] | 579 | // since VLAN ARP packet can be broadcasted to all hosts that connected with L2 network, |
| 580 | // there is no need to add any flow rules to handle ARP request |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 581 | break; |
| 582 | default: |
| 583 | break; |
| 584 | } |
| 585 | } |
| 586 | |
| 587 | /** |
| 588 | * Installs flow rules to match ARP reply packets. |
| 589 | * |
| 590 | * @param port instance port |
| 591 | * @param install installation flag |
| 592 | */ |
| 593 | private void setArpReplyRule(InstancePort port, boolean install) { |
| 594 | NetworkType type = osNetworkService.network(port.networkId()).getNetworkType(); |
| 595 | |
| 596 | switch (type) { |
| 597 | case VXLAN: |
Jian Li | 5965788 | 2018-05-10 13:13:06 +0900 | [diff] [blame] | 598 | setArpReplyRuleForVxlan(port, install); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 599 | break; |
| 600 | case VLAN: |
Jian Li | 5965788 | 2018-05-10 13:13:06 +0900 | [diff] [blame] | 601 | setArpReplyRuleForVlan(port, install); |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 602 | break; |
| 603 | default: |
| 604 | break; |
| 605 | } |
| 606 | } |
| 607 | |
| 608 | /** |
| 609 | * Installs flow rules to match ARP request packets only for VxLAN. |
| 610 | * |
| 611 | * @param port instance port |
| 612 | * @param install installation flag |
| 613 | */ |
| 614 | private void setRemoteArpRequestRuleForVxlan(InstancePort port, boolean install) { |
| 615 | |
| 616 | OpenstackNode localNode = osNodeService.node(port.deviceId()); |
| 617 | |
| 618 | TrafficSelector selector = DefaultTrafficSelector.builder() |
| 619 | .matchEthType(EthType.EtherType.ARP.ethType().toShort()) |
| 620 | .matchArpOp(ARP.OP_REQUEST) |
| 621 | .matchArpTpa(port.ipAddress().getIp4Address()) |
| 622 | .build(); |
| 623 | |
| 624 | setRemoteArpTreatmentForVxlan(selector, port, localNode, install); |
| 625 | } |
| 626 | |
| 627 | /** |
| 628 | * Installs flow rules to match ARP reply packets only for VxLAN. |
| 629 | * |
| 630 | * @param port instance port |
| 631 | * @param install installation flag |
| 632 | */ |
Jian Li | 5965788 | 2018-05-10 13:13:06 +0900 | [diff] [blame] | 633 | private void setArpReplyRuleForVxlan(InstancePort port, boolean install) { |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 634 | |
| 635 | OpenstackNode localNode = osNodeService.node(port.deviceId()); |
| 636 | |
Jian Li | 5965788 | 2018-05-10 13:13:06 +0900 | [diff] [blame] | 637 | TrafficSelector selector = setArpReplyRuleForVnet(port, install); |
| 638 | setRemoteArpTreatmentForVxlan(selector, port, localNode, install); |
| 639 | } |
| 640 | |
| 641 | /** |
| 642 | * Installs flow rules to match ARP reply packets only for VLAN. |
| 643 | * |
| 644 | * @param port instance port |
| 645 | * @param install installation flag |
| 646 | */ |
| 647 | private void setArpReplyRuleForVlan(InstancePort port, boolean install) { |
| 648 | |
| 649 | TrafficSelector selector = setArpReplyRuleForVnet(port, install); |
| 650 | setRemoteArpTreatmentForVlan(selector, port, install); |
| 651 | } |
| 652 | |
| 653 | // a helper method |
| 654 | private TrafficSelector setArpReplyRuleForVnet(InstancePort port, boolean install) { |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 655 | TrafficSelector selector = DefaultTrafficSelector.builder() |
| 656 | .matchEthType(EthType.EtherType.ARP.ethType().toShort()) |
| 657 | .matchArpOp(ARP.OP_REPLY) |
| 658 | .matchArpTpa(port.ipAddress().getIp4Address()) |
| 659 | .matchArpTha(port.macAddress()) |
| 660 | .build(); |
| 661 | |
| 662 | TrafficTreatment treatment = DefaultTrafficTreatment.builder() |
| 663 | .setOutput(port.portNumber()) |
| 664 | .build(); |
| 665 | |
| 666 | osFlowRuleService.setRule( |
| 667 | appId, |
| 668 | port.deviceId(), |
| 669 | selector, |
| 670 | treatment, |
| 671 | PRIORITY_ARP_REPLY_RULE, |
| 672 | DHCP_ARP_TABLE, |
| 673 | install |
| 674 | ); |
| 675 | |
Jian Li | 5965788 | 2018-05-10 13:13:06 +0900 | [diff] [blame] | 676 | return selector; |
Jian Li | eae1236 | 2018-04-10 18:48:32 +0900 | [diff] [blame] | 677 | } |
| 678 | |
| 679 | // a helper method |
| 680 | private void setRemoteArpTreatmentForVxlan(TrafficSelector selector, |
| 681 | InstancePort port, |
| 682 | OpenstackNode localNode, |
| 683 | boolean install) { |
| 684 | for (OpenstackNode remoteNode : osNodeService.completeNodes(COMPUTE)) { |
| 685 | if (!remoteNode.intgBridge().equals(port.deviceId())) { |
| 686 | TrafficTreatment treatmentToRemote = DefaultTrafficTreatment.builder() |
| 687 | .extension(buildExtension( |
| 688 | deviceService, |
| 689 | remoteNode.intgBridge(), |
| 690 | localNode.dataIp().getIp4Address()), |
| 691 | remoteNode.intgBridge()) |
| 692 | .setOutput(remoteNode.tunnelPortNum()) |
| 693 | .build(); |
| 694 | |
| 695 | osFlowRuleService.setRule( |
| 696 | appId, |
| 697 | remoteNode.intgBridge(), |
| 698 | selector, |
| 699 | treatmentToRemote, |
| 700 | PRIORITY_ARP_REQUEST_RULE, |
| 701 | DHCP_ARP_TABLE, |
| 702 | install |
| 703 | ); |
| 704 | } |
| 705 | } |
| 706 | } |
Jian Li | 5965788 | 2018-05-10 13:13:06 +0900 | [diff] [blame] | 707 | |
| 708 | // a helper method |
| 709 | private void setRemoteArpTreatmentForVlan(TrafficSelector selector, |
| 710 | InstancePort port, |
| 711 | boolean install) { |
| 712 | for (OpenstackNode remoteNode : osNodeService.completeNodes(COMPUTE)) { |
| 713 | if (!remoteNode.intgBridge().equals(port.deviceId()) && remoteNode.vlanIntf() != null) { |
| 714 | TrafficTreatment treatmentToRemote = DefaultTrafficTreatment.builder() |
| 715 | .setOutput(remoteNode.vlanPortNum()) |
| 716 | .build(); |
| 717 | |
| 718 | osFlowRuleService.setRule( |
| 719 | appId, |
| 720 | remoteNode.intgBridge(), |
| 721 | selector, |
| 722 | treatmentToRemote, |
| 723 | PRIORITY_ARP_REQUEST_RULE, |
| 724 | DHCP_ARP_TABLE, |
| 725 | install); |
| 726 | } |
| 727 | } |
| 728 | } |
Hyunsun Moon | 44aac66 | 2017-02-18 02:07:01 +0900 | [diff] [blame] | 729 | } |
Hyunsun Moon | b974fca | 2016-06-30 21:20:39 -0700 | [diff] [blame] | 730 | } |