Thomas Vachuska | 4f1a60c | 2014-10-28 13:39:07 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2014 Open Networking Laboratory |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 16 | package org.onlab.onos.store.intent.impl; |
| 17 | |
Yuta HIGUCHI | c8f3026 | 2014-11-20 19:14:42 -0800 | [diff] [blame^] | 18 | import com.google.common.base.Verify; |
Thomas Vachuska | b97cf28 | 2014-10-20 23:31:12 -0700 | [diff] [blame] | 19 | import com.google.common.collect.ImmutableSet; |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 20 | |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 21 | import org.apache.felix.scr.annotations.Activate; |
| 22 | import org.apache.felix.scr.annotations.Component; |
| 23 | import org.apache.felix.scr.annotations.Deactivate; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 24 | import org.apache.felix.scr.annotations.Reference; |
| 25 | import org.apache.felix.scr.annotations.ReferenceCardinality; |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 26 | import org.apache.felix.scr.annotations.Service; |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 27 | import org.onlab.onos.net.intent.Intent; |
| 28 | import org.onlab.onos.net.intent.IntentEvent; |
| 29 | import org.onlab.onos.net.intent.IntentId; |
| 30 | import org.onlab.onos.net.intent.IntentState; |
| 31 | import org.onlab.onos.net.intent.IntentStore; |
| 32 | import org.onlab.onos.net.intent.IntentStoreDelegate; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 33 | import org.onlab.onos.store.AbstractStore; |
Yuta HIGUCHI | 2befc66 | 2014-10-30 15:57:49 -0700 | [diff] [blame] | 34 | import org.onlab.onos.store.serializers.KryoNamespaces; |
| 35 | import org.onlab.onos.store.serializers.KryoSerializer; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 36 | import org.onlab.onos.store.serializers.StoreSerializer; |
| 37 | import org.onlab.onos.store.service.DatabaseAdminService; |
| 38 | import org.onlab.onos.store.service.DatabaseService; |
| 39 | import org.onlab.onos.store.service.impl.CMap; |
Yuta HIGUCHI | 2befc66 | 2014-10-30 15:57:49 -0700 | [diff] [blame] | 40 | import org.onlab.util.KryoNamespace; |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 41 | import org.slf4j.Logger; |
| 42 | |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 43 | import java.util.EnumSet; |
Thomas Vachuska | b97cf28 | 2014-10-20 23:31:12 -0700 | [diff] [blame] | 44 | import java.util.List; |
| 45 | import java.util.Map; |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 46 | import java.util.Set; |
Thomas Vachuska | b97cf28 | 2014-10-20 23:31:12 -0700 | [diff] [blame] | 47 | import java.util.concurrent.ConcurrentHashMap; |
| 48 | |
| 49 | import static org.onlab.onos.net.intent.IntentState.*; |
| 50 | import static org.slf4j.LoggerFactory.getLogger; |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 51 | |
Yuta HIGUCHI | c8f3026 | 2014-11-20 19:14:42 -0800 | [diff] [blame^] | 52 | @Component(immediate = true, enabled = true) |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 53 | @Service |
| 54 | public class DistributedIntentStore |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 55 | extends AbstractStore<IntentEvent, IntentStoreDelegate> |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 56 | implements IntentStore { |
| 57 | |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 58 | /** Valid parking state, which can transition to INSTALLED. */ |
Yuta HIGUCHI | 89a7f47 | 2014-11-21 14:50:24 -0800 | [diff] [blame] | 59 | private static final Set<IntentState> PRE_INSTALLED = EnumSet.of(SUBMITTED, INSTALLED, FAILED); |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 60 | |
| 61 | /** Valid parking state, which can transition to WITHDRAWN. */ |
| 62 | private static final Set<IntentState> PRE_WITHDRAWN = EnumSet.of(INSTALLED, FAILED); |
| 63 | |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 64 | private final Logger log = getLogger(getClass()); |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 65 | |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 66 | // Assumption: IntentId will not have synonyms |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 67 | private CMap<IntentId, Intent> intents; |
| 68 | private CMap<IntentId, IntentState> states; |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 69 | |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 70 | // TODO left behind transient state issue: ONOS-103 |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 71 | // Map to store instance local intermediate state transition |
| 72 | private transient Map<IntentId, IntentState> transientStates = new ConcurrentHashMap<>(); |
| 73 | |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 74 | private CMap<IntentId, List<Intent>> installable; |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 75 | |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 76 | private StoreSerializer serializer; |
| 77 | |
| 78 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 79 | protected DatabaseAdminService dbAdminService; |
| 80 | |
| 81 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 82 | protected DatabaseService dbService; |
| 83 | |
Yuta HIGUCHI | c8f3026 | 2014-11-20 19:14:42 -0800 | [diff] [blame^] | 84 | // TODO make this configurable |
| 85 | private boolean onlyLogTransitionError = true; |
| 86 | |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 87 | @Activate |
| 88 | public void activate() { |
Yuta HIGUCHI | 71fa493 | 2014-10-28 22:27:49 -0700 | [diff] [blame] | 89 | // FIXME: We need a way to add serializer for intents which has been plugged-in. |
Yuta HIGUCHI | 2befc66 | 2014-10-30 15:57:49 -0700 | [diff] [blame] | 90 | // As a short term workaround, relax Kryo config to |
| 91 | // registrationRequired=false |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 92 | serializer = new KryoSerializer() { |
Yuta HIGUCHI | 2befc66 | 2014-10-30 15:57:49 -0700 | [diff] [blame] | 93 | |
| 94 | @Override |
| 95 | protected void setupKryoPool() { |
| 96 | serializerPool = KryoNamespace.newBuilder() |
| 97 | .setRegistrationRequired(false) |
| 98 | .register(KryoNamespaces.API) |
Yuta HIGUCHI | 91768e3 | 2014-11-22 05:06:35 -0800 | [diff] [blame] | 99 | .nextId(KryoNamespaces.BEGIN_USER_CUSTOM_ID) |
| 100 | .build(); |
Yuta HIGUCHI | 2befc66 | 2014-10-30 15:57:49 -0700 | [diff] [blame] | 101 | } |
Yuta HIGUCHI | 2befc66 | 2014-10-30 15:57:49 -0700 | [diff] [blame] | 102 | }; |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 103 | |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 104 | intents = new CMap<>(dbAdminService, dbService, "intents", serializer); |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 105 | |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 106 | states = new CMap<>(dbAdminService, dbService, "intent-states", serializer); |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 107 | |
| 108 | transientStates.clear(); |
| 109 | |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 110 | installable = new CMap<>(dbAdminService, dbService, "installable-intents", serializer); |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 111 | |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 112 | log.info("Started"); |
| 113 | } |
| 114 | |
| 115 | @Deactivate |
| 116 | public void deactivate() { |
| 117 | log.info("Stopped"); |
| 118 | } |
| 119 | |
| 120 | @Override |
| 121 | public IntentEvent createIntent(Intent intent) { |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 122 | boolean absent = intents.putIfAbsent(intent.id(), intent); |
| 123 | if (!absent) { |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 124 | // duplicate, ignore |
| 125 | return null; |
| 126 | } else { |
| 127 | return this.setState(intent, IntentState.SUBMITTED); |
| 128 | } |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 129 | } |
| 130 | |
| 131 | @Override |
| 132 | public IntentEvent removeIntent(IntentId intentId) { |
| 133 | Intent intent = intents.remove(intentId); |
| 134 | installable.remove(intentId); |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 135 | if (intent == null) { |
| 136 | // was already removed |
| 137 | return null; |
| 138 | } |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 139 | IntentEvent event = this.setState(intent, WITHDRAWN); |
| 140 | states.remove(intentId); |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 141 | transientStates.remove(intentId); |
| 142 | // TODO: Should we callremoveInstalledIntents if this Intent was |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 143 | return event; |
| 144 | } |
| 145 | |
| 146 | @Override |
| 147 | public long getIntentCount() { |
| 148 | return intents.size(); |
| 149 | } |
| 150 | |
| 151 | @Override |
| 152 | public Iterable<Intent> getIntents() { |
| 153 | return ImmutableSet.copyOf(intents.values()); |
| 154 | } |
| 155 | |
| 156 | @Override |
| 157 | public Intent getIntent(IntentId intentId) { |
| 158 | return intents.get(intentId); |
| 159 | } |
| 160 | |
| 161 | @Override |
| 162 | public IntentState getIntentState(IntentId id) { |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 163 | final IntentState localState = transientStates.get(id); |
| 164 | if (localState != null) { |
| 165 | return localState; |
| 166 | } |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 167 | return states.get(id); |
| 168 | } |
| 169 | |
Yuta HIGUCHI | c8f3026 | 2014-11-20 19:14:42 -0800 | [diff] [blame^] | 170 | private void verify(boolean expression, String errorMessageTemplate, Object... errorMessageArgs) { |
| 171 | if (onlyLogTransitionError) { |
| 172 | if (!expression) { |
| 173 | log.error(errorMessageTemplate.replace("%s", "{}"), errorMessageArgs); |
| 174 | } |
| 175 | } else { |
| 176 | Verify.verify(expression, errorMessageTemplate, errorMessageArgs); |
| 177 | } |
| 178 | } |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 179 | |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 180 | @Override |
| 181 | public IntentEvent setState(Intent intent, IntentState state) { |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 182 | final IntentId id = intent.id(); |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 183 | IntentEvent.Type evtType = null; |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 184 | final IntentState prevParking; |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 185 | boolean transitionedToParking = true; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 186 | boolean updated; |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 187 | |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 188 | // parking state transition |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 189 | switch (state) { |
| 190 | case SUBMITTED: |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 191 | prevParking = states.get(id); |
Yuta HIGUCHI | 89a7f47 | 2014-11-21 14:50:24 -0800 | [diff] [blame] | 192 | if (prevParking == null) { |
| 193 | updated = states.putIfAbsent(id, SUBMITTED); |
| 194 | verify(updated, "Conditional replace %s => %s failed", prevParking, SUBMITTED); |
| 195 | } else { |
| 196 | verify(prevParking == WITHDRAWN, |
| 197 | "Illegal state transition attempted from %s to SUBMITTED", |
| 198 | prevParking); |
| 199 | updated = states.replace(id, prevParking, SUBMITTED); |
| 200 | verify(updated, "Conditional replace %s => %s failed", prevParking, SUBMITTED); |
| 201 | } |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 202 | evtType = IntentEvent.Type.SUBMITTED; |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 203 | break; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 204 | |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 205 | case INSTALLED: |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 206 | prevParking = states.get(id); |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 207 | verify(PRE_INSTALLED.contains(prevParking), |
| 208 | "Illegal state transition attempted from %s to INSTALLED", |
| 209 | prevParking); |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 210 | updated = states.replace(id, prevParking, INSTALLED); |
| 211 | verify(updated, "Conditional replace %s => %s failed", prevParking, INSTALLED); |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 212 | evtType = IntentEvent.Type.INSTALLED; |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 213 | break; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 214 | |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 215 | case FAILED: |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 216 | prevParking = states.get(id); |
| 217 | updated = states.replace(id, prevParking, FAILED); |
| 218 | verify(updated, "Conditional replace %s => %s failed", prevParking, FAILED); |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 219 | evtType = IntentEvent.Type.FAILED; |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 220 | break; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 221 | |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 222 | case WITHDRAWN: |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 223 | prevParking = states.get(id); |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 224 | verify(PRE_WITHDRAWN.contains(prevParking), |
| 225 | "Illegal state transition attempted from %s to WITHDRAWN", |
| 226 | prevParking); |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 227 | updated = states.replace(id, prevParking, WITHDRAWN); |
| 228 | verify(updated, "Conditional replace %s => %s failed", prevParking, WITHDRAWN); |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 229 | evtType = IntentEvent.Type.WITHDRAWN; |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 230 | break; |
Yuta HIGUCHI | 4490a73 | 2014-11-18 20:20:30 -0800 | [diff] [blame] | 231 | |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 232 | default: |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 233 | transitionedToParking = false; |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 234 | prevParking = null; |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 235 | break; |
| 236 | } |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 237 | if (transitionedToParking) { |
Yuta HIGUCHI | 9a2e18a | 2014-11-18 16:41:58 -0800 | [diff] [blame] | 238 | log.debug("Parking State change: {} {}=>{}", id, prevParking, state); |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 239 | // remove instance local state |
| 240 | transientStates.remove(id); |
| 241 | } else { |
| 242 | // Update instance local state, which includes non-parking state transition |
| 243 | final IntentState prevTransient = transientStates.put(id, state); |
| 244 | log.debug("Transient State change: {} {}=>{}", id, prevTransient, state); |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 245 | } |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 246 | |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 247 | if (evtType == null) { |
Pavlin Radoslavov | c8ccbd9 | 2014-10-22 09:59:37 -0700 | [diff] [blame] | 248 | return null; |
| 249 | } |
Yuta HIGUCHI | 51b8f6a | 2014-11-22 03:05:51 -0800 | [diff] [blame] | 250 | return new IntentEvent(evtType, intent); |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 251 | } |
| 252 | |
| 253 | @Override |
Yuta HIGUCHI | 10a31c3 | 2014-10-28 14:42:06 -0700 | [diff] [blame] | 254 | public void setInstallableIntents(IntentId intentId, List<Intent> result) { |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 255 | installable.put(intentId, result); |
| 256 | } |
| 257 | |
| 258 | @Override |
Thomas Vachuska | b97cf28 | 2014-10-20 23:31:12 -0700 | [diff] [blame] | 259 | public List<Intent> getInstallableIntents(IntentId intentId) { |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 260 | return installable.get(intentId); |
| 261 | } |
| 262 | |
| 263 | @Override |
| 264 | public void removeInstalledIntents(IntentId intentId) { |
| 265 | installable.remove(intentId); |
| 266 | } |
Yuta HIGUCHI | 406a565 | 2014-10-20 22:18:16 -0700 | [diff] [blame] | 267 | } |