blob: a791a7cc7f168a60f3bc96c35ed86bea4779ffba [file] [log] [blame]
Madan Jampani84b6b402015-02-25 17:49:54 -08001/*
2 * Copyright 2015 Open Networking Laboratory
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16package org.onosproject.store.mastership.impl;
17
18import static org.onlab.util.Tools.groupedThreads;
Ayaka Koshibe941f8602015-04-15 14:17:08 -070019import static org.onlab.util.Tools.futureGetOrElse;
Madan Jampani0f6ad142015-05-13 17:10:04 -070020import static org.onosproject.mastership.MastershipEvent.Type.BACKUPS_CHANGED;
Madan Jampani84b6b402015-02-25 17:49:54 -080021import static org.onosproject.mastership.MastershipEvent.Type.MASTER_CHANGED;
22import static org.slf4j.LoggerFactory.getLogger;
23import static com.google.common.base.Preconditions.checkArgument;
24
Madan Jampani84b6b402015-02-25 17:49:54 -080025import java.util.List;
26import java.util.Map;
27import java.util.Set;
Madan Jampanif7536ab2015-05-07 23:23:23 -070028import java.util.concurrent.CompletableFuture;
Madan Jampani84b6b402015-02-25 17:49:54 -080029import java.util.concurrent.ExecutorService;
30import java.util.concurrent.Executors;
Madan Jampanif7536ab2015-05-07 23:23:23 -070031import java.util.concurrent.ScheduledExecutorService;
32import java.util.concurrent.TimeUnit;
Madan Jampani84b6b402015-02-25 17:49:54 -080033import java.util.regex.Matcher;
34import java.util.regex.Pattern;
35import java.util.stream.Collectors;
36
37import org.apache.felix.scr.annotations.Activate;
38import org.apache.felix.scr.annotations.Component;
39import org.apache.felix.scr.annotations.Deactivate;
40import org.apache.felix.scr.annotations.Reference;
41import org.apache.felix.scr.annotations.ReferenceCardinality;
42import org.apache.felix.scr.annotations.Service;
43import org.onlab.util.KryoNamespace;
44import org.onosproject.cluster.ClusterService;
45import org.onosproject.cluster.Leadership;
46import org.onosproject.cluster.LeadershipEvent;
47import org.onosproject.cluster.LeadershipEventListener;
48import org.onosproject.cluster.LeadershipService;
49import org.onosproject.cluster.NodeId;
50import org.onosproject.cluster.RoleInfo;
51import org.onosproject.mastership.MastershipEvent;
52import org.onosproject.mastership.MastershipStore;
53import org.onosproject.mastership.MastershipStoreDelegate;
54import org.onosproject.mastership.MastershipTerm;
55import org.onosproject.net.DeviceId;
56import org.onosproject.net.MastershipRole;
57import org.onosproject.store.AbstractStore;
58import org.onosproject.store.cluster.messaging.ClusterCommunicationService;
Madan Jampani84b6b402015-02-25 17:49:54 -080059import org.onosproject.store.cluster.messaging.MessageSubject;
60import org.onosproject.store.serializers.KryoNamespaces;
61import org.onosproject.store.serializers.KryoSerializer;
62import org.onosproject.store.serializers.StoreSerializer;
63import org.slf4j.Logger;
64
65import com.google.common.base.Objects;
66import com.google.common.collect.Lists;
67import com.google.common.collect.Maps;
68import com.google.common.collect.Sets;
69
70/**
71 * Implementation of the MastershipStore on top of Leadership Service.
72 */
Madan Jampani5756c352015-04-29 00:23:58 -070073@Component(immediate = true, enabled = true)
Madan Jampani84b6b402015-02-25 17:49:54 -080074@Service
75public class ConsistentDeviceMastershipStore
76 extends AbstractStore<MastershipEvent, MastershipStoreDelegate>
77 implements MastershipStore {
78
79 private final Logger log = getLogger(getClass());
80
81 @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY)
82 protected LeadershipService leadershipService;
83
84 @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY)
85 protected ClusterService clusterService;
86
87 @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY)
88 protected ClusterCommunicationService clusterCommunicator;
89
90 private NodeId localNodeId;
91 private final Set<DeviceId> connectedDevices = Sets.newHashSet();
92
Madan Jampani84b6b402015-02-25 17:49:54 -080093 private static final MessageSubject ROLE_RELINQUISH_SUBJECT =
94 new MessageSubject("mastership-store-device-role-relinquish");
Madan Jampani9bd1f152015-04-30 23:33:35 -070095 private static final MessageSubject TRANSITION_FROM_MASTER_TO_STANDBY_SUBJECT =
Madan Jampani1af8e132015-04-30 16:41:18 -070096 new MessageSubject("mastership-store-device-mastership-relinquish");
Madan Jampani84b6b402015-02-25 17:49:54 -080097
98 private static final Pattern DEVICE_MASTERSHIP_TOPIC_PATTERN =
Madan Jampani5756c352015-04-29 00:23:58 -070099 Pattern.compile("device:(.*)");
Madan Jampani84b6b402015-02-25 17:49:54 -0800100
Madan Jampani84b6b402015-02-25 17:49:54 -0800101 private ExecutorService messageHandlingExecutor;
Madan Jampanif7536ab2015-05-07 23:23:23 -0700102 private ScheduledExecutorService transferExecutor;
Madan Jampani84b6b402015-02-25 17:49:54 -0800103 private final LeadershipEventListener leadershipEventListener =
104 new InternalDeviceMastershipEventListener();
105
106 private static final String NODE_ID_NULL = "Node ID cannot be null";
Madan Jampanif7536ab2015-05-07 23:23:23 -0700107 private static final String DEVICE_ID_NULL = "Device ID cannot be null";
108 private static final int WAIT_BEFORE_MASTERSHIP_HANDOFF_MILLIS = 3000;
Madan Jampani84b6b402015-02-25 17:49:54 -0800109
110 public static final StoreSerializer SERIALIZER = new KryoSerializer() {
111 @Override
112 protected void setupKryoPool() {
113 serializerPool = KryoNamespace.newBuilder()
114 .register(KryoNamespaces.API)
115 .register(MastershipRole.class)
116 .register(MastershipEvent.class)
Madan Jampani1af8e132015-04-30 16:41:18 -0700117 .register(MastershipEvent.Type.class)
Madan Jampani84b6b402015-02-25 17:49:54 -0800118 .build();
119 }
120 };
121
122 @Activate
123 public void activate() {
124 messageHandlingExecutor =
Madan Jampanif7536ab2015-05-07 23:23:23 -0700125 Executors.newSingleThreadExecutor(
126 groupedThreads("onos/store/device/mastership", "message-handler"));
127 transferExecutor =
128 Executors.newSingleThreadScheduledExecutor(
129 groupedThreads("onos/store/device/mastership", "mastership-transfer-executor"));
Madan Jampanibbed40422015-05-20 12:00:38 -0700130 clusterCommunicator.addSubscriber(ROLE_RELINQUISH_SUBJECT,
Madan Jampanid46e18f2015-05-04 23:19:33 -0700131 SERIALIZER::decode,
Madan Jampanif7536ab2015-05-07 23:23:23 -0700132 this::relinquishLocalRole,
Madan Jampanid46e18f2015-05-04 23:19:33 -0700133 SERIALIZER::encode,
134 messageHandlingExecutor);
Madan Jampani9bd1f152015-04-30 23:33:35 -0700135 clusterCommunicator.addSubscriber(TRANSITION_FROM_MASTER_TO_STANDBY_SUBJECT,
Madan Jampani1af8e132015-04-30 16:41:18 -0700136 SERIALIZER::decode,
Madan Jampani9bd1f152015-04-30 23:33:35 -0700137 this::transitionFromMasterToStandby,
Madan Jampani1af8e132015-04-30 16:41:18 -0700138 SERIALIZER::encode,
139 messageHandlingExecutor);
Madan Jampani84b6b402015-02-25 17:49:54 -0800140 localNodeId = clusterService.getLocalNode().id();
141 leadershipService.addListener(leadershipEventListener);
142
Madan Jampaniafeebbd2015-05-19 15:26:01 -0700143 log.info("Started");
Madan Jampani84b6b402015-02-25 17:49:54 -0800144 }
145
146 @Deactivate
147 public void deactivate() {
Madan Jampani84b6b402015-02-25 17:49:54 -0800148 clusterCommunicator.removeSubscriber(ROLE_RELINQUISH_SUBJECT);
Madan Jampani9bd1f152015-04-30 23:33:35 -0700149 clusterCommunicator.removeSubscriber(TRANSITION_FROM_MASTER_TO_STANDBY_SUBJECT);
Madan Jampani84b6b402015-02-25 17:49:54 -0800150 messageHandlingExecutor.shutdown();
Madan Jampanif7536ab2015-05-07 23:23:23 -0700151 transferExecutor.shutdown();
Madan Jampani84b6b402015-02-25 17:49:54 -0800152 leadershipService.removeListener(leadershipEventListener);
153
Madan Jampaniafeebbd2015-05-19 15:26:01 -0700154 log.info("Stopped");
Madan Jampani84b6b402015-02-25 17:49:54 -0800155 }
156
157 @Override
Madan Jampanide003d92015-05-11 17:14:20 -0700158 public CompletableFuture<MastershipRole> requestRole(DeviceId deviceId) {
Madan Jampani84b6b402015-02-25 17:49:54 -0800159 checkArgument(deviceId != null, DEVICE_ID_NULL);
160
161 String leadershipTopic = createDeviceMastershipTopic(deviceId);
162 if (connectedDevices.add(deviceId)) {
Madan Jampanide003d92015-05-11 17:14:20 -0700163 return leadershipService.runForLeadership(leadershipTopic)
164 .thenApply(leadership -> {
165 return Objects.equal(localNodeId, leadership.leader())
166 ? MastershipRole.MASTER : MastershipRole.STANDBY;
167 });
Madan Jampani84b6b402015-02-25 17:49:54 -0800168 } else {
169 Leadership leadership = leadershipService.getLeadership(leadershipTopic);
170 if (leadership != null && leadership.leader().equals(localNodeId)) {
Madan Jampanide003d92015-05-11 17:14:20 -0700171 return CompletableFuture.completedFuture(MastershipRole.MASTER);
Madan Jampani84b6b402015-02-25 17:49:54 -0800172 } else {
Madan Jampanide003d92015-05-11 17:14:20 -0700173 return CompletableFuture.completedFuture(MastershipRole.STANDBY);
Madan Jampani84b6b402015-02-25 17:49:54 -0800174 }
175 }
176 }
177
178 @Override
179 public MastershipRole getRole(NodeId nodeId, DeviceId deviceId) {
180 checkArgument(nodeId != null, NODE_ID_NULL);
181 checkArgument(deviceId != null, DEVICE_ID_NULL);
182
183 String leadershipTopic = createDeviceMastershipTopic(deviceId);
184 Leadership leadership = leadershipService.getLeadership(leadershipTopic);
185 if (leadership != null && nodeId.equals(leadership.leader())) {
186 return MastershipRole.MASTER;
187 }
Madan Jampani1b02f822015-05-19 11:01:49 -0700188 return leadershipService.getCandidates(leadershipTopic).contains(nodeId) ?
189 MastershipRole.STANDBY : MastershipRole.NONE;
Madan Jampani84b6b402015-02-25 17:49:54 -0800190 }
191
192 @Override
193 public NodeId getMaster(DeviceId deviceId) {
194 checkArgument(deviceId != null, DEVICE_ID_NULL);
195
196 String leadershipTopic = createDeviceMastershipTopic(deviceId);
197 Leadership leadership = leadershipService.getLeadership(leadershipTopic);
198 return leadership != null ? leadership.leader() : null;
199 }
200
201 @Override
202 public RoleInfo getNodes(DeviceId deviceId) {
203 checkArgument(deviceId != null, DEVICE_ID_NULL);
204
205 Map<NodeId, MastershipRole> roles = Maps.newHashMap();
206 clusterService
207 .getNodes()
Madan Jampani84b6b402015-02-25 17:49:54 -0800208 .forEach((node) -> roles.put(node.id(), getRole(node.id(), deviceId)));
209
210 NodeId master = null;
211 final List<NodeId> standbys = Lists.newLinkedList();
212
Madan Jampani86940d92015-05-06 11:47:57 -0700213 List<NodeId> candidates = leadershipService.getCandidates(createDeviceMastershipTopic(deviceId));
214
Madan Jampani84b6b402015-02-25 17:49:54 -0800215 for (Map.Entry<NodeId, MastershipRole> entry : roles.entrySet()) {
216 if (entry.getValue() == MastershipRole.MASTER) {
217 master = entry.getKey();
218 } else if (entry.getValue() == MastershipRole.STANDBY) {
219 standbys.add(entry.getKey());
220 }
221 }
222
Madan Jampani86940d92015-05-06 11:47:57 -0700223 List<NodeId> sortedStandbyList = candidates.stream().filter(standbys::contains).collect(Collectors.toList());
224
225 return new RoleInfo(master, sortedStandbyList);
Madan Jampani84b6b402015-02-25 17:49:54 -0800226 }
227
228 @Override
229 public Set<DeviceId> getDevices(NodeId nodeId) {
230 checkArgument(nodeId != null, NODE_ID_NULL);
231
232 return leadershipService
233 .ownedTopics(nodeId)
234 .stream()
235 .filter(this::isDeviceMastershipTopic)
236 .map(this::extractDeviceIdFromTopic)
237 .collect(Collectors.toSet());
238 }
239
240 @Override
Madan Jampanif7536ab2015-05-07 23:23:23 -0700241 public CompletableFuture<MastershipEvent> setMaster(NodeId nodeId, DeviceId deviceId) {
Madan Jampani84b6b402015-02-25 17:49:54 -0800242 checkArgument(nodeId != null, NODE_ID_NULL);
243 checkArgument(deviceId != null, DEVICE_ID_NULL);
244
Madan Jampani1af8e132015-04-30 16:41:18 -0700245 NodeId currentMaster = getMaster(deviceId);
246 if (nodeId.equals(currentMaster)) {
Madan Jampanif7536ab2015-05-07 23:23:23 -0700247 return CompletableFuture.completedFuture(null);
Madan Jampani1af8e132015-04-30 16:41:18 -0700248 } else {
249 String leadershipTopic = createDeviceMastershipTopic(deviceId);
250 List<NodeId> candidates = leadershipService.getCandidates(leadershipTopic);
251 if (candidates.isEmpty()) {
Madan Jampanif7536ab2015-05-07 23:23:23 -0700252 return CompletableFuture.completedFuture(null);
Madan Jampani1af8e132015-04-30 16:41:18 -0700253 }
254 if (leadershipService.makeTopCandidate(leadershipTopic, nodeId)) {
Madan Jampanif7536ab2015-05-07 23:23:23 -0700255 CompletableFuture<MastershipEvent> result = new CompletableFuture<>();
256 // There is brief wait before we step down from mastership.
257 // This is to ensure any work that happens when standby preference
258 // order changes can complete. For example: flow entries need to be backed
259 // to the new top standby (ONOS-1883)
260 // FIXME: This potentially introduces a race-condition.
261 // Right now role changes are only forced via CLI.
262 transferExecutor.schedule(() -> {
263 result.complete(transitionFromMasterToStandby(deviceId));
264 }, WAIT_BEFORE_MASTERSHIP_HANDOFF_MILLIS, TimeUnit.MILLISECONDS);
265 return result;
Madan Jampani1af8e132015-04-30 16:41:18 -0700266 } else {
267 log.warn("Failed to promote {} to mastership for {}", nodeId, deviceId);
268 }
269 }
Madan Jampanif7536ab2015-05-07 23:23:23 -0700270 return CompletableFuture.completedFuture(null);
Madan Jampani84b6b402015-02-25 17:49:54 -0800271 }
272
273 @Override
274 public MastershipTerm getTermFor(DeviceId deviceId) {
275 checkArgument(deviceId != null, DEVICE_ID_NULL);
276
277 String leadershipTopic = createDeviceMastershipTopic(deviceId);
278 Leadership leadership = leadershipService.getLeadership(leadershipTopic);
279 return leadership != null ? MastershipTerm.of(leadership.leader(), leadership.epoch()) : null;
280 }
281
282 @Override
Madan Jampanif7536ab2015-05-07 23:23:23 -0700283 public CompletableFuture<MastershipEvent> setStandby(NodeId nodeId, DeviceId deviceId) {
Madan Jampani84b6b402015-02-25 17:49:54 -0800284 checkArgument(nodeId != null, NODE_ID_NULL);
285 checkArgument(deviceId != null, DEVICE_ID_NULL);
286
Madan Jampani1af8e132015-04-30 16:41:18 -0700287 NodeId currentMaster = getMaster(deviceId);
288 if (!nodeId.equals(currentMaster)) {
Madan Jampanif7536ab2015-05-07 23:23:23 -0700289 return CompletableFuture.completedFuture(null);
Madan Jampani1af8e132015-04-30 16:41:18 -0700290 }
Madan Jampanid46e18f2015-05-04 23:19:33 -0700291
292 String leadershipTopic = createDeviceMastershipTopic(deviceId);
293 List<NodeId> candidates = leadershipService.getCandidates(leadershipTopic);
294
295 NodeId newMaster = candidates.stream()
296 .filter(candidate -> !Objects.equal(nodeId, candidate))
297 .findFirst()
298 .orElse(null);
299 log.info("Transitioning to role {} for {}. Next master: {}",
300 newMaster != null ? MastershipRole.STANDBY : MastershipRole.NONE, deviceId, newMaster);
301
302 if (newMaster != null) {
303 return setMaster(newMaster, deviceId);
304 }
305 return relinquishRole(nodeId, deviceId);
Madan Jampani84b6b402015-02-25 17:49:54 -0800306 }
307
308 @Override
Madan Jampanif7536ab2015-05-07 23:23:23 -0700309 public CompletableFuture<MastershipEvent> relinquishRole(NodeId nodeId, DeviceId deviceId) {
Madan Jampani84b6b402015-02-25 17:49:54 -0800310 checkArgument(nodeId != null, NODE_ID_NULL);
311 checkArgument(deviceId != null, DEVICE_ID_NULL);
312
Madan Jampanibbed40422015-05-20 12:00:38 -0700313 if (nodeId.equals(localNodeId)) {
314 return relinquishLocalRole(deviceId);
Madan Jampani84b6b402015-02-25 17:49:54 -0800315 }
Madan Jampanibbed40422015-05-20 12:00:38 -0700316
317 log.debug("Forwarding request to relinquish "
318 + "role for device {} to {}", deviceId, nodeId);
319 return clusterCommunicator.sendAndReceive(
320 deviceId,
321 ROLE_RELINQUISH_SUBJECT,
322 SERIALIZER::encode,
323 SERIALIZER::decode,
324 nodeId);
Madan Jampanif7536ab2015-05-07 23:23:23 -0700325 }
326
Madan Jampanibbed40422015-05-20 12:00:38 -0700327 private CompletableFuture<MastershipEvent> relinquishLocalRole(DeviceId deviceId) {
Madan Jampanif7536ab2015-05-07 23:23:23 -0700328 checkArgument(deviceId != null, DEVICE_ID_NULL);
Madan Jampani84b6b402015-02-25 17:49:54 -0800329
330 // Check if this node is can be managed by this node.
331 if (!connectedDevices.contains(deviceId)) {
Madan Jampanibbed40422015-05-20 12:00:38 -0700332 return CompletableFuture.completedFuture(null);
Madan Jampani84b6b402015-02-25 17:49:54 -0800333 }
334
335 String leadershipTopic = createDeviceMastershipTopic(deviceId);
Madan Jampani9bd1f152015-04-30 23:33:35 -0700336 NodeId currentLeader = leadershipService.getLeader(leadershipTopic);
Madan Jampani84b6b402015-02-25 17:49:54 -0800337
Madan Jampani9bd1f152015-04-30 23:33:35 -0700338 MastershipEvent.Type eventType = Objects.equal(currentLeader, localNodeId)
339 ? MastershipEvent.Type.MASTER_CHANGED
340 : MastershipEvent.Type.BACKUPS_CHANGED;
Madan Jampani84b6b402015-02-25 17:49:54 -0800341
342 connectedDevices.remove(deviceId);
Madan Jampanibbed40422015-05-20 12:00:38 -0700343 return leadershipService.withdraw(leadershipTopic)
344 .thenApply(v -> new MastershipEvent(eventType, deviceId, getNodes(deviceId)));
Madan Jampani84b6b402015-02-25 17:49:54 -0800345 }
346
Madan Jampani9bd1f152015-04-30 23:33:35 -0700347 private MastershipEvent transitionFromMasterToStandby(DeviceId deviceId) {
Madan Jampani1af8e132015-04-30 16:41:18 -0700348 checkArgument(deviceId != null, DEVICE_ID_NULL);
349
350 NodeId currentMaster = getMaster(deviceId);
351 if (currentMaster == null) {
352 return null;
353 }
354
355 if (!currentMaster.equals(localNodeId)) {
356 log.info("Forwarding request to relinquish "
357 + "mastership for device {} to {}", deviceId, currentMaster);
358 return futureGetOrElse(clusterCommunicator.sendAndReceive(
359 deviceId,
Madan Jampani9bd1f152015-04-30 23:33:35 -0700360 TRANSITION_FROM_MASTER_TO_STANDBY_SUBJECT,
Madan Jampani1af8e132015-04-30 16:41:18 -0700361 SERIALIZER::encode,
362 SERIALIZER::decode,
363 currentMaster), null);
364 }
365
Madan Jampani9bd1f152015-04-30 23:33:35 -0700366 return leadershipService.stepdown(createDeviceMastershipTopic(deviceId))
367 ? new MastershipEvent(MastershipEvent.Type.MASTER_CHANGED, deviceId, getNodes(deviceId)) : null;
Madan Jampani1af8e132015-04-30 16:41:18 -0700368 }
369
Madan Jampani84b6b402015-02-25 17:49:54 -0800370 @Override
371 public void relinquishAllRole(NodeId nodeId) {
372 // Noop. LeadershipService already takes care of detecting and purging deadlocks.
373 }
374
Madan Jampani84b6b402015-02-25 17:49:54 -0800375 private class InternalDeviceMastershipEventListener implements LeadershipEventListener {
376 @Override
377 public void event(LeadershipEvent event) {
378 Leadership leadership = event.subject();
379 if (!isDeviceMastershipTopic(leadership.topic())) {
380 return;
381 }
Madan Jampani84b6b402015-02-25 17:49:54 -0800382 DeviceId deviceId = extractDeviceIdFromTopic(leadership.topic());
Thomas Vachuska4b839c72015-05-18 15:43:03 -0700383 switch (event.type()) {
384 case LEADER_ELECTED:
385 notifyDelegate(new MastershipEvent(MASTER_CHANGED, deviceId, getNodes(deviceId)));
386 break;
387 case LEADER_REELECTED:
388 // There is no concept of leader re-election in the new distributed leadership manager.
389 throw new IllegalStateException("Unexpected event type");
390 case LEADER_BOOTED:
391 notifyDelegate(new MastershipEvent(MASTER_CHANGED, deviceId, getNodes(deviceId)));
392 break;
393 case CANDIDATES_CHANGED:
394 notifyDelegate(new MastershipEvent(BACKUPS_CHANGED, deviceId, getNodes(deviceId)));
395 break;
396 default:
397 return;
Madan Jampani84b6b402015-02-25 17:49:54 -0800398 }
399 }
400 }
401
402 private String createDeviceMastershipTopic(DeviceId deviceId) {
Madan Jampani5756c352015-04-29 00:23:58 -0700403 return String.format("device:%s", deviceId.toString());
Madan Jampani84b6b402015-02-25 17:49:54 -0800404 }
405
406 private DeviceId extractDeviceIdFromTopic(String topic) {
407 Matcher m = DEVICE_MASTERSHIP_TOPIC_PATTERN.matcher(topic);
408 if (m.matches()) {
409 return DeviceId.deviceId(m.group(1));
410 } else {
411 throw new IllegalArgumentException("Invalid device mastership topic: " + topic);
412 }
413 }
414
415 private boolean isDeviceMastershipTopic(String topic) {
416 Matcher m = DEVICE_MASTERSHIP_TOPIC_PATTERN.matcher(topic);
417 return m.matches();
418 }
419
Madan Jampanic26eede2015-04-16 11:42:16 -0700420}