gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2016-present Open Networking Laboratory |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | package org.onosproject.dhcprelay; |
| 17 | |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 18 | import java.nio.ByteBuffer; |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 19 | import java.util.Dictionary; |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 20 | import java.util.Objects; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 21 | import java.util.Set; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 22 | import org.apache.felix.scr.annotations.Activate; |
| 23 | import org.apache.felix.scr.annotations.Component; |
| 24 | import org.apache.felix.scr.annotations.Deactivate; |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 25 | import org.apache.felix.scr.annotations.Modified; |
| 26 | import org.apache.felix.scr.annotations.Property; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 27 | import org.apache.felix.scr.annotations.Reference; |
| 28 | import org.apache.felix.scr.annotations.ReferenceCardinality; |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 29 | import org.onlab.packet.ARP; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 30 | import org.onlab.packet.DHCP; |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 31 | import org.onlab.packet.DHCPOption; |
| 32 | import org.onlab.packet.DHCPPacketType; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 33 | import org.onlab.packet.Ethernet; |
| 34 | import org.onlab.packet.IPv4; |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 35 | import org.onlab.packet.Ip4Address; |
| 36 | import org.onlab.packet.MacAddress; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 37 | import org.onlab.packet.TpPort; |
| 38 | import org.onlab.packet.UDP; |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 39 | import org.onlab.packet.VlanId; |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 40 | import org.onlab.util.Tools; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 41 | import org.onosproject.core.ApplicationId; |
| 42 | import org.onosproject.core.CoreService; |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 43 | import org.onosproject.incubator.net.intf.Interface; |
| 44 | import org.onosproject.incubator.net.intf.InterfaceService; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 45 | import org.onosproject.net.ConnectPoint; |
| 46 | import org.onosproject.net.Host; |
| 47 | import org.onosproject.net.HostId; |
| 48 | import org.onosproject.net.config.ConfigFactory; |
| 49 | import org.onosproject.net.config.NetworkConfigEvent; |
| 50 | import org.onosproject.net.config.NetworkConfigListener; |
| 51 | import org.onosproject.net.config.NetworkConfigRegistry; |
| 52 | import org.onosproject.net.flow.DefaultTrafficSelector; |
| 53 | import org.onosproject.net.flow.DefaultTrafficTreatment; |
| 54 | import org.onosproject.net.flow.TrafficSelector; |
| 55 | import org.onosproject.net.flow.TrafficTreatment; |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 56 | import org.onosproject.net.host.HostEvent; |
| 57 | import org.onosproject.net.host.HostListener; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 58 | import org.onosproject.net.host.HostService; |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 59 | import org.onosproject.net.host.InterfaceIpAddress; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 60 | import org.onosproject.net.packet.DefaultOutboundPacket; |
| 61 | import org.onosproject.net.packet.OutboundPacket; |
| 62 | import org.onosproject.net.packet.PacketContext; |
| 63 | import org.onosproject.net.packet.PacketPriority; |
| 64 | import org.onosproject.net.packet.PacketProcessor; |
| 65 | import org.onosproject.net.packet.PacketService; |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 66 | import org.osgi.service.component.ComponentContext; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 67 | import org.slf4j.Logger; |
| 68 | import org.slf4j.LoggerFactory; |
| 69 | |
| 70 | import com.google.common.collect.ImmutableSet; |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 71 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 72 | import static org.onosproject.net.config.basics.SubjectFactories.APP_SUBJECT_FACTORY; |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 73 | import static org.onlab.packet.DHCP.DHCPOptionCode.OptionCode_MessageType; |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 74 | import static org.onlab.packet.MacAddress.valueOf; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 75 | /** |
| 76 | * DHCP Relay Agent Application Component. |
| 77 | */ |
| 78 | @Component(immediate = true) |
| 79 | public class DhcpRelay { |
| 80 | |
| 81 | public static final String DHCP_RELAY_APP = "org.onosproject.dhcp-relay"; |
| 82 | private final Logger log = LoggerFactory.getLogger(getClass()); |
| 83 | private final InternalConfigListener cfgListener = new InternalConfigListener(); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 84 | private static MacAddress myMAC = valueOf("4f:4f:4f:4f:4f:4f"); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 85 | |
| 86 | private final Set<ConfigFactory> factories = ImmutableSet.of( |
| 87 | new ConfigFactory<ApplicationId, DhcpRelayConfig>(APP_SUBJECT_FACTORY, |
| 88 | DhcpRelayConfig.class, |
| 89 | "dhcprelay") { |
| 90 | @Override |
| 91 | public DhcpRelayConfig createConfig() { |
| 92 | return new DhcpRelayConfig(); |
| 93 | } |
| 94 | } |
| 95 | ); |
| 96 | |
| 97 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 98 | protected NetworkConfigRegistry cfgService; |
| 99 | |
| 100 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 101 | protected CoreService coreService; |
| 102 | |
| 103 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 104 | protected PacketService packetService; |
| 105 | |
| 106 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 107 | protected HostService hostService; |
| 108 | |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 109 | @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY) |
| 110 | protected InterfaceService interfaceService; |
| 111 | |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 112 | @Property(name = "arpEnabled", boolValue = true, |
| 113 | label = "Enable Address resolution protocol") |
| 114 | protected boolean arpEnabled = true; |
| 115 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 116 | private DhcpRelayPacketProcessor dhcpRelayPacketProcessor = new DhcpRelayPacketProcessor(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 117 | private InternalHostListener hostListener = new InternalHostListener(); |
| 118 | |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 119 | private Ip4Address dhcpServerIp = null; |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 120 | // dhcp server may be connected directly to the SDN network or |
| 121 | // via an external gateway. When connected directly, the dhcpConnectPoint, dhcpConnectMac, |
| 122 | // and dhcpConnectVlan refer to the server. When connected via the gateway, they refer |
| 123 | // to the gateway. |
| 124 | private ConnectPoint dhcpServerConnectPoint = null; |
| 125 | private MacAddress dhcpConnectMac = null; |
| 126 | private VlanId dhcpConnectVlan = null; |
| 127 | private Ip4Address dhcpGatewayIp = null; |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 128 | private ApplicationId appId; |
| 129 | |
| 130 | @Activate |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 131 | protected void activate(ComponentContext context) { |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 132 | //start the dhcp relay agent |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 133 | appId = coreService.registerApplication(DHCP_RELAY_APP); |
| 134 | |
| 135 | cfgService.addListener(cfgListener); |
| 136 | factories.forEach(cfgService::registerConfigFactory); |
| 137 | //update the dhcp server configuration. |
| 138 | updateConfig(); |
| 139 | //add the packet services. |
| 140 | packetService.addProcessor(dhcpRelayPacketProcessor, PacketProcessor.director(0)); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 141 | hostService.addListener(hostListener); |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 142 | requestDhcpPackets(); |
| 143 | modified(context); |
| 144 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 145 | log.info("DHCP-RELAY Started"); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 146 | } |
| 147 | |
| 148 | @Deactivate |
| 149 | protected void deactivate() { |
| 150 | cfgService.removeListener(cfgListener); |
| 151 | factories.forEach(cfgService::unregisterConfigFactory); |
| 152 | packetService.removeProcessor(dhcpRelayPacketProcessor); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 153 | hostService.removeListener(hostListener); |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 154 | cancelDhcpPackets(); |
| 155 | cancelArpPackets(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 156 | if (dhcpGatewayIp != null) { |
| 157 | hostService.stopMonitoringIp(dhcpGatewayIp); |
| 158 | } else { |
| 159 | hostService.stopMonitoringIp(dhcpServerIp); |
| 160 | } |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 161 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 162 | log.info("DHCP-RELAY Stopped"); |
| 163 | } |
| 164 | |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 165 | @Modified |
| 166 | protected void modified(ComponentContext context) { |
| 167 | Dictionary<?, ?> properties = context.getProperties(); |
| 168 | Boolean flag; |
| 169 | |
| 170 | flag = Tools.isPropertyEnabled(properties, "arpEnabled"); |
| 171 | if (flag != null) { |
| 172 | arpEnabled = flag; |
| 173 | log.info("Address resolution protocol is {}", |
| 174 | arpEnabled ? "enabled" : "disabled"); |
| 175 | } |
| 176 | |
| 177 | if (arpEnabled) { |
| 178 | requestArpPackets(); |
| 179 | } else { |
| 180 | cancelArpPackets(); |
| 181 | } |
| 182 | } |
| 183 | |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 184 | /** |
| 185 | * Checks if this app has been configured. |
| 186 | * |
| 187 | * @return true if all information we need have been initialized |
| 188 | */ |
| 189 | private boolean configured() { |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 190 | return dhcpServerConnectPoint != null && dhcpServerIp != null; |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 191 | } |
| 192 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 193 | private void updateConfig() { |
| 194 | DhcpRelayConfig cfg = cfgService.getConfig(appId, DhcpRelayConfig.class); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 195 | if (cfg == null) { |
| 196 | log.warn("Dhcp Server info not available"); |
| 197 | return; |
| 198 | } |
| 199 | |
| 200 | dhcpServerConnectPoint = cfg.getDhcpServerConnectPoint(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 201 | Ip4Address oldDhcpServerIp = dhcpServerIp; |
| 202 | Ip4Address oldDhcpGatewayIp = dhcpGatewayIp; |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 203 | dhcpServerIp = cfg.getDhcpServerIp(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 204 | dhcpGatewayIp = cfg.getDhcpGatewayIp(); |
| 205 | dhcpConnectMac = null; // reset for updated config |
| 206 | dhcpConnectVlan = null; // reset for updated config |
| 207 | log.info("dhcp server connect point: " + dhcpServerConnectPoint); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 208 | log.info("dhcp server ipaddress " + dhcpServerIp); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 209 | if (dhcpGatewayIp != null) { |
| 210 | // check for gateway |
| 211 | Set<Host> ghosts = hostService.getHostsByIp(dhcpGatewayIp); |
| 212 | if (ghosts == null || ghosts.isEmpty()) { |
| 213 | log.info("Probing to resolve dhcp gateway IP {}", dhcpGatewayIp); |
| 214 | if (oldDhcpGatewayIp != null) { |
| 215 | hostService.stopMonitoringIp(oldDhcpGatewayIp); |
| 216 | } |
| 217 | hostService.startMonitoringIp(dhcpGatewayIp); |
| 218 | } else { |
| 219 | // gw is known, no need to probe; should be only 1 host with this ip |
| 220 | hostUpdated(ghosts.iterator().next()); |
| 221 | } |
| 222 | } else { |
| 223 | // check for server |
| 224 | Set<Host> shosts = hostService.getHostsByIp(dhcpServerIp); |
| 225 | if (shosts == null || shosts.isEmpty()) { |
| 226 | log.info("Probing to resolve dhcp server IP {}", dhcpServerIp); |
| 227 | if (oldDhcpServerIp != null) { |
| 228 | hostService.stopMonitoringIp(oldDhcpServerIp); |
| 229 | } |
| 230 | hostService.startMonitoringIp(dhcpServerIp); |
| 231 | } else { |
| 232 | // dhcp server is know, no need to probe |
| 233 | hostUpdated(shosts.iterator().next()); |
| 234 | } |
| 235 | } |
| 236 | } |
| 237 | |
| 238 | private void hostRemoved(Host host) { |
| 239 | if (host.ipAddresses().contains(dhcpServerIp)) { |
| 240 | log.warn("DHCP server {} removed", dhcpServerIp); |
| 241 | dhcpConnectMac = null; |
| 242 | dhcpConnectVlan = null; |
| 243 | } |
| 244 | if (dhcpGatewayIp != null && host.ipAddresses().contains(dhcpGatewayIp)) { |
| 245 | log.warn("DHCP gateway {} removed", dhcpGatewayIp); |
| 246 | dhcpConnectMac = null; |
| 247 | dhcpConnectVlan = null; |
| 248 | } |
| 249 | } |
| 250 | |
| 251 | private void hostUpdated(Host host) { |
| 252 | if (dhcpGatewayIp != null) { |
| 253 | if (host.ipAddresses().contains(dhcpGatewayIp)) { |
| 254 | dhcpConnectMac = host.mac(); |
| 255 | dhcpConnectVlan = host.vlan(); |
| 256 | log.info("DHCP gateway {} resolved to Mac/Vlan:{}/{}", dhcpGatewayIp, |
| 257 | dhcpConnectMac, dhcpConnectVlan); |
| 258 | } |
| 259 | return; |
| 260 | } |
| 261 | if (host.ipAddresses().contains(dhcpServerIp)) { |
| 262 | dhcpConnectMac = host.mac(); |
| 263 | dhcpConnectVlan = host.vlan(); |
| 264 | log.info("DHCP server {} resolved to Mac/Vlan:{}/{}", dhcpServerIp, |
| 265 | dhcpConnectMac, dhcpConnectVlan); |
| 266 | } |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 267 | } |
| 268 | |
| 269 | /** |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 270 | * Request DHCP packet in via PacketService. |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 271 | */ |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 272 | private void requestDhcpPackets() { |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 273 | TrafficSelector.Builder selectorServer = DefaultTrafficSelector.builder() |
| 274 | .matchEthType(Ethernet.TYPE_IPV4) |
| 275 | .matchIPProtocol(IPv4.PROTOCOL_UDP) |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 276 | .matchUdpSrc(TpPort.tpPort(UDP.DHCP_SERVER_PORT)); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 277 | packetService.requestPackets(selectorServer.build(), PacketPriority.CONTROL, appId); |
| 278 | |
| 279 | TrafficSelector.Builder selectorClient = DefaultTrafficSelector.builder() |
| 280 | .matchEthType(Ethernet.TYPE_IPV4) |
| 281 | .matchIPProtocol(IPv4.PROTOCOL_UDP) |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 282 | .matchUdpSrc(TpPort.tpPort(UDP.DHCP_CLIENT_PORT)); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 283 | packetService.requestPackets(selectorClient.build(), PacketPriority.CONTROL, appId); |
| 284 | } |
| 285 | |
| 286 | /** |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 287 | * Cancel requested DHCP packets in via packet service. |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 288 | */ |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 289 | private void cancelDhcpPackets() { |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 290 | TrafficSelector.Builder selectorServer = DefaultTrafficSelector.builder() |
| 291 | .matchEthType(Ethernet.TYPE_IPV4) |
| 292 | .matchIPProtocol(IPv4.PROTOCOL_UDP) |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 293 | .matchUdpSrc(TpPort.tpPort(UDP.DHCP_SERVER_PORT)); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 294 | packetService.cancelPackets(selectorServer.build(), PacketPriority.CONTROL, appId); |
| 295 | |
| 296 | TrafficSelector.Builder selectorClient = DefaultTrafficSelector.builder() |
| 297 | .matchEthType(Ethernet.TYPE_IPV4) |
| 298 | .matchIPProtocol(IPv4.PROTOCOL_UDP) |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 299 | .matchUdpSrc(TpPort.tpPort(UDP.DHCP_CLIENT_PORT)); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 300 | packetService.cancelPackets(selectorClient.build(), PacketPriority.CONTROL, appId); |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 301 | } |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 302 | |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 303 | /** |
| 304 | * Request ARP packet in via PacketService. |
| 305 | */ |
| 306 | private void requestArpPackets() { |
| 307 | TrafficSelector.Builder selectorArpServer = DefaultTrafficSelector.builder() |
| 308 | .matchEthType(Ethernet.TYPE_ARP); |
| 309 | packetService.requestPackets(selectorArpServer.build(), PacketPriority.CONTROL, appId); |
| 310 | } |
| 311 | |
| 312 | /** |
| 313 | * Cancel requested ARP packets in via packet service. |
| 314 | */ |
| 315 | private void cancelArpPackets() { |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 316 | TrafficSelector.Builder selectorArpServer = DefaultTrafficSelector.builder() |
| 317 | .matchEthType(Ethernet.TYPE_ARP); |
| 318 | packetService.cancelPackets(selectorArpServer.build(), PacketPriority.CONTROL, appId); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 319 | } |
| 320 | |
| 321 | private class DhcpRelayPacketProcessor implements PacketProcessor { |
| 322 | |
| 323 | @Override |
| 324 | public void process(PacketContext context) { |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 325 | if (!configured()) { |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 326 | log.warn("Missing DHCP relay server config. Abort packet processing"); |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 327 | return; |
| 328 | } |
| 329 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 330 | // process the packet and get the payload |
| 331 | Ethernet packet = context.inPacket().parsed(); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 332 | if (packet == null) { |
| 333 | return; |
| 334 | } |
| 335 | |
| 336 | if (packet.getEtherType() == Ethernet.TYPE_IPV4) { |
| 337 | IPv4 ipv4Packet = (IPv4) packet.getPayload(); |
| 338 | |
| 339 | if (ipv4Packet.getProtocol() == IPv4.PROTOCOL_UDP) { |
| 340 | UDP udpPacket = (UDP) ipv4Packet.getPayload(); |
| 341 | DHCP dhcpPayload = (DHCP) udpPacket.getPayload(); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 342 | if (udpPacket.getSourcePort() == UDP.DHCP_CLIENT_PORT || |
| 343 | udpPacket.getSourcePort() == UDP.DHCP_SERVER_PORT) { |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 344 | //This packet is dhcp. |
| 345 | processDhcpPacket(context, dhcpPayload); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 346 | } |
| 347 | } |
Pier Luigi | 20557c8 | 2017-01-12 22:40:46 -0800 | [diff] [blame] | 348 | } else if (packet.getEtherType() == Ethernet.TYPE_ARP && arpEnabled) { |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 349 | ARP arpPacket = (ARP) packet.getPayload(); |
| 350 | Set<Interface> serverInterfaces = interfaceService. |
| 351 | getInterfacesByPort(context.inPacket().receivedFrom()); |
| 352 | //ignore the packets if dhcp server interface is not configured on onos. |
| 353 | if (serverInterfaces.isEmpty()) { |
| 354 | log.warn("server virtual interface not configured"); |
| 355 | return; |
| 356 | } |
| 357 | if ((arpPacket.getOpCode() == ARP.OP_REQUEST) && |
| 358 | checkArpRequestFrmDhcpServ(serverInterfaces, arpPacket)) { |
| 359 | processArpPacket(context, packet); |
| 360 | } |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 361 | } |
| 362 | } |
| 363 | |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 364 | //method to check the arp request is from dhcp server for default-gateway. |
| 365 | private boolean checkArpRequestFrmDhcpServ(Set<Interface> serverInterfaces, ARP arpPacket) { |
| 366 | if (Objects.equals(serverInterfaces.iterator().next().ipAddressesList().get(0). |
| 367 | ipAddress().getIp4Address(), |
| 368 | Ip4Address.valueOf(arpPacket.getTargetProtocolAddress()))) { |
| 369 | return true; |
| 370 | } |
| 371 | return false; |
| 372 | } |
| 373 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 374 | //forward the packet to ConnectPoint where the DHCP server is attached. |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 375 | private void forwardPacket(Ethernet packet) { |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 376 | //send Packetout to dhcp server connectpoint. |
| 377 | if (dhcpServerConnectPoint != null) { |
| 378 | TrafficTreatment t = DefaultTrafficTreatment.builder() |
| 379 | .setOutput(dhcpServerConnectPoint.port()).build(); |
| 380 | OutboundPacket o = new DefaultOutboundPacket( |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 381 | dhcpServerConnectPoint.deviceId(), t, ByteBuffer.wrap(packet.serialize())); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 382 | if (log.isTraceEnabled()) { |
| 383 | log.trace("Relaying packet to dhcp server {}", packet); |
| 384 | } |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 385 | packetService.emit(o); |
| 386 | } |
| 387 | } |
| 388 | |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 389 | /** |
| 390 | * Processes the ARP Payload and initiates a reply to the client. |
| 391 | * |
| 392 | * @param context context of the incoming message |
| 393 | * @param packet the ethernet payload |
| 394 | */ |
| 395 | private void processArpPacket(PacketContext context, Ethernet packet) { |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 396 | ARP arpPacket = (ARP) packet.getPayload(); |
| 397 | |
| 398 | ARP arpReply = (ARP) arpPacket.clone(); |
| 399 | arpReply.setOpCode(ARP.OP_REPLY); |
| 400 | |
| 401 | arpReply.setTargetProtocolAddress(arpPacket.getSenderProtocolAddress()); |
| 402 | arpReply.setTargetHardwareAddress(arpPacket.getSenderHardwareAddress()); |
| 403 | arpReply.setSenderProtocolAddress(arpPacket.getTargetProtocolAddress()); |
| 404 | arpReply.setSenderHardwareAddress(myMAC.toBytes()); |
| 405 | |
| 406 | // Ethernet Frame. |
| 407 | Ethernet ethReply = new Ethernet(); |
| 408 | ethReply.setSourceMACAddress(myMAC); |
| 409 | ethReply.setDestinationMACAddress(packet.getSourceMAC()); |
| 410 | ethReply.setEtherType(Ethernet.TYPE_ARP); |
| 411 | ethReply.setVlanID(packet.getVlanID()); |
| 412 | |
| 413 | ethReply.setPayload(arpReply); |
| 414 | forwardPacket(ethReply); |
| 415 | } |
| 416 | |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 417 | //process the dhcp packet before sending to server |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 418 | private void processDhcpPacket(PacketContext context, DHCP dhcpPayload) { |
Charles Chan | 1b20123 | 2016-12-07 15:39:22 -0800 | [diff] [blame] | 419 | ConnectPoint inPort = context.inPacket().receivedFrom(); |
| 420 | Set<Interface> clientServerInterfaces = interfaceService.getInterfacesByPort(inPort); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 421 | //ignore the packets if dhcp client interface is not configured on onos. |
| 422 | if (clientServerInterfaces.isEmpty()) { |
Charles Chan | 1b20123 | 2016-12-07 15:39:22 -0800 | [diff] [blame] | 423 | log.warn("Virtual interface is not configured on {}", inPort); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 424 | return; |
| 425 | } |
| 426 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 427 | if (dhcpPayload == null) { |
| 428 | return; |
| 429 | } |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 430 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 431 | Ethernet packet = context.inPacket().parsed(); |
| 432 | DHCPPacketType incomingPacketType = null; |
| 433 | for (DHCPOption option : dhcpPayload.getOptions()) { |
| 434 | if (option.getCode() == OptionCode_MessageType.getValue()) { |
| 435 | byte[] data = option.getData(); |
| 436 | incomingPacketType = DHCPPacketType.getType(data[0]); |
| 437 | } |
| 438 | } |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 439 | |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 440 | switch (incomingPacketType) { |
| 441 | case DHCPDISCOVER: |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 442 | // add the gatewayip as virtual interface ip for server to understand |
| 443 | // the lease to be assigned and forward the packet to dhcp server. |
| 444 | Ethernet ethernetPacketDiscover = |
| 445 | processDhcpPacketFromClient(context, packet, clientServerInterfaces); |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 446 | if (ethernetPacketDiscover != null) { |
| 447 | forwardPacket(ethernetPacketDiscover); |
| 448 | } |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 449 | break; |
| 450 | case DHCPOFFER: |
| 451 | //reply to dhcp client. |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 452 | Ethernet ethernetPacketOffer = processDhcpPacketFromServer(packet); |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 453 | if (ethernetPacketOffer != null) { |
| 454 | sendReply(ethernetPacketOffer, dhcpPayload); |
| 455 | } |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 456 | break; |
| 457 | case DHCPREQUEST: |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 458 | // add the gatewayip as virtual interface ip for server to understand |
| 459 | // the lease to be assigned and forward the packet to dhcp server. |
| 460 | Ethernet ethernetPacketRequest = |
| 461 | processDhcpPacketFromClient(context, packet, clientServerInterfaces); |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 462 | if (ethernetPacketRequest != null) { |
| 463 | forwardPacket(ethernetPacketRequest); |
| 464 | } |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 465 | break; |
| 466 | case DHCPACK: |
| 467 | //reply to dhcp client. |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 468 | Ethernet ethernetPacketAck = processDhcpPacketFromServer(packet); |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 469 | if (ethernetPacketAck != null) { |
| 470 | sendReply(ethernetPacketAck, dhcpPayload); |
| 471 | } |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 472 | break; |
| 473 | default: |
| 474 | break; |
| 475 | } |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 476 | } |
| 477 | |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 478 | //build the DHCP discover/request packet with gatewayip(unicast packet) |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 479 | private Ethernet processDhcpPacketFromClient(PacketContext context, |
| 480 | Ethernet ethernetPacket, Set<Interface> clientInterfaces) { |
| 481 | Ip4Address relayAgentIp = getRelayAgentIPv4Address(clientInterfaces); |
| 482 | MacAddress relayAgentMac = clientInterfaces.iterator().next().mac(); |
| 483 | if (relayAgentIp == null || relayAgentMac == null) { |
| 484 | log.warn("Missing DHCP relay agent interface Ipv4 addr config for " |
| 485 | + "packet from client on port: {}. Aborting packet processing", |
| 486 | clientInterfaces.iterator().next().connectPoint()); |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 487 | return null; |
| 488 | } |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 489 | if (dhcpConnectMac == null) { |
| 490 | log.warn("DHCP {} not yet resolved .. Aborting DHCP " |
| 491 | + "packet processing from client on port: {}", |
| 492 | (dhcpGatewayIp == null) ? "server IP " + dhcpServerIp |
| 493 | : "gateway IP " + dhcpGatewayIp, |
| 494 | clientInterfaces.iterator().next().connectPoint()); |
| 495 | return null; |
| 496 | } |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 497 | // get dhcp header. |
| 498 | Ethernet etherReply = (Ethernet) ethernetPacket.clone(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 499 | etherReply.setSourceMACAddress(relayAgentMac); |
| 500 | etherReply.setDestinationMACAddress(dhcpConnectMac); |
| 501 | etherReply.setVlanID(dhcpConnectVlan.toShort()); |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 502 | IPv4 ipv4Packet = (IPv4) etherReply.getPayload(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 503 | ipv4Packet.setSourceAddress(relayAgentIp.toInt()); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 504 | ipv4Packet.setDestinationAddress(dhcpServerIp.toInt()); |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 505 | UDP udpPacket = (UDP) ipv4Packet.getPayload(); |
| 506 | DHCP dhcpPacket = (DHCP) udpPacket.getPayload(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 507 | dhcpPacket.setGatewayIPAddress(relayAgentIp.toInt()); |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 508 | udpPacket.setPayload(dhcpPacket); |
| 509 | ipv4Packet.setPayload(udpPacket); |
| 510 | etherReply.setPayload(ipv4Packet); |
| 511 | return etherReply; |
| 512 | } |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 513 | |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 514 | // Returns the first v4 interface ip out of a set of interfaces or null. |
| 515 | // Checks all interfaces, and ignores v6 interface ips |
| 516 | private Ip4Address getRelayAgentIPv4Address(Set<Interface> intfs) { |
| 517 | for (Interface intf : intfs) { |
| 518 | for (InterfaceIpAddress ip : intf.ipAddressesList()) { |
| 519 | Ip4Address relayAgentIp = ip.ipAddress().getIp4Address(); |
| 520 | if (relayAgentIp != null) { |
| 521 | return relayAgentIp; |
| 522 | } |
| 523 | } |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 524 | } |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 525 | return null; |
| 526 | } |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 527 | |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 528 | //build the DHCP offer/ack with proper client port. |
| 529 | private Ethernet processDhcpPacketFromServer(Ethernet ethernetPacket) { |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 530 | // get dhcp header. |
| 531 | Ethernet etherReply = (Ethernet) ethernetPacket.clone(); |
| 532 | IPv4 ipv4Packet = (IPv4) etherReply.getPayload(); |
| 533 | UDP udpPacket = (UDP) ipv4Packet.getPayload(); |
| 534 | DHCP dhcpPayload = (DHCP) udpPacket.getPayload(); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 535 | |
| 536 | // determine the vlanId of the client host - note that this vlan id |
| 537 | // could be different from the vlan in the packet from the server |
| 538 | MacAddress dstMac = valueOf(dhcpPayload.getClientHardwareAddress()); |
| 539 | Set<Host> hosts = hostService.getHostsByMac(dstMac); |
| 540 | if (hosts == null || hosts.isEmpty()) { |
| 541 | log.warn("Cannot determine host for DHCP client: {}. Aborting " |
| 542 | + "relay for dhcp packet from server {}", |
| 543 | dhcpPayload.getClientHardwareAddress(), ethernetPacket); |
| 544 | return null; |
| 545 | } else if (hosts.size() > 1) { |
| 546 | // XXX redo to send reply to all hosts found |
| 547 | log.warn("Multiple hosts found for mac:{}. Picking one " |
| 548 | + "host out of {}", dstMac, hosts); |
| 549 | } |
| 550 | Host host = hosts.iterator().next(); |
| 551 | etherReply.setDestinationMACAddress(dstMac); |
| 552 | etherReply.setVlanID(host.vlan().toShort()); |
| 553 | // we leave the srcMac from the original packet |
| 554 | |
| 555 | // figure out the relay agent IP corresponding to the original request |
| 556 | Ip4Address relayAgentIP = getRelayAgentIPv4Address( |
| 557 | interfaceService.getInterfacesByPort(host.location())); |
| 558 | if (relayAgentIP == null) { |
| 559 | log.warn("Cannot determine relay agent interface Ipv4 addr for host {}. " |
| 560 | + "Aborting relay for dhcp packet from server {}", |
| 561 | host, ethernetPacket); |
| 562 | return null; |
| 563 | } |
Charles Chan | da5dc8c | 2017-01-13 14:29:29 -0800 | [diff] [blame] | 564 | // SRC_IP: relay agent IP |
| 565 | // DST_IP: offered IP |
| 566 | ipv4Packet.setSourceAddress(relayAgentIP.toInt()); |
| 567 | ipv4Packet.setDestinationAddress(dhcpPayload.getYourIPAddress()); |
| 568 | |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 569 | udpPacket.setDestinationPort(UDP.DHCP_CLIENT_PORT); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 570 | udpPacket.setPayload(dhcpPayload); |
| 571 | ipv4Packet.setPayload(udpPacket); |
| 572 | etherReply.setPayload(ipv4Packet); |
| 573 | return etherReply; |
| 574 | } |
| 575 | |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 576 | //send the response to the requester host. |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 577 | private void sendReply(Ethernet ethPacket, DHCP dhcpPayload) { |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 578 | MacAddress descMac = valueOf(dhcpPayload.getClientHardwareAddress()); |
gaurav | 38351de | 2016-07-27 04:44:33 +0530 | [diff] [blame] | 579 | Host host = hostService.getHost(HostId.hostId(descMac, |
gaurav | 4af95fb | 2016-07-07 01:48:44 +0530 | [diff] [blame] | 580 | VlanId.vlanId(ethPacket.getVlanID()))); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 581 | |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 582 | // Send packet out to requester if the host information is available |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 583 | if (host != null) { |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 584 | TrafficTreatment t = DefaultTrafficTreatment.builder() |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 585 | .setOutput(host.location().port()).build(); |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 586 | OutboundPacket o = new DefaultOutboundPacket( |
Charles Chan | 3c1691a | 2017-02-16 14:55:22 -0800 | [diff] [blame] | 587 | host.location().deviceId(), t, ByteBuffer.wrap(ethPacket.serialize())); |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 588 | if (log.isTraceEnabled()) { |
| 589 | log.trace("Relaying packet to dhcp client {}", ethPacket); |
| 590 | } |
gaurav | f088456 | 2016-06-17 02:47:13 +0530 | [diff] [blame] | 591 | packetService.emit(o); |
| 592 | } |
| 593 | } |
| 594 | } |
| 595 | |
| 596 | /** |
| 597 | * Listener for network config events. |
| 598 | */ |
| 599 | private class InternalConfigListener implements NetworkConfigListener { |
| 600 | |
| 601 | @Override |
| 602 | public void event(NetworkConfigEvent event) { |
| 603 | |
| 604 | if ((event.type() == NetworkConfigEvent.Type.CONFIG_ADDED || |
| 605 | event.type() == NetworkConfigEvent.Type.CONFIG_UPDATED) && |
| 606 | event.configClass().equals(DhcpRelayConfig.class)) { |
| 607 | updateConfig(); |
| 608 | log.info("Reconfigured"); |
| 609 | } |
| 610 | } |
| 611 | } |
Saurav Das | b0ae6ee | 2017-03-04 16:08:47 -0800 | [diff] [blame^] | 612 | |
| 613 | /** |
| 614 | * Internal listener for host events. |
| 615 | */ |
| 616 | private class InternalHostListener implements HostListener { |
| 617 | @Override |
| 618 | public void event(HostEvent event) { |
| 619 | switch (event.type()) { |
| 620 | case HOST_ADDED: |
| 621 | case HOST_UPDATED: |
| 622 | hostUpdated(event.subject()); |
| 623 | break; |
| 624 | case HOST_REMOVED: |
| 625 | hostRemoved(event.subject()); |
| 626 | break; |
| 627 | case HOST_MOVED: |
| 628 | // XXX todo -- moving dhcp server |
| 629 | break; |
| 630 | default: |
| 631 | break; |
| 632 | } |
| 633 | } |
| 634 | } |
Lei Xu | 3aeaf72 | 2016-08-11 13:51:12 -0700 | [diff] [blame] | 635 | } |