Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 1 | /* |
Brian O'Connor | a09fe5b | 2017-08-03 21:12:30 -0700 | [diff] [blame] | 2 | * Copyright 2015-present Open Networking Foundation |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | package org.onosproject.rest.resources; |
| 17 | |
| 18 | import java.util.Spliterator; |
| 19 | import java.util.Spliterators; |
| 20 | import java.util.stream.StreamSupport; |
| 21 | |
| 22 | import javax.ws.rs.GET; |
| 23 | import javax.ws.rs.Path; |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 24 | import javax.ws.rs.PathParam; |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 25 | import javax.ws.rs.Produces; |
| 26 | import javax.ws.rs.QueryParam; |
| 27 | import javax.ws.rs.core.Context; |
| 28 | import javax.ws.rs.core.MediaType; |
| 29 | import javax.ws.rs.core.Response; |
| 30 | import javax.ws.rs.core.UriBuilder; |
| 31 | import javax.ws.rs.core.UriInfo; |
| 32 | |
| 33 | import org.onosproject.codec.JsonCodec; |
| 34 | import org.onosproject.net.ConnectPoint; |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 35 | import org.onosproject.net.Device; |
| 36 | import org.onosproject.net.DeviceId; |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 37 | import org.onosproject.net.Link; |
Viswanath KSP | 8ffb775 | 2016-08-23 22:19:06 +0530 | [diff] [blame] | 38 | import org.onosproject.net.PortNumber; |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 39 | import org.onosproject.net.device.DeviceService; |
Srikanth Vavilapalli | d120f5c | 2015-11-24 14:15:01 -0800 | [diff] [blame] | 40 | import org.onosproject.net.device.PortStatistics; |
Jordan Halterman | b81fdc1 | 2019-03-04 18:12:20 -0800 | [diff] [blame] | 41 | import org.onosproject.net.flow.FlowEntry; |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 42 | import org.onosproject.net.flow.FlowRuleService; |
| 43 | import org.onosproject.net.flow.TableStatisticsEntry; |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 44 | import org.onosproject.net.link.LinkService; |
| 45 | import org.onosproject.net.statistic.Load; |
| 46 | import org.onosproject.net.statistic.StatisticService; |
| 47 | import org.onosproject.rest.AbstractWebResource; |
| 48 | |
| 49 | import com.fasterxml.jackson.databind.node.ArrayNode; |
| 50 | import com.fasterxml.jackson.databind.node.ObjectNode; |
| 51 | |
| 52 | import static org.onosproject.net.DeviceId.deviceId; |
| 53 | import static org.onosproject.net.PortNumber.portNumber; |
| 54 | |
| 55 | /** |
Laszlo Papp | b2a91f2 | 2018-01-10 16:41:22 +0000 | [diff] [blame] | 56 | * Query statistics. |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 57 | */ |
| 58 | @Path("statistics") |
| 59 | public class StatisticsWebResource extends AbstractWebResource { |
| 60 | @Context |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 61 | private UriInfo uriInfo; |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 62 | |
| 63 | /** |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 64 | * Gets load statistics for all links or for a specific link. |
| 65 | * |
Andrea Campanella | 10c4adc | 2015-12-03 15:27:54 -0800 | [diff] [blame] | 66 | * @onos.rsModel StatisticsFlowsLink |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 67 | * @param deviceId (optional) device ID for a specific link |
| 68 | * @param port (optional) port number for a specified link |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 69 | * @return 200 OK with JSON encoded array of Load objects |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 70 | */ |
| 71 | @GET |
| 72 | @Path("flows/link") |
| 73 | @Produces(MediaType.APPLICATION_JSON) |
| 74 | public Response getLoads(@QueryParam("device") String deviceId, |
| 75 | @QueryParam("port") String port) { |
| 76 | Iterable<Link> links; |
| 77 | |
| 78 | if (deviceId == null || port == null) { |
| 79 | links = get(LinkService.class).getLinks(); |
| 80 | } else { |
| 81 | ConnectPoint connectPoint = new ConnectPoint(deviceId(deviceId), |
| 82 | portNumber(port)); |
| 83 | links = get(LinkService.class).getLinks(connectPoint); |
| 84 | } |
| 85 | ObjectNode result = mapper().createObjectNode(); |
| 86 | ArrayNode loads = mapper().createArrayNode(); |
| 87 | JsonCodec<Load> loadCodec = codec(Load.class); |
| 88 | StatisticService statsService = getService(StatisticService.class); |
| 89 | |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 90 | StreamSupport.stream(Spliterators.spliteratorUnknownSize( |
| 91 | links.iterator(), Spliterator.ORDERED), false) |
| 92 | .forEach(link -> { |
| 93 | ObjectNode loadNode = loadCodec.encode(statsService.load(link), this); |
| 94 | |
| 95 | UriBuilder locationBuilder = uriInfo.getBaseUriBuilder() |
| 96 | .path("links") |
| 97 | .queryParam("device", link.src().deviceId().toString()) |
| 98 | .queryParam("port", link.src().port().toString()); |
| 99 | loadNode.put("link", locationBuilder.build().toString()); |
| 100 | loads.add(loadNode); |
| 101 | }); |
| 102 | result.set("loads", loads); |
| 103 | return ok(result).build(); |
| 104 | } |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 105 | |
| 106 | /** |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 107 | * Gets table statistics for all tables of all devices. |
| 108 | * |
Andrea Campanella | 10c4adc | 2015-12-03 15:27:54 -0800 | [diff] [blame] | 109 | * @onos.rsModel StatisticsFlowsTables |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 110 | * @return 200 OK with JSON encoded array of table statistics |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 111 | */ |
| 112 | @GET |
| 113 | @Path("flows/tables") |
| 114 | @Produces(MediaType.APPLICATION_JSON) |
| 115 | public Response getTableStatistics() { |
| 116 | final FlowRuleService service = get(FlowRuleService.class); |
| 117 | final Iterable<Device> devices = get(DeviceService.class).getDevices(); |
| 118 | final ObjectNode root = mapper().createObjectNode(); |
andrea | 1ce2bc8 | 2015-11-18 16:58:10 -0800 | [diff] [blame] | 119 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 120 | for (final Device device : devices) { |
| 121 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 122 | deviceStatsNode.put("device", device.id().toString()); |
andrea | 1ce2bc8 | 2015-11-18 16:58:10 -0800 | [diff] [blame] | 123 | final ArrayNode statisticsNode = deviceStatsNode.putArray("table"); |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 124 | final Iterable<TableStatisticsEntry> tableStatsEntries = service.getFlowTableStatistics(device.id()); |
| 125 | if (tableStatsEntries != null) { |
| 126 | for (final TableStatisticsEntry entry : tableStatsEntries) { |
| 127 | statisticsNode.add(codec(TableStatisticsEntry.class).encode(entry, this)); |
| 128 | } |
| 129 | } |
| 130 | rootArrayNode.add(deviceStatsNode); |
| 131 | } |
| 132 | |
| 133 | return ok(root).build(); |
| 134 | } |
| 135 | |
| 136 | /** |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 137 | * Gets table statistics for all tables of a specified device. |
| 138 | * |
Andrea Campanella | 10c4adc | 2015-12-03 15:27:54 -0800 | [diff] [blame] | 139 | * @onos.rsModel StatisticsFlowsTables |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 140 | * @param deviceId device ID |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 141 | * @return 200 OK with JSON encoded array of table statistics |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 142 | */ |
| 143 | @GET |
| 144 | @Path("flows/tables/{deviceId}") |
| 145 | @Produces(MediaType.APPLICATION_JSON) |
| 146 | public Response getTableStatisticsByDeviceId(@PathParam("deviceId") String deviceId) { |
| 147 | final FlowRuleService service = get(FlowRuleService.class); |
| 148 | final Iterable<TableStatisticsEntry> tableStatisticsEntries = |
| 149 | service.getFlowTableStatistics(DeviceId.deviceId(deviceId)); |
| 150 | final ObjectNode root = mapper().createObjectNode(); |
andrea | 1ce2bc8 | 2015-11-18 16:58:10 -0800 | [diff] [blame] | 151 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 152 | |
| 153 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 154 | deviceStatsNode.put("device", deviceId); |
andrea | 1ce2bc8 | 2015-11-18 16:58:10 -0800 | [diff] [blame] | 155 | final ArrayNode statisticsNode = deviceStatsNode.putArray("table"); |
Srikanth Vavilapalli | 95810f5 | 2015-09-14 15:49:56 -0700 | [diff] [blame] | 156 | for (final TableStatisticsEntry entry : tableStatisticsEntries) { |
| 157 | statisticsNode.add(codec(TableStatisticsEntry.class).encode(entry, this)); |
| 158 | } |
| 159 | rootArrayNode.add(deviceStatsNode); |
| 160 | return ok(root).build(); |
| 161 | } |
Srikanth Vavilapalli | d120f5c | 2015-11-24 14:15:01 -0800 | [diff] [blame] | 162 | |
| 163 | /** |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 164 | * Gets port statistics of all devices. |
Andrea Campanella | 10c4adc | 2015-12-03 15:27:54 -0800 | [diff] [blame] | 165 | * @onos.rsModel StatisticsPorts |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 166 | * @return 200 OK with JSON encoded array of port statistics |
Srikanth Vavilapalli | d120f5c | 2015-11-24 14:15:01 -0800 | [diff] [blame] | 167 | */ |
| 168 | @GET |
| 169 | @Path("ports") |
| 170 | @Produces(MediaType.APPLICATION_JSON) |
| 171 | public Response getPortStatistics() { |
| 172 | final DeviceService service = get(DeviceService.class); |
| 173 | final Iterable<Device> devices = service.getDevices(); |
| 174 | final ObjectNode root = mapper().createObjectNode(); |
| 175 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
| 176 | for (final Device device : devices) { |
| 177 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 178 | deviceStatsNode.put("device", device.id().toString()); |
| 179 | final ArrayNode statisticsNode = deviceStatsNode.putArray("ports"); |
| 180 | final Iterable<PortStatistics> portStatsEntries = service.getPortStatistics(device.id()); |
| 181 | if (portStatsEntries != null) { |
| 182 | for (final PortStatistics entry : portStatsEntries) { |
| 183 | statisticsNode.add(codec(PortStatistics.class).encode(entry, this)); |
| 184 | } |
| 185 | } |
| 186 | rootArrayNode.add(deviceStatsNode); |
| 187 | } |
| 188 | |
| 189 | return ok(root).build(); |
| 190 | } |
| 191 | |
| 192 | /** |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 193 | * Gets port statistics of a specified devices. |
Andrea Campanella | 10c4adc | 2015-12-03 15:27:54 -0800 | [diff] [blame] | 194 | * @onos.rsModel StatisticsPorts |
Srikanth Vavilapalli | d120f5c | 2015-11-24 14:15:01 -0800 | [diff] [blame] | 195 | * @param deviceId device ID |
Jian Li | cc730a6 | 2016-05-10 16:36:16 -0700 | [diff] [blame] | 196 | * @return 200 OK with JSON encoded array of port statistics |
Srikanth Vavilapalli | d120f5c | 2015-11-24 14:15:01 -0800 | [diff] [blame] | 197 | */ |
| 198 | @GET |
| 199 | @Path("ports/{deviceId}") |
| 200 | @Produces(MediaType.APPLICATION_JSON) |
| 201 | public Response getPortStatisticsByDeviceId(@PathParam("deviceId") String deviceId) { |
| 202 | final DeviceService service = get(DeviceService.class); |
| 203 | final Iterable<PortStatistics> portStatsEntries = |
| 204 | service.getPortStatistics(DeviceId.deviceId(deviceId)); |
| 205 | final ObjectNode root = mapper().createObjectNode(); |
| 206 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
| 207 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 208 | deviceStatsNode.put("device", deviceId); |
| 209 | final ArrayNode statisticsNode = deviceStatsNode.putArray("ports"); |
| 210 | if (portStatsEntries != null) { |
| 211 | for (final PortStatistics entry : portStatsEntries) { |
| 212 | statisticsNode.add(codec(PortStatistics.class).encode(entry, this)); |
| 213 | } |
| 214 | } |
| 215 | rootArrayNode.add(deviceStatsNode); |
| 216 | |
| 217 | return ok(root).build(); |
| 218 | } |
| 219 | |
Viswanath KSP | 8ffb775 | 2016-08-23 22:19:06 +0530 | [diff] [blame] | 220 | /** |
| 221 | * Gets port statistics of a specified device and port. |
| 222 | * @onos.rsModel StatisticsPorts |
| 223 | * @param deviceId device ID |
| 224 | * @param port port |
| 225 | * @return 200 OK with JSON encoded array of port statistics for the specified port |
| 226 | */ |
| 227 | @GET |
| 228 | @Path("ports/{deviceId}/{port}") |
| 229 | @Produces(MediaType.APPLICATION_JSON) |
| 230 | public Response getPortStatisticsByDeviceIdAndPort(@PathParam("deviceId") String deviceId, |
| 231 | @PathParam("port") String port) { |
| 232 | final DeviceService service = get(DeviceService.class); |
| 233 | final PortNumber portNumber = portNumber(port); |
| 234 | final PortStatistics portStatsEntry = |
| 235 | service.getStatisticsForPort(DeviceId.deviceId(deviceId), portNumber); |
| 236 | final ObjectNode root = mapper().createObjectNode(); |
| 237 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
| 238 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 239 | deviceStatsNode.put("device", deviceId); |
| 240 | final ArrayNode statisticsNode = deviceStatsNode.putArray("ports"); |
| 241 | if (portStatsEntry != null) { |
| 242 | statisticsNode.add(codec(PortStatistics.class).encode(portStatsEntry, this)); |
| 243 | } |
| 244 | rootArrayNode.add(deviceStatsNode); |
| 245 | |
| 246 | return ok(root).build(); |
| 247 | } |
| 248 | |
Viswanath KSP | 13e5b51 | 2016-08-25 12:33:16 +0530 | [diff] [blame] | 249 | /** |
| 250 | * Gets port delta statistics of all devices. |
| 251 | * @onos.rsModel StatisticsPorts |
| 252 | * @return 200 OK with JSON encoded array of port delta statistics |
| 253 | */ |
| 254 | @GET |
| 255 | @Path("delta/ports") |
| 256 | @Produces(MediaType.APPLICATION_JSON) |
| 257 | public Response getPortDeltaStatistics() { |
| 258 | final DeviceService service = get(DeviceService.class); |
| 259 | final Iterable<Device> devices = service.getDevices(); |
| 260 | final ObjectNode root = mapper().createObjectNode(); |
| 261 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
| 262 | for (final Device device : devices) { |
| 263 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 264 | deviceStatsNode.put("device", device.id().toString()); |
| 265 | final ArrayNode statisticsNode = deviceStatsNode.putArray("ports"); |
| 266 | final Iterable<PortStatistics> portStatsEntries = service.getPortDeltaStatistics(device.id()); |
| 267 | if (portStatsEntries != null) { |
| 268 | for (final PortStatistics entry : portStatsEntries) { |
| 269 | statisticsNode.add(codec(PortStatistics.class).encode(entry, this)); |
| 270 | } |
| 271 | } |
| 272 | rootArrayNode.add(deviceStatsNode); |
| 273 | } |
| 274 | |
| 275 | return ok(root).build(); |
| 276 | } |
| 277 | |
| 278 | /** |
| 279 | * Gets port delta statistics of a specified devices. |
| 280 | * @onos.rsModel StatisticsPorts |
| 281 | * @param deviceId device ID |
| 282 | * @return 200 OK with JSON encoded array of port delta statistics |
| 283 | */ |
| 284 | @GET |
| 285 | @Path("delta/ports/{deviceId}") |
| 286 | @Produces(MediaType.APPLICATION_JSON) |
| 287 | public Response getPortDeltaStatisticsByDeviceId(@PathParam("deviceId") String deviceId) { |
| 288 | final DeviceService service = get(DeviceService.class); |
| 289 | final Iterable<PortStatistics> portStatsEntries = |
| 290 | service.getPortDeltaStatistics(DeviceId.deviceId(deviceId)); |
| 291 | final ObjectNode root = mapper().createObjectNode(); |
| 292 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
| 293 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 294 | deviceStatsNode.put("device", deviceId); |
| 295 | final ArrayNode statisticsNode = deviceStatsNode.putArray("ports"); |
| 296 | if (portStatsEntries != null) { |
| 297 | for (final PortStatistics entry : portStatsEntries) { |
| 298 | statisticsNode.add(codec(PortStatistics.class).encode(entry, this)); |
| 299 | } |
| 300 | } |
| 301 | rootArrayNode.add(deviceStatsNode); |
| 302 | |
| 303 | return ok(root).build(); |
| 304 | } |
| 305 | |
| 306 | /** |
| 307 | * Gets port delta statistics of a specified device and port. |
| 308 | * @onos.rsModel StatisticsPorts |
| 309 | * @param deviceId device ID |
| 310 | * @param port port |
| 311 | * @return 200 OK with JSON encoded array of port delta statistics for the specified port |
| 312 | */ |
| 313 | @GET |
| 314 | @Path("delta/ports/{deviceId}/{port}") |
| 315 | @Produces(MediaType.APPLICATION_JSON) |
| 316 | public Response getPortDeltaStatisticsByDeviceIdAndPort(@PathParam("deviceId") String deviceId, |
| 317 | @PathParam("port") String port) { |
| 318 | final DeviceService service = get(DeviceService.class); |
| 319 | final PortNumber portNumber = portNumber(port); |
| 320 | final PortStatistics portStatsEntry = |
| 321 | service.getDeltaStatisticsForPort(DeviceId.deviceId(deviceId), portNumber); |
| 322 | final ObjectNode root = mapper().createObjectNode(); |
| 323 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
| 324 | final ObjectNode deviceStatsNode = mapper().createObjectNode(); |
| 325 | deviceStatsNode.put("device", deviceId); |
| 326 | final ArrayNode statisticsNode = deviceStatsNode.putArray("ports"); |
| 327 | if (portStatsEntry != null) { |
| 328 | statisticsNode.add(codec(PortStatistics.class).encode(portStatsEntry, this)); |
| 329 | } |
| 330 | rootArrayNode.add(deviceStatsNode); |
| 331 | |
| 332 | return ok(root).build(); |
| 333 | } |
| 334 | |
Patryk Konopka | 7e40c01 | 2017-06-06 13:38:06 +0200 | [diff] [blame] | 335 | /** |
| 336 | * Gets sum of active entries in all tables for all devices. |
| 337 | * |
| 338 | * @onos.rsModel StatisticsFlowsActiveEntries |
| 339 | * @return 200 OK with JSON encoded array of active entry count per device |
| 340 | */ |
| 341 | @GET |
| 342 | @Path("flows/activeentries") |
| 343 | @Produces(MediaType.APPLICATION_JSON) |
| 344 | public Response getActiveEntriesCountPerDevice() { |
| 345 | final FlowRuleService service = get(FlowRuleService.class); |
| 346 | final Iterable<Device> devices = get(DeviceService.class).getDevices(); |
| 347 | final ObjectNode root = mapper().createObjectNode(); |
| 348 | final ArrayNode rootArrayNode = root.putArray("statistics"); |
| 349 | for (final Device device : devices) { |
Jordan Halterman | b81fdc1 | 2019-03-04 18:12:20 -0800 | [diff] [blame] | 350 | int activeEntries = service.getFlowRuleCount(device.id(), FlowEntry.FlowEntryState.ADDED); |
Patryk Konopka | 7e40c01 | 2017-06-06 13:38:06 +0200 | [diff] [blame] | 351 | final ObjectNode entry = mapper().createObjectNode(); |
| 352 | entry.put("device", device.id().toString()); |
| 353 | entry.put("activeEntries", activeEntries); |
| 354 | rootArrayNode.add(entry); |
| 355 | } |
| 356 | |
| 357 | return ok(root).build(); |
| 358 | } |
Ray Milkey | b9af946 | 2015-07-17 11:12:09 -0700 | [diff] [blame] | 359 | } |