blob: fc733741e1e54cd4802a9c6764fda64623a1b2c9 [file] [log] [blame]
Madan Jampani08822c42014-11-04 17:17:46 -08001package org.onlab.onos.store.service.impl;
2
3import static org.slf4j.LoggerFactory.getLogger;
4
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -08005import java.io.File;
6import java.io.IOException;
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -08007import java.util.Collection;
8import java.util.Collections;
9import java.util.HashSet;
Madan Jampani08822c42014-11-04 17:17:46 -080010import java.util.List;
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080011import java.util.Map;
12import java.util.Set;
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -080013import java.util.concurrent.CountDownLatch;
14import java.util.concurrent.TimeUnit;
Madan Jampani08822c42014-11-04 17:17:46 -080015
16import net.kuujo.copycat.Copycat;
17import net.kuujo.copycat.StateMachine;
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -080018import net.kuujo.copycat.cluster.ClusterConfig;
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080019import net.kuujo.copycat.cluster.Member;
Madan Jampani08822c42014-11-04 17:17:46 -080020import net.kuujo.copycat.cluster.TcpCluster;
21import net.kuujo.copycat.cluster.TcpClusterConfig;
22import net.kuujo.copycat.cluster.TcpMember;
Madan Jampani08822c42014-11-04 17:17:46 -080023import net.kuujo.copycat.log.Log;
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -080024
Madan Jampani08822c42014-11-04 17:17:46 -080025import org.apache.felix.scr.annotations.Activate;
Madan Jampanidfbfa182014-11-04 22:06:41 -080026import org.apache.felix.scr.annotations.Component;
Yuta HIGUCHI657626e2014-11-04 20:54:58 -080027import org.apache.felix.scr.annotations.Deactivate;
Madan Jampani08822c42014-11-04 17:17:46 -080028import org.apache.felix.scr.annotations.Reference;
29import org.apache.felix.scr.annotations.ReferenceCardinality;
Madan Jampanidfbfa182014-11-04 22:06:41 -080030import org.apache.felix.scr.annotations.Service;
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -080031import org.onlab.onos.cluster.ClusterEvent;
32import org.onlab.onos.cluster.ClusterEventListener;
Madan Jampani08822c42014-11-04 17:17:46 -080033import org.onlab.onos.cluster.ClusterService;
34import org.onlab.onos.cluster.ControllerNode;
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080035import org.onlab.onos.cluster.DefaultControllerNode;
36import org.onlab.onos.cluster.NodeId;
Madan Jampani12390c12014-11-12 00:35:56 -080037import org.onlab.onos.store.service.BatchReadRequest;
38import org.onlab.onos.store.service.BatchReadResult;
39import org.onlab.onos.store.service.BatchWriteRequest;
40import org.onlab.onos.store.service.BatchWriteResult;
Madan Jampani08822c42014-11-04 17:17:46 -080041import org.onlab.onos.store.service.DatabaseAdminService;
42import org.onlab.onos.store.service.DatabaseException;
43import org.onlab.onos.store.service.DatabaseService;
Madan Jampani08822c42014-11-04 17:17:46 -080044import org.onlab.onos.store.service.ReadResult;
Madan Jampani12390c12014-11-12 00:35:56 -080045import org.onlab.onos.store.service.ReadStatus;
46import org.onlab.onos.store.service.VersionedValue;
Madan Jampani08822c42014-11-04 17:17:46 -080047import org.onlab.onos.store.service.WriteResult;
Madan Jampani12390c12014-11-12 00:35:56 -080048import org.onlab.onos.store.service.WriteStatus;
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080049import org.onlab.packet.IpAddress;
Madan Jampani08822c42014-11-04 17:17:46 -080050import org.slf4j.Logger;
51
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080052import com.google.common.collect.ImmutableList;
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080053
Madan Jampani08822c42014-11-04 17:17:46 -080054/**
55 * Strongly consistent and durable state management service based on
56 * Copycat implementation of Raft consensus protocol.
57 */
Madan Jampanidfbfa182014-11-04 22:06:41 -080058@Component(immediate = true)
59@Service
Madan Jampani08822c42014-11-04 17:17:46 -080060public class DatabaseManager implements DatabaseService, DatabaseAdminService {
61
62 private final Logger log = getLogger(getClass());
63
64 @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY)
Yuta HIGUCHI5001ba92014-11-04 21:33:54 -080065 protected ClusterService clusterService;
Madan Jampani08822c42014-11-04 17:17:46 -080066
Madan Jampani9b19a822014-11-04 21:37:13 -080067 @Reference(cardinality = ReferenceCardinality.MANDATORY_UNARY)
Yuta HIGUCHI0c1c1002014-11-05 13:47:25 -080068 protected DatabaseProtocolService copycatMessagingProtocol;
Madan Jampani9b19a822014-11-04 21:37:13 -080069
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080070 public static final String LOG_FILE_PREFIX = "/tmp/onos-copy-cat-log_";
71
72 // Current working dir seems to be /opt/onos/apache-karaf-3.0.2
Pavlin Radoslavov190f8f92014-11-11 15:56:14 -080073 // TODO: Set the path to /opt/onos/config
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080074 private static final String CONFIG_DIR = "../config";
75
76 private static final String DEFAULT_MEMBER_FILE = "tablets.json";
77
78 private static final String DEFAULT_TABLET = "default";
79
80 // TODO: make this configurable
81 // initial member configuration file path
82 private String initialMemberConfig = DEFAULT_MEMBER_FILE;
Madan Jampani08822c42014-11-04 17:17:46 -080083
84 private Copycat copycat;
85 private DatabaseClient client;
86
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -080087 // guarded by synchronized block
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -080088 private ClusterConfig<TcpMember> clusterConfig;
89
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -080090 private CountDownLatch clusterEventLatch;
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -080091 private ClusterEventListener clusterEventListener;
92
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -080093 private Map<String, Set<DefaultControllerNode>> tabletMembers;
94
95 private boolean autoAddMember = false;
96
Madan Jampani08822c42014-11-04 17:17:46 -080097 @Activate
98 public void activate() {
Madan Jampanidfbfa182014-11-04 22:06:41 -080099
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800100 // TODO: Not every node should be part of the consensus ring.
Madan Jampanidfbfa182014-11-04 22:06:41 -0800101
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800102 // load tablet configuration
103 File file = new File(CONFIG_DIR, initialMemberConfig);
104 log.info("Loading config: {}", file.getAbsolutePath());
105 TabletDefinitionStore tabletDef = new TabletDefinitionStore(file);
106 try {
107 tabletMembers = tabletDef.read();
108 } catch (IOException e) {
109 log.error("Failed to load tablet config {}", file);
110 throw new IllegalStateException("Failed to load tablet config", e);
111 }
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800112
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800113 // load default tablet configuration and start copycat
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800114 clusterConfig = new TcpClusterConfig();
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800115 Set<DefaultControllerNode> defaultMember = tabletMembers.get(DEFAULT_TABLET);
116 if (defaultMember == null || defaultMember.isEmpty()) {
117 log.error("No member found in [{}] tablet configuration.",
118 DEFAULT_TABLET);
119 throw new IllegalStateException("No member found in tablet configuration");
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800120
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800121 }
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800122
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800123 final ControllerNode localNode = clusterService.getLocalNode();
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800124 for (ControllerNode member : defaultMember) {
125 final TcpMember tcpMember = new TcpMember(member.ip().toString(),
126 member.tcpPort());
127 if (localNode.equals(member)) {
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800128 clusterConfig.setLocalMember(tcpMember);
129 } else {
130 clusterConfig.addRemoteMember(tcpMember);
131 }
132 }
133
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800134 // note: from this point beyond, clusterConfig requires synchronization
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -0800135 clusterEventLatch = new CountDownLatch(1);
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800136 clusterEventListener = new InternalClusterEventListener();
137 clusterService.addListener(clusterEventListener);
Madan Jampani08822c42014-11-04 17:17:46 -0800138
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800139 if (clusterService.getNodes().size() < clusterConfig.getMembers().size()) {
140 // current cluster size smaller then expected
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -0800141 try {
142 if (!clusterEventLatch.await(120, TimeUnit.SECONDS)) {
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800143 log.info("Starting with {}/{} nodes cluster",
144 clusterService.getNodes().size(),
145 clusterConfig.getMembers().size());
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -0800146 }
147 } catch (InterruptedException e) {
148 log.info("Interrupted waiting for others", e);
149 }
150 }
Madan Jampani08822c42014-11-04 17:17:46 -0800151
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -0800152 final TcpCluster cluster;
153 synchronized (clusterConfig) {
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -0800154 // Create the cluster.
155 cluster = new TcpCluster(clusterConfig);
156 }
157 log.info("Starting cluster: {}", cluster);
158
Madan Jampani08822c42014-11-04 17:17:46 -0800159
160 StateMachine stateMachine = new DatabaseStateMachine();
Madan Jampani2ee20002014-11-06 20:06:12 -0800161 Log consensusLog = new MapDBLog(LOG_FILE_PREFIX + localNode.id(),
Yuta HIGUCHI361664e2014-11-06 17:28:47 -0800162 ClusterMessagingProtocol.SERIALIZER);
Madan Jampani08822c42014-11-04 17:17:46 -0800163
Madan Jampani9b19a822014-11-04 21:37:13 -0800164 copycat = new Copycat(stateMachine, consensusLog, cluster, copycatMessagingProtocol);
Madan Jampani08822c42014-11-04 17:17:46 -0800165 copycat.start();
166
Yuta HIGUCHIf8468442014-11-11 10:09:20 -0800167 client = new DatabaseClient(copycat);
Madan Jampani08822c42014-11-04 17:17:46 -0800168
169 log.info("Started.");
170 }
171
Yuta HIGUCHI657626e2014-11-04 20:54:58 -0800172 @Deactivate
Madan Jampani08822c42014-11-04 17:17:46 -0800173 public void deactivate() {
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800174 clusterService.removeListener(clusterEventListener);
Madan Jampani08822c42014-11-04 17:17:46 -0800175 copycat.stop();
Yuta HIGUCHI657626e2014-11-04 20:54:58 -0800176 log.info("Stopped.");
Madan Jampani08822c42014-11-04 17:17:46 -0800177 }
178
179 @Override
180 public boolean createTable(String name) {
181 return client.createTable(name);
182 }
183
184 @Override
185 public void dropTable(String name) {
186 client.dropTable(name);
187 }
188
189 @Override
190 public void dropAllTables() {
191 client.dropAllTables();
192 }
193
194 @Override
195 public List<String> listTables() {
196 return client.listTables();
197 }
198
199 @Override
Madan Jampani12390c12014-11-12 00:35:56 -0800200 public VersionedValue get(String tableName, String key) {
201 BatchReadRequest batchRequest = new BatchReadRequest.Builder().get(tableName, key).build();
202 ReadResult readResult = batchRead(batchRequest).getAsList().get(0);
203 if (readResult.status().equals(ReadStatus.OK)) {
204 return readResult.value();
Madan Jampani08822c42014-11-04 17:17:46 -0800205 }
Madan Jampani12390c12014-11-12 00:35:56 -0800206 throw new DatabaseException("get failed due to status: " + readResult.status());
Madan Jampani08822c42014-11-04 17:17:46 -0800207 }
208
209 @Override
Madan Jampani12390c12014-11-12 00:35:56 -0800210 public BatchReadResult batchRead(BatchReadRequest batchRequest) {
211 return new BatchReadResult(client.batchRead(batchRequest));
Yuta HIGUCHI361664e2014-11-06 17:28:47 -0800212 }
213
214 @Override
Madan Jampani12390c12014-11-12 00:35:56 -0800215 public BatchWriteResult batchWrite(BatchWriteRequest batchRequest) {
216 return new BatchWriteResult(client.batchWrite(batchRequest));
Madan Jampani08822c42014-11-04 17:17:46 -0800217 }
218
219 @Override
Madan Jampani12390c12014-11-12 00:35:56 -0800220 public VersionedValue put(String tableName, String key, byte[] value) {
221 BatchWriteRequest batchRequest = new BatchWriteRequest.Builder().put(tableName, key, value).build();
222 WriteResult writeResult = batchWrite(batchRequest).getAsList().get(0);
223 if (writeResult.status().equals(WriteStatus.OK)) {
224 return writeResult.previousValue();
Madan Jampani08822c42014-11-04 17:17:46 -0800225 }
Madan Jampani12390c12014-11-12 00:35:56 -0800226 throw new DatabaseException("put failed due to status: " + writeResult.status());
227 }
Madan Jampani08822c42014-11-04 17:17:46 -0800228
Madan Jampani12390c12014-11-12 00:35:56 -0800229 @Override
230 public boolean putIfAbsent(String tableName, String key, byte[] value) {
Madan Jampani44e6a542014-11-12 01:06:51 -0800231 BatchWriteRequest batchRequest = new BatchWriteRequest.Builder()
232 .putIfAbsent(tableName, key, value).build();
Madan Jampani12390c12014-11-12 00:35:56 -0800233 WriteResult writeResult = batchWrite(batchRequest).getAsList().get(0);
234 if (writeResult.status().equals(WriteStatus.OK)) {
235 return true;
236 } else if (writeResult.status().equals(WriteStatus.PRECONDITION_VIOLATION)) {
237 return false;
238 }
Madan Jampani44e6a542014-11-12 01:06:51 -0800239 throw new DatabaseException("putIfAbsent failed due to status: "
240 + writeResult.status());
Madan Jampani12390c12014-11-12 00:35:56 -0800241 }
242
243 @Override
244 public boolean putIfVersionMatches(String tableName, String key,
245 byte[] value, long version) {
Madan Jampani44e6a542014-11-12 01:06:51 -0800246 BatchWriteRequest batchRequest =
247 new BatchWriteRequest.Builder()
248 .putIfVersionMatches(tableName, key, value, version).build();
Madan Jampani12390c12014-11-12 00:35:56 -0800249 WriteResult writeResult = batchWrite(batchRequest).getAsList().get(0);
250 if (writeResult.status().equals(WriteStatus.OK)) {
251 return true;
252 } else if (writeResult.status().equals(WriteStatus.PRECONDITION_VIOLATION)) {
253 return false;
254 }
Madan Jampani44e6a542014-11-12 01:06:51 -0800255 throw new DatabaseException("putIfVersionMatches failed due to status: "
256 + writeResult.status());
Madan Jampani12390c12014-11-12 00:35:56 -0800257 }
258
259 @Override
260 public boolean putIfValueMatches(String tableName, String key,
261 byte[] oldValue, byte[] newValue) {
Madan Jampani44e6a542014-11-12 01:06:51 -0800262 BatchWriteRequest batchRequest = new BatchWriteRequest.Builder()
263 .putIfValueMatches(tableName, key, oldValue, newValue).build();
Madan Jampani12390c12014-11-12 00:35:56 -0800264 WriteResult writeResult = batchWrite(batchRequest).getAsList().get(0);
265 if (writeResult.status().equals(WriteStatus.OK)) {
266 return true;
267 } else if (writeResult.status().equals(WriteStatus.PRECONDITION_VIOLATION)) {
268 return false;
269 }
Madan Jampani44e6a542014-11-12 01:06:51 -0800270 throw new DatabaseException("putIfValueMatches failed due to status: "
271 + writeResult.status());
Madan Jampani12390c12014-11-12 00:35:56 -0800272 }
273
274 @Override
275 public VersionedValue remove(String tableName, String key) {
Madan Jampani44e6a542014-11-12 01:06:51 -0800276 BatchWriteRequest batchRequest = new BatchWriteRequest.Builder()
277 .remove(tableName, key).build();
Madan Jampani12390c12014-11-12 00:35:56 -0800278 WriteResult writeResult = batchWrite(batchRequest).getAsList().get(0);
279 if (writeResult.status().equals(WriteStatus.OK)) {
280 return writeResult.previousValue();
281 }
Madan Jampani44e6a542014-11-12 01:06:51 -0800282 throw new DatabaseException("remove failed due to status: "
283 + writeResult.status());
Madan Jampani12390c12014-11-12 00:35:56 -0800284 }
285
286 @Override
287 public boolean removeIfVersionMatches(String tableName, String key,
288 long version) {
Madan Jampani44e6a542014-11-12 01:06:51 -0800289 BatchWriteRequest batchRequest = new BatchWriteRequest.Builder()
290 .removeIfVersionMatches(tableName, key, version).build();
Madan Jampani12390c12014-11-12 00:35:56 -0800291 WriteResult writeResult = batchWrite(batchRequest).getAsList().get(0);
292 if (writeResult.status().equals(WriteStatus.OK)) {
293 return true;
294 } else if (writeResult.status().equals(WriteStatus.PRECONDITION_VIOLATION)) {
295 return false;
296 }
Madan Jampani44e6a542014-11-12 01:06:51 -0800297 throw new DatabaseException("removeIfVersionMatches failed due to status: "
298 + writeResult.status());
Madan Jampani12390c12014-11-12 00:35:56 -0800299 }
300
301 @Override
302 public boolean removeIfValueMatches(String tableName, String key,
303 byte[] value) {
Madan Jampani44e6a542014-11-12 01:06:51 -0800304 BatchWriteRequest batchRequest = new BatchWriteRequest.Builder()
305 .removeIfValueMatches(tableName, key, value).build();
Madan Jampani12390c12014-11-12 00:35:56 -0800306 WriteResult writeResult = batchWrite(batchRequest).getAsList().get(0);
307 if (writeResult.status().equals(WriteStatus.OK)) {
308 return true;
309 } else if (writeResult.status().equals(WriteStatus.PRECONDITION_VIOLATION)) {
310 return false;
311 }
Madan Jampani44e6a542014-11-12 01:06:51 -0800312 throw new DatabaseException("removeIfValueMatches failed due to status: "
313 + writeResult.status());
Madan Jampani12390c12014-11-12 00:35:56 -0800314 }
315
316 @Override
317 public void addMember(final ControllerNode node) {
318 final TcpMember tcpMember = new TcpMember(node.ip().toString(),
319 node.tcpPort());
320 log.info("{} was added to the cluster", tcpMember);
321 synchronized (clusterConfig) {
322 clusterConfig.addRemoteMember(tcpMember);
323 }
Madan Jampani08822c42014-11-04 17:17:46 -0800324 }
325
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800326 private final class InternalClusterEventListener
Madan Jampani12390c12014-11-12 00:35:56 -0800327 implements ClusterEventListener {
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800328
329 @Override
330 public void event(ClusterEvent event) {
331 // TODO: Not every node should be part of the consensus ring.
332
333 final ControllerNode node = event.subject();
334 final TcpMember tcpMember = new TcpMember(node.ip().toString(),
Madan Jampani12390c12014-11-12 00:35:56 -0800335 node.tcpPort());
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800336
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800337 switch (event.type()) {
338 case INSTANCE_ACTIVATED:
339 case INSTANCE_ADDED:
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800340 if (autoAddMember) {
341 synchronized (clusterConfig) {
342 if (!clusterConfig.getMembers().contains(tcpMember)) {
343 log.info("{} was automatically added to the cluster", tcpMember);
344 clusterConfig.addRemoteMember(tcpMember);
345 }
346 }
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -0800347 }
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800348 break;
349 case INSTANCE_DEACTIVATED:
350 case INSTANCE_REMOVED:
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800351 if (autoAddMember) {
352 Set<DefaultControllerNode> members
Madan Jampani12390c12014-11-12 00:35:56 -0800353 = tabletMembers.getOrDefault(DEFAULT_TABLET,
354 Collections.emptySet());
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800355 // remove only if not the initial members
356 if (!members.contains(node)) {
357 synchronized (clusterConfig) {
358 if (clusterConfig.getMembers().contains(tcpMember)) {
359 log.info("{} was automatically removed from the cluster", tcpMember);
360 clusterConfig.removeRemoteMember(tcpMember);
361 }
362 }
363 }
364 }
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800365 break;
366 default:
367 break;
368 }
Yuta HIGUCHI79a1e5e2014-11-05 17:42:01 -0800369 if (copycat != null) {
370 log.debug("Current cluster: {}", copycat.cluster());
371 }
372 clusterEventLatch.countDown();
Yuta HIGUCHI5027b6b2014-11-05 16:23:26 -0800373 }
374
375 }
376
Yuta HIGUCHI60731cb2014-11-11 01:34:46 -0800377 @Override
378 public void removeMember(final ControllerNode node) {
379 final TcpMember tcpMember = new TcpMember(node.ip().toString(),
380 node.tcpPort());
381 log.info("{} was removed from the cluster", tcpMember);
382 synchronized (clusterConfig) {
383 clusterConfig.removeRemoteMember(tcpMember);
384 }
385 }
386
387 @Override
388 public Collection<ControllerNode> listMembers() {
389 if (copycat == null) {
390 return ImmutableList.of();
391 }
392 Set<ControllerNode> members = new HashSet<>();
393 for (Member member : copycat.cluster().members()) {
394 if (member instanceof TcpMember) {
395 final TcpMember tcpMember = (TcpMember) member;
396 // TODO assuming tcpMember#host to be IP address,
397 // but if not lookup DNS, etc. first
398 IpAddress ip = IpAddress.valueOf(tcpMember.host());
399 int tcpPort = tcpMember.port();
400 NodeId id = getNodeIdFromIp(ip, tcpPort);
401 if (id == null) {
402 log.info("No NodeId found for {}:{}", ip, tcpPort);
403 continue;
404 }
405 members.add(new DefaultControllerNode(id, ip, tcpPort));
406 }
407 }
408 return members;
409 }
410
411 private NodeId getNodeIdFromIp(IpAddress ip, int tcpPort) {
412 for (ControllerNode node : clusterService.getNodes()) {
413 if (node.ip().equals(ip) &&
414 node.tcpPort() == tcpPort) {
415 return node.id();
416 }
417 }
418 return null;
419 }
Madan Jampani44e6a542014-11-12 01:06:51 -0800420}