Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 1 | /* |
Brian O'Connor | a09fe5b | 2017-08-03 21:12:30 -0700 | [diff] [blame] | 2 | * Copyright 2015-present Open Networking Foundation |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | package org.onosproject.cfg.impl; |
| 17 | |
| 18 | import com.google.common.collect.ImmutableSet; |
| 19 | import com.google.common.collect.Maps; |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 20 | import org.onlab.util.AbstractAccumulator; |
| 21 | import org.onlab.util.Accumulator; |
| 22 | import org.onlab.util.SharedExecutors; |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 23 | import org.onosproject.cfg.ComponentConfigEvent; |
| 24 | import org.onosproject.cfg.ComponentConfigService; |
| 25 | import org.onosproject.cfg.ComponentConfigStore; |
| 26 | import org.onosproject.cfg.ComponentConfigStoreDelegate; |
| 27 | import org.onosproject.cfg.ConfigProperty; |
| 28 | import org.osgi.service.cm.Configuration; |
| 29 | import org.osgi.service.cm.ConfigurationAdmin; |
Ray Milkey | d84f89b | 2018-08-17 14:54:17 -0700 | [diff] [blame] | 30 | import org.osgi.service.component.annotations.Activate; |
| 31 | import org.osgi.service.component.annotations.Component; |
| 32 | import org.osgi.service.component.annotations.Deactivate; |
| 33 | import org.osgi.service.component.annotations.Reference; |
| 34 | import org.osgi.service.component.annotations.ReferenceCardinality; |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 35 | import org.slf4j.Logger; |
| 36 | |
| 37 | import java.io.IOException; |
| 38 | import java.io.InputStream; |
| 39 | import java.util.Dictionary; |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 40 | import java.util.HashSet; |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 41 | import java.util.Hashtable; |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 42 | import java.util.List; |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 43 | import java.util.Map; |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 44 | import java.util.Objects; |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 45 | import java.util.Set; |
| 46 | |
| 47 | import static com.google.common.base.Preconditions.checkArgument; |
| 48 | import static com.google.common.base.Preconditions.checkNotNull; |
Changhoon Yoon | 541ef71 | 2015-05-23 17:18:34 +0900 | [diff] [blame] | 49 | import static org.onosproject.security.AppGuard.checkPermission; |
Ray Milkey | d84f89b | 2018-08-17 14:54:17 -0700 | [diff] [blame] | 50 | import static org.onosproject.security.AppPermission.Type.CONFIG_READ; |
| 51 | import static org.onosproject.security.AppPermission.Type.CONFIG_WRITE; |
Thomas Vachuska | 92af89f | 2015-06-22 15:16:23 -0700 | [diff] [blame] | 52 | import static org.slf4j.LoggerFactory.getLogger; |
Changhoon Yoon | 541ef71 | 2015-05-23 17:18:34 +0900 | [diff] [blame] | 53 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 54 | |
| 55 | /** |
| 56 | * Implementation of the centralized component configuration service. |
| 57 | */ |
Ray Milkey | d84f89b | 2018-08-17 14:54:17 -0700 | [diff] [blame] | 58 | @Component(immediate = true, service = ComponentConfigService.class) |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 59 | public class ComponentConfigManager implements ComponentConfigService { |
| 60 | |
| 61 | private static final String COMPONENT_NULL = "Component name cannot be null"; |
| 62 | private static final String PROPERTY_NULL = "Property name cannot be null"; |
Brian O'Connor | 57e83e8 | 2015-09-22 15:45:37 -0700 | [diff] [blame] | 63 | private static final String COMPONENT_MISSING = "Component %s is not registered"; |
| 64 | private static final String PROPERTY_MISSING = "Property %s does not exist for %s"; |
| 65 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 66 | |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 67 | //Symbolic constants for use with the accumulator |
| 68 | private static final int MAX_ITEMS = 100; |
| 69 | private static final int MAX_BATCH_MILLIS = 1000; |
| 70 | private static final int MAX_IDLE_MILLIS = 250; |
| 71 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 72 | private static final String RESOURCE_EXT = ".cfgdef"; |
| 73 | |
| 74 | private final Logger log = getLogger(getClass()); |
| 75 | |
| 76 | private final ComponentConfigStoreDelegate delegate = new InternalStoreDelegate(); |
Thomas Vachuska | 92af89f | 2015-06-22 15:16:23 -0700 | [diff] [blame] | 77 | private final InternalAccumulator accumulator = new InternalAccumulator(); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 78 | |
Ray Milkey | d84f89b | 2018-08-17 14:54:17 -0700 | [diff] [blame] | 79 | @Reference(cardinality = ReferenceCardinality.MANDATORY) |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 80 | protected ComponentConfigStore store; |
| 81 | |
Ray Milkey | d84f89b | 2018-08-17 14:54:17 -0700 | [diff] [blame] | 82 | @Reference(cardinality = ReferenceCardinality.MANDATORY) |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 83 | protected ConfigurationAdmin cfgAdmin; |
| 84 | |
| 85 | // Locally maintained catalog of definitions. |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 86 | private final Map<String, Map<String, ConfigProperty>> properties = |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 87 | Maps.newConcurrentMap(); |
| 88 | |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 89 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 90 | @Activate |
| 91 | public void activate() { |
| 92 | store.setDelegate(delegate); |
| 93 | log.info("Started"); |
| 94 | } |
| 95 | |
| 96 | @Deactivate |
| 97 | public void deactivate() { |
| 98 | store.unsetDelegate(delegate); |
| 99 | log.info("Stopped"); |
| 100 | } |
| 101 | |
| 102 | @Override |
| 103 | public Set<String> getComponentNames() { |
Changhoon Yoon | b856b81 | 2015-08-10 03:47:19 +0900 | [diff] [blame] | 104 | checkPermission(CONFIG_READ); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 105 | return ImmutableSet.copyOf(properties.keySet()); |
| 106 | } |
| 107 | |
| 108 | @Override |
| 109 | public void registerProperties(Class<?> componentClass) { |
Changhoon Yoon | b856b81 | 2015-08-10 03:47:19 +0900 | [diff] [blame] | 110 | checkPermission(CONFIG_WRITE); |
Changhoon Yoon | 541ef71 | 2015-05-23 17:18:34 +0900 | [diff] [blame] | 111 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 112 | String componentName = componentClass.getName(); |
| 113 | String resourceName = componentClass.getSimpleName() + RESOURCE_EXT; |
| 114 | try (InputStream ris = componentClass.getResourceAsStream(resourceName)) { |
Thomas Vachuska | bef430b | 2018-10-22 10:55:47 -0700 | [diff] [blame] | 115 | // FIXME: Eliminate the following soft-fail after property refactoring is complete. |
| 116 | if (ris == null) { |
| 117 | log.info("Property definitions not found at resource {}; please fix this", resourceName); |
| 118 | return; |
| 119 | } |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 120 | checkArgument(ris != null, "Property definitions not found at resource %s", |
| 121 | resourceName); |
| 122 | |
| 123 | // Read the definitions |
| 124 | Set<ConfigProperty> defs = ConfigPropertyDefinitions.read(ris); |
| 125 | |
| 126 | // Produce a new map of the properties and register it. |
| 127 | Map<String, ConfigProperty> map = Maps.newConcurrentMap(); |
| 128 | defs.forEach(p -> map.put(p.name(), p)); |
| 129 | |
| 130 | properties.put(componentName, map); |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 131 | loadExistingValues(componentName, map); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 132 | } catch (IOException e) { |
| 133 | log.error("Unable to read property definitions from resource " + resourceName, e); |
| 134 | } |
| 135 | } |
| 136 | |
| 137 | @Override |
| 138 | public void unregisterProperties(Class<?> componentClass, boolean clear) { |
Changhoon Yoon | b856b81 | 2015-08-10 03:47:19 +0900 | [diff] [blame] | 139 | checkPermission(CONFIG_WRITE); |
Changhoon Yoon | 541ef71 | 2015-05-23 17:18:34 +0900 | [diff] [blame] | 140 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 141 | String componentName = componentClass.getName(); |
| 142 | checkNotNull(componentName, COMPONENT_NULL); |
| 143 | Map<String, ConfigProperty> cps = properties.remove(componentName); |
Thomas Vachuska | fc52fec | 2015-05-18 19:13:56 -0700 | [diff] [blame] | 144 | if (clear && cps != null) { |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 145 | cps.keySet().forEach(name -> store.unsetProperty(componentName, name)); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 146 | clearExistingValues(componentName); |
| 147 | } |
| 148 | } |
| 149 | |
| 150 | // Clears any existing values that may have been set. |
| 151 | private void clearExistingValues(String componentName) { |
| 152 | triggerUpdate(componentName); |
| 153 | } |
| 154 | |
| 155 | @Override |
| 156 | public Set<ConfigProperty> getProperties(String componentName) { |
Changhoon Yoon | b856b81 | 2015-08-10 03:47:19 +0900 | [diff] [blame] | 157 | checkPermission(CONFIG_READ); |
Changhoon Yoon | 541ef71 | 2015-05-23 17:18:34 +0900 | [diff] [blame] | 158 | |
Brian O'Connor | 85c2926 | 2015-03-10 20:53:43 -0700 | [diff] [blame] | 159 | Map<String, ConfigProperty> map = properties.get(componentName); |
| 160 | return map != null ? ImmutableSet.copyOf(map.values()) : null; |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 161 | } |
| 162 | |
| 163 | @Override |
| 164 | public void setProperty(String componentName, String name, String value) { |
Changhoon Yoon | b856b81 | 2015-08-10 03:47:19 +0900 | [diff] [blame] | 165 | checkPermission(CONFIG_WRITE); |
Changhoon Yoon | 541ef71 | 2015-05-23 17:18:34 +0900 | [diff] [blame] | 166 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 167 | checkNotNull(componentName, COMPONENT_NULL); |
| 168 | checkNotNull(name, PROPERTY_NULL); |
Brian O'Connor | 57e83e8 | 2015-09-22 15:45:37 -0700 | [diff] [blame] | 169 | |
| 170 | checkArgument(properties.containsKey(componentName), |
| 171 | COMPONENT_MISSING, componentName); |
| 172 | checkArgument(properties.get(componentName).containsKey(name), |
| 173 | PROPERTY_MISSING, name, componentName); |
sivachidambaram subramanian | 8c9a701 | 2017-04-26 14:59:02 +0530 | [diff] [blame] | 174 | checkValidity(componentName, name, value); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 175 | store.setProperty(componentName, name, value); |
| 176 | } |
| 177 | |
| 178 | @Override |
andrea | dd106a6 | 2015-10-02 13:39:48 -0700 | [diff] [blame] | 179 | public void preSetProperty(String componentName, String name, String value) { |
andrea | dd106a6 | 2015-10-02 13:39:48 -0700 | [diff] [blame] | 180 | checkPermission(CONFIG_WRITE); |
| 181 | |
| 182 | checkNotNull(componentName, COMPONENT_NULL); |
| 183 | checkNotNull(name, PROPERTY_NULL); |
sivachidambaram subramanian | 8c9a701 | 2017-04-26 14:59:02 +0530 | [diff] [blame] | 184 | checkValidity(componentName, name, value); |
andrea | dd106a6 | 2015-10-02 13:39:48 -0700 | [diff] [blame] | 185 | store.setProperty(componentName, name, value); |
| 186 | } |
| 187 | |
| 188 | @Override |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 189 | public void unsetProperty(String componentName, String name) { |
Changhoon Yoon | b856b81 | 2015-08-10 03:47:19 +0900 | [diff] [blame] | 190 | checkPermission(CONFIG_WRITE); |
Changhoon Yoon | 541ef71 | 2015-05-23 17:18:34 +0900 | [diff] [blame] | 191 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 192 | checkNotNull(componentName, COMPONENT_NULL); |
| 193 | checkNotNull(name, PROPERTY_NULL); |
Brian O'Connor | 57e83e8 | 2015-09-22 15:45:37 -0700 | [diff] [blame] | 194 | |
| 195 | checkArgument(properties.containsKey(componentName), |
| 196 | COMPONENT_MISSING, componentName); |
| 197 | checkArgument(properties.get(componentName).containsKey(name), |
| 198 | PROPERTY_MISSING, name, componentName); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 199 | store.unsetProperty(componentName, name); |
| 200 | } |
| 201 | |
psneha | f31ac6f | 2018-08-02 01:16:46 -0400 | [diff] [blame] | 202 | @Override |
| 203 | public ConfigProperty getProperty(String componentName, String attribute) { |
| 204 | checkPermission(CONFIG_READ); |
| 205 | |
| 206 | Map<String, ConfigProperty> map = properties.get(componentName); |
| 207 | if (map != null) { |
| 208 | return map.get(attribute); |
| 209 | } else { |
| 210 | log.error("Attribute {} not present in component {}", attribute, componentName); |
| 211 | return null; |
| 212 | } |
| 213 | } |
| 214 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 215 | private class InternalStoreDelegate implements ComponentConfigStoreDelegate { |
| 216 | |
| 217 | @Override |
| 218 | public void notify(ComponentConfigEvent event) { |
| 219 | String componentName = event.subject(); |
| 220 | String name = event.name(); |
| 221 | String value = event.value(); |
| 222 | |
| 223 | switch (event.type()) { |
| 224 | case PROPERTY_SET: |
| 225 | set(componentName, name, value); |
| 226 | break; |
| 227 | case PROPERTY_UNSET: |
| 228 | reset(componentName, name); |
| 229 | break; |
| 230 | default: |
| 231 | break; |
| 232 | } |
| 233 | } |
| 234 | } |
| 235 | |
Thomas Vachuska | 92af89f | 2015-06-22 15:16:23 -0700 | [diff] [blame] | 236 | // Buffers multiple subsequent configuration updates into one notification. |
| 237 | private class InternalAccumulator extends AbstractAccumulator<String> |
| 238 | implements Accumulator<String> { |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 239 | |
Thomas Vachuska | 92af89f | 2015-06-22 15:16:23 -0700 | [diff] [blame] | 240 | protected InternalAccumulator() { |
| 241 | super(SharedExecutors.getTimer(), MAX_ITEMS, MAX_BATCH_MILLIS, MAX_IDLE_MILLIS); |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 242 | } |
| 243 | |
| 244 | @Override |
Thomas Vachuska | 92af89f | 2015-06-22 15:16:23 -0700 | [diff] [blame] | 245 | public void processItems(List<String> items) { |
| 246 | // Conversion to set removes duplicates |
| 247 | Set<String> componentSet = new HashSet<>(items); |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 248 | componentSet.forEach(ComponentConfigManager.this::triggerUpdate); |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 249 | } |
| 250 | } |
| 251 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 252 | // Locates the property in the component map and replaces it with an |
| 253 | // updated copy. |
| 254 | private void set(String componentName, String name, String value) { |
| 255 | Map<String, ConfigProperty> map = properties.get(componentName); |
| 256 | if (map != null) { |
| 257 | ConfigProperty prop = map.get(name); |
| 258 | if (prop != null) { |
| 259 | map.put(name, ConfigProperty.setProperty(prop, value)); |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 260 | accumulator.add(componentName); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 261 | return; |
| 262 | } |
| 263 | } |
Thomas Vachuska | 4b32fcb | 2018-02-20 12:35:19 -0800 | [diff] [blame] | 264 | |
| 265 | // If definition doesn't exist in local catalog, cache the property. |
| 266 | preSet(componentName, name, value); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 267 | } |
| 268 | |
| 269 | // Locates the property in the component map and replaces it with an |
| 270 | // reset copy. |
| 271 | private void reset(String componentName, String name) { |
| 272 | Map<String, ConfigProperty> map = properties.get(componentName); |
| 273 | if (map != null) { |
| 274 | ConfigProperty prop = map.get(name); |
| 275 | if (prop != null) { |
| 276 | map.put(name, ConfigProperty.resetProperty(prop)); |
Aaron Kruglikov | 6685521 | 2015-06-22 12:29:02 -0700 | [diff] [blame] | 277 | accumulator.add(componentName); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 278 | return; |
| 279 | } |
Thomas Vachuska | db320ab | 2015-04-22 09:03:33 -0700 | [diff] [blame] | 280 | log.warn("Unable to reset non-existent property {} for component {}", |
| 281 | name, componentName); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 282 | } |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 283 | } |
| 284 | |
Thomas Vachuska | 4b32fcb | 2018-02-20 12:35:19 -0800 | [diff] [blame] | 285 | // Stores non-existent property so that loadExistingValues() can load in future. |
| 286 | private void preSet(String componentName, String name, String value) { |
| 287 | try { |
| 288 | Configuration config = cfgAdmin.getConfiguration(componentName, null); |
| 289 | Dictionary<String, Object> props = config.getProperties(); |
| 290 | if (props == null) { |
| 291 | props = new Hashtable<>(); |
| 292 | } |
| 293 | props.put(name, value); |
| 294 | config.update(props); |
| 295 | } catch (IOException e) { |
| 296 | log.error("Failed to preset configuration for {}", componentName); |
| 297 | } |
| 298 | } |
| 299 | |
sivachidambaram subramanian | 8c9a701 | 2017-04-26 14:59:02 +0530 | [diff] [blame] | 300 | // Checks whether the value of the specified configuration property is a valid one or not. |
| 301 | private void checkValidity(String componentName, String name, String newValue) { |
| 302 | Map<String, ConfigProperty> map = properties.get(componentName); |
| 303 | if (map == null) { |
| 304 | return; |
| 305 | } |
| 306 | ConfigProperty prop = map.get(name); |
| 307 | ConfigProperty.Type type = prop.type(); |
| 308 | try { |
| 309 | switch (type) { |
| 310 | case INTEGER: |
| 311 | Integer.parseInt(newValue); |
| 312 | break; |
| 313 | case LONG: |
| 314 | Long.parseLong(newValue); |
| 315 | break; |
| 316 | case FLOAT: |
| 317 | Float.parseFloat(newValue); |
| 318 | break; |
| 319 | case DOUBLE: |
| 320 | Double.parseDouble(newValue); |
| 321 | break; |
| 322 | case BOOLEAN: |
| 323 | if (!((newValue != null) && (newValue.equalsIgnoreCase("true") || |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 324 | newValue.equalsIgnoreCase("false")))) { |
sivachidambaram subramanian | 8c9a701 | 2017-04-26 14:59:02 +0530 | [diff] [blame] | 325 | throw new IllegalArgumentException("Invalid " + type + " value"); |
| 326 | } |
| 327 | break; |
| 328 | case STRING: |
| 329 | case BYTE: |
| 330 | //do nothing |
| 331 | break; |
| 332 | default: |
| 333 | log.warn("Not a valid config property type"); |
| 334 | break; |
| 335 | |
| 336 | } |
| 337 | } catch (NumberFormatException e) { |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 338 | throw new NumberFormatException("Invalid " + type + " value"); |
sivachidambaram subramanian | 8c9a701 | 2017-04-26 14:59:02 +0530 | [diff] [blame] | 339 | } |
| 340 | } |
| 341 | |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 342 | // Loads existing property values that may have been learned from other |
| 343 | // nodes in the cluster before the local property registration. |
| 344 | private void loadExistingValues(String componentName, |
| 345 | Map<String, ConfigProperty> map) { |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 346 | try { |
Thomas Vachuska | 6519e6f | 2015-03-11 02:29:31 -0700 | [diff] [blame] | 347 | Configuration cfg = cfgAdmin.getConfiguration(componentName, null); |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 348 | Dictionary<String, Object> localProperties = cfg.getProperties(); |
| 349 | |
| 350 | // Iterate over all registered config properties... |
| 351 | for (ConfigProperty p : ImmutableSet.copyOf(map.values())) { |
| 352 | String name = p.name(); |
| 353 | String globalValue = store.getProperty(componentName, name); |
| 354 | String localValue = localProperties != null ? (String) localProperties.get(name) : null; |
Thomas Vachuska | 611f466 | 2018-02-27 11:30:09 -0800 | [diff] [blame] | 355 | |
| 356 | log.debug("Processing {} property {}; global {}; local {}", |
| 357 | componentName, name, globalValue, localValue); |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 358 | try { |
Thomas Vachuska | 611f466 | 2018-02-27 11:30:09 -0800 | [diff] [blame] | 359 | // 1) If the global value is the same as default, or |
| 360 | // 2) if it is not set explicitly, but the local value is |
| 361 | // not the same as the default, reset local value to default. |
| 362 | if (Objects.equals(globalValue, p.defaultValue()) || |
| 363 | (globalValue == null && |
| 364 | !Objects.equals(localValue, p.defaultValue()))) { |
| 365 | log.debug("Resetting {} property {}; value same as default", |
| 366 | componentName, name); |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 367 | reset(componentName, name); |
| 368 | |
| 369 | } else if (!Objects.equals(globalValue, localValue)) { |
Thomas Vachuska | 611f466 | 2018-02-27 11:30:09 -0800 | [diff] [blame] | 370 | // If the local value is different from global value |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 371 | // validate the global value and apply it locally. |
Thomas Vachuska | 611f466 | 2018-02-27 11:30:09 -0800 | [diff] [blame] | 372 | log.debug("Setting {} property {} to {}", |
| 373 | componentName, name, globalValue); |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 374 | checkValidity(componentName, name, globalValue); |
| 375 | set(componentName, name, globalValue); |
Thomas Vachuska | 611f466 | 2018-02-27 11:30:09 -0800 | [diff] [blame] | 376 | |
| 377 | } else { |
| 378 | // Otherwise, simply update the registered property |
| 379 | // with the global value. |
| 380 | log.debug("Syncing {} property {} to {}", |
| 381 | componentName, name, globalValue); |
| 382 | map.put(name, ConfigProperty.setProperty(p, globalValue)); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 383 | } |
Thomas Vachuska | 9f6bd52 | 2018-02-12 15:53:01 -0800 | [diff] [blame] | 384 | } catch (IllegalArgumentException e) { |
| 385 | log.warn("Value {} is not a valid {}; using default", |
| 386 | globalValue, p.type()); |
| 387 | reset(componentName, name); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 388 | } |
| 389 | } |
| 390 | } catch (IOException e) { |
| 391 | log.error("Unable to get configuration for " + componentName, e); |
| 392 | } |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 393 | } |
| 394 | |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 395 | private void triggerUpdate(String componentName) { |
| 396 | try { |
Thomas Vachuska | 6519e6f | 2015-03-11 02:29:31 -0700 | [diff] [blame] | 397 | Configuration cfg = cfgAdmin.getConfiguration(componentName, null); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 398 | Map<String, ConfigProperty> map = properties.get(componentName); |
Ray Milkey | 7981a32 | 2018-08-16 14:55:46 -0700 | [diff] [blame] | 399 | if (map == null) { |
| 400 | // Prevent NPE if the component isn't there |
| 401 | log.warn("Component not found for " + componentName); |
| 402 | return; |
| 403 | } |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 404 | Dictionary<String, Object> props = new Hashtable<>(); |
Thomas Vachuska | 611f466 | 2018-02-27 11:30:09 -0800 | [diff] [blame] | 405 | map.values().stream().filter(p -> p.value() != null) |
| 406 | .forEach(p -> props.put(p.name(), p.value())); |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 407 | cfg.update(props); |
| 408 | } catch (IOException e) { |
| 409 | log.warn("Unable to update configuration for " + componentName, e); |
| 410 | } |
| 411 | } |
Thomas Vachuska | 6d697f1 | 2015-03-08 20:59:50 -0700 | [diff] [blame] | 412 | } |