commit f2710c7cb6e086c450d575b19fe24ab203d462c3
author HIGUCHI Yuta <y-higuchi@ak.jp.nec.com> Tue Sep 22 15:22:06 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Wed Sep 23 00:31:47 2015 +0000
tree dd3d42479a92a7dad6cd0bc1a2fd145fddd98d84
parent 924cda424c9531b12fd6f7060e8a327fab1cb2b6

bugfix: equals comparing a field with itself

Change-Id: I02df9a7ca3788bf736edb89e39215992e2d6c375

utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrGroup.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrGroup.java b/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrGroup.java
index 891a019..be4ab19 100644
--- a/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrGroup.java
+++ b/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrGroup.java
@@ -241,7 +241,7 @@
             return false;
         }
         final PIMAddrGroup other = (PIMAddrGroup) obj;
-        if (this.family != this.family) {
+        if (this.family != other.family) {
             return false;
         }
 

utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrSource.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrSource.java b/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrSource.java
index 2d4a781..2152640 100644
--- a/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrSource.java
+++ b/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrSource.java
@@ -265,7 +265,7 @@
             return false;
         }
         final PIMAddrSource other = (PIMAddrSource) obj;
-        if (this.family != this.family) {
+        if (this.family != other.family) {
             return false;
         }
 

utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrUnicast.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrUnicast.java b/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrUnicast.java
index 0c2d676..a6ba389 100644
--- a/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrUnicast.java
+++ b/utils/misc/src/main/java/org/onlab/packet/pim/PIMAddrUnicast.java
@@ -166,7 +166,7 @@
             return false;
         }
         final PIMAddrUnicast other = (PIMAddrUnicast) obj;
-        if (this.family != this.family) {
+        if (this.family != other.family) {
             return false;
         }