commit e853602a412368ac9e95d1101fdbdf60a65317b4
author Mahesh Raju-Huawei <mahesh.somalaraju@huawei.com> Wed May 18 20:03:43 2016 +0530
committer Gerrit Code Review <gerrit@onlab.us> Wed May 18 21:02:09 2016 +0000
tree 42b98ec13c98d9f400be599a2534cb7fbf2e529a
parent 36afa1ba0354d35efb12160d31c44eec847f9db4

[Code Review] PCEP Report message min length should be 18 & PCE web java doc

Change-Id: I62046aeed2e75b666d85dfedbc7b1c1ba9ad9570

apps/pce/pceweb/src/main/java/org/onosproject/pceweb/PceWebLink.java

diff --git a/apps/pce/pceweb/src/main/java/org/onosproject/pceweb/PceWebLink.java b/apps/pce/pceweb/src/main/java/org/onosproject/pceweb/PceWebLink.java
index 733e4c5..0a3f4a1 100644
--- a/apps/pce/pceweb/src/main/java/org/onosproject/pceweb/PceWebLink.java
+++ b/apps/pce/pceweb/src/main/java/org/onosproject/pceweb/PceWebLink.java
@@ -31,14 +31,20 @@
 
     private boolean primary;
     private boolean secondary;
+
     /**
-     * Initialize the Link key attributes.
+     * Initialize the Link and key attributes.
+     * @param key the link key identifier
+     * @param link the link to be highlighted.
      */
     public PceWebLink(LinkKey key, Link link) {
         super(key, link);
     }
-    /**
+
+     /**
      * Highlight the color of given selected links.
+     * @param selectedLinks the primary links
+     * @param allLinks the secondary links
      */
     public void computeHilight(Set<Link> selectedLinks, Set<Link> allLinks) {
         primary = selectedLinks.contains(this.one()) ||

protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepReportMsgVer1.java

diff --git a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepReportMsgVer1.java b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepReportMsgVer1.java
index 93d699d..757dd1c 100644
--- a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepReportMsgVer1.java
+++ b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepReportMsgVer1.java
@@ -65,8 +65,8 @@
     protected static final Logger log = LoggerFactory.getLogger(PcepReportMsgVer1.class);
 
     public static final byte PACKET_VERSION = 1;
-    //PACKET_MINIMUM_LENGTH = CommonHeaderLen(4)+LspObjMinLen(8)+EroObjMinLen(12)
-    public static final int PACKET_MINIMUM_LENGTH = 24;
+    //PACKET_MINIMUM_LENGTH = CommonHeaderLen(4)+LspObjMinLen(8)+EroObjMinLen(4)
+    public static final int PACKET_MINIMUM_LENGTH = 16;
     public static final PcepType MSG_TYPE = PcepType.REPORT;
     public static final byte REPORT_OBJ_TYPE = 1;
     //Optional TLV