commit e6a9754787377b1a3fd264451aa4fca5763c15d4
author Carmelo Cascone <carmelo@opennetworking.org> Wed Jun 20 16:48:00 2018 +0200
committer Carmelo Cascone <carmelo@opennetworking.org> Wed Jun 20 20:44:46 2018 +0000
tree 602270fe2664f0d8cf3eca0c8ddd838417188a6e
parent 137f27f0e7db91f1b159790dbc834856b3aa64b7

Better logging when configuring the FlowRuleManager

Change-Id: I7da22b1bf796a7199acc5a55c21f6a5334f312d4

core/net/src/main/java/org/onosproject/net/flow/impl/FlowRuleManager.java

diff --git a/core/net/src/main/java/org/onosproject/net/flow/impl/FlowRuleManager.java b/core/net/src/main/java/org/onosproject/net/flow/impl/FlowRuleManager.java
index 5047841..56a54e4 100644
--- a/core/net/src/main/java/org/onosproject/net/flow/impl/FlowRuleManager.java
+++ b/core/net/src/main/java/org/onosproject/net/flow/impl/FlowRuleManager.java
@@ -218,10 +218,20 @@
         }
 
         String s = get(properties, "fallbackFlowPollFrequency");
-        try {
-            fallbackFlowPollFrequency = isNullOrEmpty(s) ? DEFAULT_POLL_FREQUENCY : Integer.parseInt(s);
-        } catch (NumberFormatException e) {
-            fallbackFlowPollFrequency = DEFAULT_POLL_FREQUENCY;
+        if (isNullOrEmpty(s)) {
+            log.info("fallbackFlowPollFrequency is not configured, " +
+                             "using current value of {} seconds",
+                     fallbackFlowPollFrequency);
+        } else {
+            try {
+                fallbackFlowPollFrequency = Integer.parseInt(s);
+                log.info("Configured. FallbackFlowPollFrequency is {} seconds",
+                         fallbackFlowPollFrequency);
+            } catch (NumberFormatException e) {
+                log.warn("Configured fallbackFlowPollFrequency value '{}' " +
+                                 "is not a number, using current value of {} seconds",
+                         fallbackFlowPollFrequency);
+            }
         }
     }