commit e4da4a07b4831e53f0238bf863e1b2a33747f43a
author kdarapu <k.darapu@partner.samsung.com> Wed Jan 04 15:00:14 2017 +0530
committer Satishk-Huawei <satishk@huawei.com> Wed Jan 04 11:04:38 2017 +0000
tree b9c6c630251c540bfa496aca23cebd38b6bafc46
parent 7076e41483ee7ab27caa30a752a8a1e7817ffd87

Byte array comparison always return true for Objects.equal

Change-Id: Ib3fa05b7ba8c00cfab347dfc9d7ddc5f79798b37

protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa10.java

diff --git a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa10.java b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa10.java
index df9c8f5..ee358b9 100644
--- a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa10.java
+++ b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa10.java
@@ -30,6 +30,7 @@
 import org.onosproject.ospf.protocol.util.OspfParameters;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 
 /**
@@ -192,7 +193,7 @@
         }
         OpaqueLsa10 that = (OpaqueLsa10) o;
         return Objects.equal(topLevelValues, that.topLevelValues) &&
-                Objects.equal(opaqueInfo, that.opaqueInfo);
+                Arrays.equals(opaqueInfo, that.opaqueInfo);
     }
 
     @Override

protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa11.java

diff --git a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa11.java b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa11.java
index 3f5d56a..9c1f7bb 100644
--- a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa11.java
+++ b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa11.java
@@ -18,6 +18,9 @@
 import com.google.common.base.MoreObjects;
 import com.google.common.base.Objects;
 import com.google.common.primitives.Bytes;
+
+import java.util.Arrays;
+
 import org.jboss.netty.buffer.ChannelBuffer;
 import org.onosproject.ospf.controller.OspfLsaType;
 import org.onosproject.ospf.protocol.lsa.OpaqueLsaHeader;
@@ -106,7 +109,7 @@
             return false;
         }
         OpaqueLsa11 that = (OpaqueLsa11) o;
-        return Objects.equal(opaqueInfo, that.opaqueInfo);
+        return Arrays.equals(opaqueInfo, that.opaqueInfo);
     }
 
     @Override

protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa9.java

diff --git a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa9.java b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa9.java
index 5b60684..4c18237 100644
--- a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa9.java
+++ b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa9.java
@@ -18,6 +18,9 @@
 import com.google.common.base.MoreObjects;
 import com.google.common.base.Objects;
 import com.google.common.primitives.Bytes;
+
+import java.util.Arrays;
+
 import org.jboss.netty.buffer.ChannelBuffer;
 import org.onosproject.ospf.controller.OspfLsaType;
 import org.onosproject.ospf.protocol.lsa.OpaqueLsaHeader;
@@ -108,7 +111,7 @@
             return false;
         }
         OpaqueLsa9 that = (OpaqueLsa9) o;
-        return Objects.equal(opaqueInfo, that.opaqueInfo);
+        return Arrays.equals(opaqueInfo, that.opaqueInfo);
     }
 
     @Override