Fix Sonar errors: public data members in classes
Change-Id: I7aca37d5553436167ac6e7b2206392f88bddc118
diff --git a/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java b/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java
index cee5e81..bc6f7e4 100644
--- a/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java
+++ b/apps/pim/src/main/java/org/onosproject/pim/impl/PimInterface.java
@@ -593,9 +593,9 @@
}
private static class RouteData {
- public final IpAddress ipAddress;
- public final MacAddress macAddress;
- public long timestamp;
+ final IpAddress ipAddress;
+ final MacAddress macAddress;
+ long timestamp;
public RouteData(IpAddress ip, MacAddress mac) {
this.ipAddress = ip;
diff --git a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java
index 9c5b37b..01a09e4 100644
--- a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java
+++ b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java
@@ -179,8 +179,8 @@
IcmpHandler icmpHandler = null;
IpHandler ipHandler = null;
RoutingRulePopulator routingRulePopulator = null;
- public ApplicationId appId;
- public DeviceConfiguration deviceConfiguration = null;
+ ApplicationId appId;
+ DeviceConfiguration deviceConfiguration = null;
DefaultRoutingHandler defaultRoutingHandler = null;
private TunnelHandler tunnelHandler = null;
@@ -215,17 +215,17 @@
/**
* Per device next objective ID store with (device id + neighbor set) as key.
*/
- public EventuallyConsistentMap<NeighborSetNextObjectiveStoreKey, Integer>
+ EventuallyConsistentMap<NeighborSetNextObjectiveStoreKey, Integer>
nsNextObjStore = null;
/**
* Per device next objective ID store with (device id + subnet) as key.
*/
- public EventuallyConsistentMap<VlanNextObjectiveStoreKey, Integer>
+ EventuallyConsistentMap<VlanNextObjectiveStoreKey, Integer>
vlanNextObjStore = null;
/**
* Per device next objective ID store with (device id + port) as key.
*/
- public EventuallyConsistentMap<PortNextObjectiveStoreKey, Integer>
+ EventuallyConsistentMap<PortNextObjectiveStoreKey, Integer>
portNextObjStore = null;
private EventuallyConsistentMap<String, Tunnel> tunnelStore = null;
@@ -500,6 +500,51 @@
}
/**
+ * Extracts the application ID from the manager.
+ *
+ * @return application ID
+ */
+ public ApplicationId appId() {
+ return appId;
+ }
+
+ /**
+ * Returns the device configuration.
+ *
+ * @return device configuration
+ */
+ public DeviceConfiguration deviceConfiguration() {
+ return deviceConfiguration;
+ }
+
+ /**
+ * Per device next objective ID store with (device id + neighbor set) as key.
+ *
+ * @return next objective ID store
+ */
+ public EventuallyConsistentMap<NeighborSetNextObjectiveStoreKey, Integer> nsNextObjStore() {
+ return nsNextObjStore;
+ }
+
+ /**
+ * Per device next objective ID store with (device id + subnet) as key.
+ *
+ * @return vlan next object store
+ */
+ public EventuallyConsistentMap<VlanNextObjectiveStoreKey, Integer> vlanNextObjStore() {
+ return vlanNextObjStore;
+ }
+
+ /**
+ * Per device next objective ID store with (device id + port) as key.
+ *
+ * @return port next object store.
+ */
+ public EventuallyConsistentMap<PortNextObjectiveStoreKey, Integer> portNextObjStore() {
+ return portNextObjStore;
+ }
+
+ /**
* Returns the MPLS-ECMP configuration.
*
* @return MPLS-ECMP value
diff --git a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/config/DeviceConfiguration.java b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/config/DeviceConfiguration.java
index bd0db54..490bf4f 100644
--- a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/config/DeviceConfiguration.java
+++ b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/config/DeviceConfiguration.java
@@ -698,7 +698,7 @@
private boolean isSuppressedPort(ConnectPoint connectPoint) {
SegmentRoutingAppConfig appConfig = srManager.cfgService
- .getConfig(srManager.appId, SegmentRoutingAppConfig.class);
+ .getConfig(srManager.appId(), SegmentRoutingAppConfig.class);
if (appConfig != null && appConfig.suppressSubnet().contains(connectPoint)) {
log.info("Interface configuration on port {} is ignored", connectPoint);
return true;
diff --git a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java
index fe33f6c..e73a0d8 100644
--- a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java
+++ b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java
@@ -126,9 +126,9 @@
+ " Skipping value assignment in DefaultGroupHandler");
}
this.flowObjectiveService = flowObjService;
- this.nsNextObjStore = srManager.nsNextObjStore;
- this.vlanNextObjStore = srManager.vlanNextObjStore;
- this.portNextObjStore = srManager.portNextObjStore;
+ this.nsNextObjStore = srManager.nsNextObjStore();
+ this.vlanNextObjStore = srManager.vlanNextObjStore();
+ this.portNextObjStore = srManager.portNextObjStore();
this.srManager = srManager;
populateNeighborMaps();
diff --git a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java
index 74ddae5..72c7eac 100644
--- a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java
+++ b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java
@@ -811,7 +811,7 @@
.addCondition(Criteria.matchVlanId(outerTag))
.withPriority(SegmentRoutingService.DEFAULT_PRIORITY)
.permit()
- .fromApp(srManager.appId);
+ .fromApp(srManager.appId());
}
/**
@@ -844,7 +844,7 @@
trafficTreatment.setOutput(egressPort);
return DefaultForwardingObjective.builder()
- .fromApp(srManager.appId)
+ .fromApp(srManager.appId())
.makePermanent()
.nextStep(nextId)
.withPriority(SegmentRoutingService.DEFAULT_PRIORITY)
@@ -872,7 +872,7 @@
trafficSelector.matchInPort(inPort);
return DefaultForwardingObjective.builder()
- .fromApp(srManager.appId)
+ .fromApp(srManager.appId())
.makePermanent()
.nextStep(nextId)
.withPriority(SegmentRoutingService.DEFAULT_PRIORITY)
@@ -905,7 +905,7 @@
nextObjBuilder = DefaultNextObjective
.builder()
.withType(NextObjective.Type.SIMPLE)
- .fromApp(srManager.appId);
+ .fromApp(srManager.appId());
// The pw label is the bottom of stack. It has to
// be different -1.
if (l2Tunnel.pwLabel().toInt() == MplsLabel.MAX_MPLS) {
@@ -928,7 +928,7 @@
MplsLabel srLabel;
try {
srLabel = MplsLabel.mplsLabel(
- srManager.deviceConfiguration.getIPv4SegmentId(egressId)
+ srManager.deviceConfiguration().getIPv4SegmentId(egressId)
);
} catch (DeviceConfigNotFoundException e) {
log.warn("Sr label not configured");
@@ -942,7 +942,7 @@
MacAddress ingressMac;
try {
ingressMac = srManager
- .deviceConfiguration
+ .deviceConfiguration()
.getDeviceMac(srcCp.deviceId());
} catch (DeviceConfigNotFoundException e) {
log.warn("Was not able to find the ingress mac");
@@ -952,7 +952,7 @@
MacAddress neighborMac;
try {
neighborMac = srManager
- .deviceConfiguration
+ .deviceConfiguration()
.getDeviceMac(dstCp.deviceId());
} catch (DeviceConfigNotFoundException e) {
log.warn("Was not able to find the neighbor mac");
@@ -965,7 +965,7 @@
nextObjBuilder = DefaultNextObjective
.builder()
.withType(NextObjective.Type.SIMPLE)
- .fromApp(srManager.appId);
+ .fromApp(srManager.appId());
}
treatmentBuilder.setOutput(srcCp.port());
nextObjBuilder.addTreatment(treatmentBuilder.build());
diff --git a/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/FlowObjectiveCompositionTree.java b/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/FlowObjectiveCompositionTree.java
index 617933d..08ce696 100644
--- a/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/FlowObjectiveCompositionTree.java
+++ b/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/FlowObjectiveCompositionTree.java
@@ -30,10 +30,10 @@
*/
public class FlowObjectiveCompositionTree {
- public FlowObjectiveCompositionManager.PolicyOperator operator;
- public FlowObjectiveCompositionTree leftChild;
- public FlowObjectiveCompositionTree rightChild;
- public short applicationId;
+ FlowObjectiveCompositionManager.PolicyOperator operator;
+ FlowObjectiveCompositionTree leftChild;
+ FlowObjectiveCompositionTree rightChild;
+ protected short applicationId;
protected FilterTable filterTable;
protected ForwardTable forwardTable;
protected NextTable nextTable;
diff --git a/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/ForwardUpdateTable.java b/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/ForwardUpdateTable.java
index e674e24..6c43add 100644
--- a/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/ForwardUpdateTable.java
+++ b/core/net/src/main/java/org/onosproject/net/flowobjective/impl/composition/ForwardUpdateTable.java
@@ -24,8 +24,8 @@
* Provides an update table for Forward.
*/
public class ForwardUpdateTable {
- public List<ForwardingObjective> addObjectives;
- public List<ForwardingObjective> removeObjectives;
+ List<ForwardingObjective> addObjectives;
+ List<ForwardingObjective> removeObjectives;
public ForwardUpdateTable() {
this.addObjectives = new ArrayList<>();
diff --git a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpKeepaliveMsgVer4.java b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpKeepaliveMsgVer4.java
index 7cb13aa..ea2c785 100644
--- a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpKeepaliveMsgVer4.java
+++ b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpKeepaliveMsgVer4.java
@@ -63,7 +63,7 @@
public static final int PACKET_MINIMUM_LENGTH = 19;
public static final int MARKER_LENGTH = 16;
public static final BgpType MSG_TYPE = BgpType.KEEP_ALIVE;
- public static byte[] marker = new byte[] {(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
+ static byte[] marker = new byte[] {(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff};
diff --git a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpUpdateMsgVer4.java b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpUpdateMsgVer4.java
index b6576a3..a0640db 100644
--- a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpUpdateMsgVer4.java
+++ b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/protocol/ver4/BgpUpdateMsgVer4.java
@@ -84,7 +84,7 @@
public static final int MIN_LEN_AFTER_WITHDRW_ROUTES = 2;
public static final int MINIMUM_COMMON_HEADER_LENGTH = 19;
public static final BgpType MSG_TYPE = BgpType.UPDATE;
- public static byte[] marker = new byte[] {(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
+ private static byte[] marker = new byte[] {(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff,
(byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff};
diff --git a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/IPReachabilityInformationTlv.java b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/IPReachabilityInformationTlv.java
index 9cdccc5..ce1c443 100644
--- a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/IPReachabilityInformationTlv.java
+++ b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/IPReachabilityInformationTlv.java
@@ -49,7 +49,7 @@
private byte prefixLen;
private byte[] ipPrefix;
- public short length;
+ private short length;
/**
* Constructor to initialize parameters.
@@ -162,4 +162,4 @@
.add("Prefixvalue", getPrefixValue())
.toString();
}
-}
\ No newline at end of file
+}
diff --git a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrMaxLinkBandwidth.java b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrMaxLinkBandwidth.java
index baa0aae..b692027 100644
--- a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrMaxLinkBandwidth.java
+++ b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrMaxLinkBandwidth.java
@@ -38,7 +38,7 @@
public static final int MAX_BANDWIDTH_LEN = 4;
public static final int NO_OF_BITS = 8;
- public short type;
+ private short type;
/* ISIS administrative group */
private final float maxBandwidth;
diff --git a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrUnRsrvdLinkBandwidth.java b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrUnRsrvdLinkBandwidth.java
index 42a5e40..5f77b5f 100644
--- a/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrUnRsrvdLinkBandwidth.java
+++ b/protocols/bgp/bgpio/src/main/java/org/onosproject/bgpio/types/attr/BgpLinkAttrUnRsrvdLinkBandwidth.java
@@ -41,7 +41,7 @@
public static final int NO_OF_BITS = 8;
public static final int NO_OF_PRIORITY = 8;
- public short sType;
+ private short sType;
/* ISIS administrative group */
private List<Float> maxUnResBandwidth = new ArrayList<Float>();
diff --git a/protocols/bgp/ctl/src/main/java/org/onosproject/bgp/controller/impl/Controller.java b/protocols/bgp/ctl/src/main/java/org/onosproject/bgp/controller/impl/Controller.java
index 72f803d..f786cf7 100644
--- a/protocols/bgp/ctl/src/main/java/org/onosproject/bgp/controller/impl/Controller.java
+++ b/protocols/bgp/ctl/src/main/java/org/onosproject/bgp/controller/impl/Controller.java
@@ -50,7 +50,7 @@
private static final BgpFactory FACTORY4 = BgpFactories.getFactory(BgpVersion.BGP_4);
private ChannelGroup cg;
- public Channel serverChannel;
+ private Channel serverChannel;
// Configuration options
protected static final short BGP_PORT_NUM = 179;
@@ -259,4 +259,4 @@
public void setBgpPortNum() {
isPortNumSet = true;
}
-}
\ No newline at end of file
+}
diff --git a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/area/OspfAreaAddressRangeImpl.java b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/area/OspfAreaAddressRangeImpl.java
index e0636d7..1337203 100644
--- a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/area/OspfAreaAddressRangeImpl.java
+++ b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/area/OspfAreaAddressRangeImpl.java
@@ -28,9 +28,9 @@
*/
public class OspfAreaAddressRangeImpl implements OspfAreaAddressRange {
- public Ip4Address ipAddress;
- public String mask;
- public boolean advertise;
+ private Ip4Address ipAddress;
+ private String mask;
+ private boolean advertise;
/**
* Gets the IP address.
@@ -111,4 +111,4 @@
.add("advertise", advertise)
.toString();
}
-}
\ No newline at end of file
+}
diff --git a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/TopologyForDeviceAndLinkImpl.java b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/TopologyForDeviceAndLinkImpl.java
index 86dd2cf..67edc39 100644
--- a/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/TopologyForDeviceAndLinkImpl.java
+++ b/protocols/ospf/ctl/src/main/java/org/onosproject/ospf/controller/impl/TopologyForDeviceAndLinkImpl.java
@@ -606,7 +606,7 @@
routerLsa.lsType();
List<OspfLsaLink> ospfLsaLinkList = routerLsa.routerLink();
for (OspfLsaLink link : ospfLsaLinkList) {
- if (link.linkType == 1 || link.linkType == 2) {
+ if (link.linkType() == 1 || link.linkType() == 2) {
if ((routerLsa.advertisingRouter().equals(ospfArea.routerId())) ||
(link.equals(ospfArea.routerId()))) {
log.debug("OspfInterface information will not display in web ");
@@ -641,7 +641,7 @@
RouterLsa routerLsa = (RouterLsa) ospfLsa;
List<OspfLsaLink> ospfLsaLinkList = routerLsa.routerLink();
for (OspfLsaLink link : ospfLsaLinkList) {
- if (link.linkType == 1 || link.linkType == 2) {
+ if (link.linkType() == 1 || link.linkType() == 2) {
if ((routerLsa.advertisingRouter().equals(ospfArea.routerId())) ||
(link.equals(ospfArea.routerId()))) {
log.debug("OspfInterface information will not display in web ");
@@ -666,4 +666,4 @@
}
return removedLinkList;
}
-}
\ No newline at end of file
+}
diff --git a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/subtypes/OspfLsaLink.java b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/subtypes/OspfLsaLink.java
index 05027a9..ecb5f34 100644
--- a/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/subtypes/OspfLsaLink.java
+++ b/protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/subtypes/OspfLsaLink.java
@@ -22,11 +22,11 @@
*/
public class OspfLsaLink {
- public String linkId;
- public String linkData;
- public int linkType;
- public int metric;
- public int tos;
+ private String linkId;
+ private String linkData;
+ private int linkType;
+ private int metric;
+ private int tos;
/**
* Gets link id.
@@ -129,4 +129,4 @@
.add("tos", tos)
.toString();
}
-}
\ No newline at end of file
+}
diff --git a/protocols/pcep/api/src/main/java/org/onosproject/pcep/controller/PcepErrorType.java b/protocols/pcep/api/src/main/java/org/onosproject/pcep/controller/PcepErrorType.java
index de68061..6de842e 100644
--- a/protocols/pcep/api/src/main/java/org/onosproject/pcep/controller/PcepErrorType.java
+++ b/protocols/pcep/api/src/main/java/org/onosproject/pcep/controller/PcepErrorType.java
@@ -32,7 +32,7 @@
INVALIDOPERATION(19),
VIRTUALNETWORKTLVMISSING(255);
- public int value;
+ int value;
/**
* Creates an instance of Pcep Error Type.
@@ -51,4 +51,4 @@
public int value() {
return value;
}
-}
\ No newline at end of file
+}
diff --git a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepEndPointsObjectVer1.java b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepEndPointsObjectVer1.java
index f485343..35e30f6 100644
--- a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepEndPointsObjectVer1.java
+++ b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/protocol/ver1/PcepEndPointsObjectVer1.java
@@ -53,15 +53,15 @@
static final byte END_POINTS_OBJ_CLASS = 4;
static final byte END_POINTS_OBJECT_VERSION = 1;
static final short END_POINTS_OBJ_MINIMUM_LENGTH = 12;
- public static byte endPointObjType;
+ static byte endPointObjType;
static final PcepObjectHeader DEFAULT_END_POINTS_OBJECT_HEADER = new PcepObjectHeader(END_POINTS_OBJ_CLASS,
END_POINTS_OBJ_TYPE, PcepObjectHeader.REQ_OBJ_OPTIONAL_PROCESS, PcepObjectHeader.RSP_OBJ_PROCESSED,
END_POINTS_OBJ_MINIMUM_LENGTH);
private PcepObjectHeader endPointsObjHeader;
- public int sourceIpAddress;
- public int destIpAddress;
+ int sourceIpAddress;
+ int destIpAddress;
/**
* Constructor to initialize all variables.
diff --git a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LinkAttributesTlv.java b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LinkAttributesTlv.java
index 7294ff9..9e62e6a 100644
--- a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LinkAttributesTlv.java
+++ b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LinkAttributesTlv.java
@@ -50,7 +50,7 @@
protected static final Logger log = LoggerFactory.getLogger(LinkAttributesTlv.class);
public static final short TYPE = (short) 65286;
- public short hLength;
+ short hLength;
public static final int TLV_HEADER_LENGTH = 4;
diff --git a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LocalNodeDescriptorsTlv.java b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LocalNodeDescriptorsTlv.java
index c516d8c..01c6cb7 100644
--- a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LocalNodeDescriptorsTlv.java
+++ b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/LocalNodeDescriptorsTlv.java
@@ -50,7 +50,7 @@
protected static final Logger log = LoggerFactory.getLogger(LocalNodeDescriptorsTlv.class);
public static final short TYPE = (short) 65282;
- public short hLength;
+ short hLength;
public static final int TLV_HEADER_LENGTH = 4;
// Node Descriptor Sub-TLVs (variable)
diff --git a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/NodeAttributesTlv.java b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/NodeAttributesTlv.java
index d4e9e95..558d41b 100644
--- a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/NodeAttributesTlv.java
+++ b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/NodeAttributesTlv.java
@@ -52,7 +52,7 @@
protected static final Logger log = LoggerFactory.getLogger(NodeAttributesTlv.class);
public static final short TYPE = (short) 65285;
- public short hLength;
+ short hLength;
public static final int TLV_HEADER_LENGTH = 4;
// LinkDescriptors Sub-TLVs (variable)
diff --git a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/RemoteNodeDescriptorsTlv.java b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/RemoteNodeDescriptorsTlv.java
index 9408442..2d46edc 100644
--- a/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/RemoteNodeDescriptorsTlv.java
+++ b/protocols/pcep/pcepio/src/main/java/org/onosproject/pcepio/types/RemoteNodeDescriptorsTlv.java
@@ -50,7 +50,7 @@
protected static final Logger log = LoggerFactory.getLogger(RemoteNodeDescriptorsTlv.class);
public static final short TYPE = (short) 65283;
- public short hLength;
+ short hLength;
public static final int TLV_HEADER_LENGTH = 4;
// Node Descriptor Sub-TLVs (variable)