commit ddb7772971b33af75bd1d37ab5e9be4c311e5861
author Yuta HIGUCHI <y-higuchi@ak.jp.nec.com> Thu Dec 11 19:39:04 2014 -0800
committer Gerrit Code Review <gerrit@onlab.us> Mon Dec 15 18:13:01 2014 +0000
tree 6364cbc637eb3dab367a35824e0352637b12c97d
parent 24f79eb3f3a97f268c04342f86018bf34d0e2e26

LinkManager: log only if link actually disappeared

resolves ONOS-474

Change-Id: I61ec56795eca18b11c61b8fe5722729928bb370c

core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java

diff --git a/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java b/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
index 1e04913..d2e52a2 100644
--- a/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
+++ b/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
@@ -255,7 +255,7 @@
             checkNotNull(connectPoint, "Connect point cannot be null");
             checkValidity();
 
-            log.info("Links for connection point {} vanished", connectPoint);
+            log.debug("Links for connection point {} vanished", connectPoint);
             // FIXME: This will remove links registered by other providers
             removeLinks(getLinks(connectPoint), true);
         }
@@ -265,7 +265,7 @@
             checkNotNull(deviceId, DEVICE_ID_NULL);
             checkValidity();
 
-            log.info("Links for device {} vanished", deviceId);
+            log.debug("Links for device {} vanished", deviceId);
             removeLinks(getDeviceLinks(deviceId), true);
         }
     }
@@ -276,7 +276,10 @@
             LinkEvent event = isSoftRemove ?
                     store.removeOrDownLink(link.src(), link.dst()) :
                     store.removeLink(link.src(), link.dst());
-            post(event);
+            if (event != null) {
+                log.info("Link {} removed/vanished", event.subject());
+                post(event);
+            }
         }
     }