commit ab541a5dbd8fef5ce6dd2417998111612794b641
author Sho SHIMIZU <sshimizu@us.fujitsu.com> Wed Jan 13 23:29:32 2016 -0800
committer Gerrit Code Review <gerrit@onlab.us> Thu Jan 14 20:38:45 2016 +0000
tree 5b48084d5b873efb57f52627a1b6c04369478bb7
parent 5fb1ea31f31260b4a33ad3d23a4b2bb5fbbedbce

Refactor: Use Stream API instead of explicit loop

Change-Id: I6ed6aba185a0ce3680fe0612de801a466a848d78

core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java

diff --git a/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
index 324a561..4dd5e85 100644
--- a/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
+++ b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
@@ -15,7 +15,6 @@
  */
 package org.onosproject.net.intent.impl;
 
-import com.google.common.collect.ImmutableList;
 import org.apache.felix.scr.annotations.Activate;
 import org.apache.felix.scr.annotations.Component;
 import org.apache.felix.scr.annotations.Deactivate;
@@ -50,9 +49,9 @@
 import java.util.EnumSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutorService;
 import java.util.stream.Collectors;
 
@@ -340,16 +339,15 @@
     }
 
     private List<FinalIntentProcessPhase> waitForFutures(List<CompletableFuture<FinalIntentProcessPhase>> futures) {
-        ImmutableList.Builder<FinalIntentProcessPhase> updateBuilder = ImmutableList.builder();
-        for (CompletableFuture<FinalIntentProcessPhase> future : futures) {
-            try {
-                updateBuilder.add(future.get());
-            } catch (InterruptedException | ExecutionException e) {
-                //FIXME
-                log.warn("Future failed: {}", e);
-            }
-        }
-        return updateBuilder.build();
+        return futures.stream()
+                .map(x -> x.exceptionally(e -> {
+                    //FIXME
+                    log.warn("Future failed: {}", e);
+                    return null;
+                }))
+                .map(CompletableFuture::join)
+                .filter(Objects::nonNull)
+                .collect(Collectors.toList());
     }
 
     private void submitUpdates(List<FinalIntentProcessPhase> updates) {