commit a990ce97108930973d850dbf0c79840377b9f17a
author Charles Chan <rascov@gmail.com> Mon Oct 30 10:22:50 2017 -0700
committer Charles Chan <charles@opennetworking.org> Mon Oct 30 18:15:29 2017 +0000
tree 8c9dd04f5251951a2b6cc28fc25c462f589fca05
parent 856f31392b3338496a47f7a8d4ba309e4ceef4d7

[CORD-2065] Source address of relayed DHCPv6 packet is not always correct?

Change-Id: I6cffcee82e1d902cd022de32c8844c4df1f80707

apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java

diff --git a/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java b/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java
index 754d70d..d72f4fc 100644
--- a/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java
+++ b/apps/dhcprelay/src/main/java/org/onosproject/dhcprelay/Dhcp6HandlerImpl.java
@@ -741,9 +741,37 @@
          etherReply.setVlanID(this.dhcpConnectVlan.toShort());
 
          IPv6 ipv6Packet = (IPv6) etherReply.getPayload();
-         byte[] peerAddress = clientIpv6.getSourceAddress();
-         ipv6Packet.setSourceAddress(ipFacingServer.toOctets());
+         Ip6Address peerAddress = null;
+         if (directConnFlag) {
+             peerAddress = Ip6Address.valueOf(ipv6Packet.getSourceAddress());
 
+         } else {
+             MacAddress gwOrClientMac = MacAddress.valueOf(clientPacket.getSourceMACAddress());
+             VlanId vlanId = VlanId.vlanId(clientPacket.getVlanID());
+             HostId gwOrClientHostId = HostId.hostId(gwOrClientMac, vlanId);
+             Host gwOrClientHost = hostService.getHost(gwOrClientHostId);
+
+             if (gwOrClientHost == null) {
+                 log.warn("Can't find client gateway/server host {}", gwOrClientHostId);
+                 return null;
+             }
+             // pick out the first gloabl ip address
+             peerAddress = gwOrClientHost.ipAddresses()
+                     .stream()
+                     .filter(IpAddress::isIp6)
+                     .filter(ip6 -> !ip6.isLinkLocal())
+                     .map(IpAddress::getIp6Address)
+                     .findFirst()
+                     .orElse(null);
+
+             if (peerAddress == null) {
+                 log.warn("Can't find client gateway/server for mac {} ip {}", gwOrClientMac,
+                         HexString.toHexString(ipv6Packet.getSourceAddress()));
+                 log.warn("Can't find IP address of client gateway/ClienHost address {} for peerAddress", gwOrClientHost);
+                 return null;
+             }
+         }
+         ipv6Packet.setSourceAddress(ipFacingServer.toOctets());
          ipv6Packet.setDestinationAddress(this.dhcpServerIp.toOctets());
 
          UDP udpPacket = (UDP) ipv6Packet.getPayload();
@@ -806,7 +834,7 @@
 
          // peer address:  address of the client or relay agent from which
          // the message to be relayed was received.
-         dhcp6Relay.setPeerAddress(peerAddress);
+         dhcp6Relay.setPeerAddress(peerAddress.toOctets());
          List<Dhcp6Option> options = new ArrayList<Dhcp6Option>();
 
          // directly connected case, hop count is zero