commit 8d37efce3c546bb80597988f4cc7a3453c6c6c70
author Madan Jampani <madan@onlab.us> Mon Jun 01 17:25:48 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Tue Jun 02 00:31:31 2015 +0000
tree 679d2d04a3b314563a19efd173fcddad4db9dd8b
parent 59f86fdb6400ea36bf62951009afa3d6b007ec14

ONOS-2015: Randomly choose retry delay to avoid update contention

Change-Id: I35db8126bb8daa832aecd5696094e5b884853bdd

core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DistributedLeadershipManager.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DistributedLeadershipManager.java b/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DistributedLeadershipManager.java
index fd8afb7..85834a7 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DistributedLeadershipManager.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/DistributedLeadershipManager.java
@@ -7,6 +7,7 @@
 import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
 
+import org.apache.commons.lang.math.RandomUtils;
 import org.apache.felix.scr.annotations.Activate;
 import org.apache.felix.scr.annotations.Component;
 import org.apache.felix.scr.annotations.Deactivate;
@@ -102,7 +103,8 @@
     private Set<String> activeTopics = Sets.newConcurrentHashSet();
     private Map<String, CompletableFuture<Leadership>> pendingFutures = Maps.newConcurrentMap();
 
-    private static final int ELECTION_JOIN_ATTEMPT_INTERVAL_SEC = 2;
+    // The actual delay is randomly chosen between the interval [0, WAIT_BEFORE_RETRY_MILLIS)
+    private static final int WAIT_BEFORE_RETRY_MILLIS = 150;
     private static final int DELAY_BETWEEN_LEADER_LOCK_ATTEMPTS_SEC = 2;
     private static final int LEADERSHIP_STATUS_UPDATE_INTERVAL_SEC = 2;
     private static final int DELAY_BETWEEN_STALE_LEADERSHIP_PURGE_ATTEMPTS_SEC = 2;
@@ -302,7 +304,7 @@
                                     newCandidates.version(),
                                     newCandidates.creationTime())));
             } else {
-                log.warn("Failed to withdraw from candidates list for {}. Will retry", path);
+                log.debug("Failed to withdraw from candidates list for {}. Will retry", path);
                 retryWithdraw(path, future);
             }
         } catch (Exception e) {
@@ -480,15 +482,15 @@
     private void rerunForLeadership(String path, CompletableFuture<Leadership> future) {
         lockExecutor.schedule(
                 () -> doRunForLeadership(path, future),
-                ELECTION_JOIN_ATTEMPT_INTERVAL_SEC,
-                TimeUnit.SECONDS);
+                RandomUtils.nextInt(WAIT_BEFORE_RETRY_MILLIS),
+                TimeUnit.MILLISECONDS);
     }
 
     private void retryWithdraw(String path, CompletableFuture<Void> future) {
         lockExecutor.schedule(
                 () -> doWithdraw(path, future),
-                DELAY_BETWEEN_LEADER_LOCK_ATTEMPTS_SEC,
-                TimeUnit.SECONDS);
+                RandomUtils.nextInt(WAIT_BEFORE_RETRY_MILLIS),
+                TimeUnit.MILLISECONDS);
     }
 
     private void scheduleStaleLeadershipPurge(int afterDelaySec) {