commit 8767511609393c7d4b3aa63700c0c6957096a245
author Carmelo Cascone <carmelo@opennetworking.org> Tue Aug 04 17:19:40 2020 -0700
committer Carmelo Cascone <carmelo@opennetworking.org> Tue Aug 11 01:12:56 2020 +0000
tree 2cb3693c8b6c5a8b09f6c8d77ee138de5759add9
parent e97f483c3dd56de483c79500cadf07dfda5fa70e

Use instance 0 for first replica of P4RT clone groups

Some switch implementations do not support non-zero values

Change-Id: I6fb7e9075fe0c6f48448f43c58054e03f4e9781b

core/net/src/main/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImpl.java

diff --git a/core/net/src/main/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImpl.java b/core/net/src/main/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImpl.java
index 1f562a4..53fb9d2 100644
--- a/core/net/src/main/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImpl.java
+++ b/core/net/src/main/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImpl.java
@@ -118,7 +118,7 @@
             // Use incremental instance IDs for replicas of the same port.
             replicaMap.putIfAbsent(port, Sets.newHashSet());
             replicaMap.get(port).add(
-                    new PiPreReplica(port, replicaMap.get(port).size() + 1));
+                    new PiPreReplica(port, replicaMap.get(port).size()));
         }
         return replicaMap.values().stream()
                 .flatMap(Collection::stream)

core/net/src/test/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImplTest.java

diff --git a/core/net/src/test/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImplTest.java b/core/net/src/test/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImplTest.java
index 7b5e213..8ca78cf 100644
--- a/core/net/src/test/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImplTest.java
+++ b/core/net/src/test/java/org/onosproject/net/pi/impl/PiReplicationGroupTranslatorImplTest.java
@@ -74,15 +74,15 @@
             allOutputBucket(3));
 
     private static final Set<PiPreReplica> REPLICAS = ImmutableSet.of(
-            new PiPreReplica(PortNumber.portNumber(1), 1),
-            new PiPreReplica(PortNumber.portNumber(2), 1),
-            new PiPreReplica(PortNumber.portNumber(3), 1));
+            new PiPreReplica(PortNumber.portNumber(1), 0),
+            new PiPreReplica(PortNumber.portNumber(2), 0),
+            new PiPreReplica(PortNumber.portNumber(3), 0));
     private static final Set<PiPreReplica> REPLICAS_2 = ImmutableSet.of(
-            new PiPreReplica(PortNumber.portNumber(1), 1),
+            new PiPreReplica(PortNumber.portNumber(1), 0),
+            new PiPreReplica(PortNumber.portNumber(2), 0),
             new PiPreReplica(PortNumber.portNumber(2), 1),
-            new PiPreReplica(PortNumber.portNumber(2), 2),
-            new PiPreReplica(PortNumber.portNumber(3), 1),
-            new PiPreReplica(PortNumber.portNumber(3), 2));
+            new PiPreReplica(PortNumber.portNumber(3), 0),
+            new PiPreReplica(PortNumber.portNumber(3), 1));
 
     private static final PiMulticastGroupEntry PI_MULTICAST_GROUP =
             PiMulticastGroupEntry.builder()