commit 754701c956d2e2e607bad04bc791cb5bf04bbf15
author Harshada Chaundkar <Harshada_Chaundkar@comcast.com> Fri Mar 08 14:15:53 2019 -0500
committer Charles Chan <charles@opennetworking.org> Mon Mar 11 23:22:41 2019 +0000
tree 590e0e9547984d199c7abc27181f1959dcb2a516
parent addf6345a304fddeb12c738b1ad847a2daa5a31b

Fixed potential NPE in packet-stats for ipv4 tcp packets

Change-Id: I6b649a689a4e9d7ed1519e7d8f6dd2a4846758ee

apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java

diff --git a/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java b/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java
index ad3074e..39114d4 100644
--- a/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java
+++ b/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java
@@ -46,7 +46,7 @@
  * Application for Packet Statistics.
  */
 @Component(immediate = true)
-public class  PacketStatistics {
+public class PacketStatistics {
 
     @Reference(cardinality = ReferenceCardinality.MANDATORY)
     protected PacketService packetService;
@@ -145,6 +145,10 @@
                 metricService.createCounter(packetStatisticsComponent, lldpFeature, "lldpPC");
         this.vlanCounter =
                 metricService.createCounter(packetStatisticsComponent, vlanFeature, "vlanPC");
+        this.tcpCounter =
+                metricService.createCounter(packetStatisticsComponent, tcpFeature, "tcpPC");
+        this.rarpCounter =
+                metricService.createCounter(packetStatisticsComponent, rarpFeature, "rarpPC");
         this.icmpCounter =
                 metricService.createCounter(packetStatisticsComponent, icmpFeature, "icmpPC");
         this.icmp6Counter =
@@ -246,7 +250,7 @@
             } else {
                     log.debug("Packet is unknown.");
                     unknownCounter.inc();
-              }
             }
         }
+    }
 }