commit 6ba7efceaffebd9fc894c6574051eb40696654bf
author Pavlin Radoslavov <pavlin@onlab.us> Fri Mar 20 16:26:10 2015 -0700
committer Gerrit Code Review <gerrit@onlab.us> Mon Mar 23 17:08:18 2015 +0000
tree c2f9b8fc28ba3995dc45026fb78999a6799f9bb0
parent 0a53facc4427ef68acff1f579e60365fe27fe9c8

Work toward ONOS-1268 Expose IPv6 support at the ONOS CLI level

* Automatically assign the Ethtype based on the IP address version
  for the "--ipSrc" and "--ipDst" arguments

* Fix a typo in the --ipSrc and --ipDst description

* Check whether the --ipSrc and --ipDst address versions are same

Change-Id: Iaac98987b070c5fed97a7f6eb4c544f1578effcd

cli/src/main/java/org/onosproject/cli/net/ConnectivityIntentCommand.java

diff --git a/cli/src/main/java/org/onosproject/cli/net/ConnectivityIntentCommand.java b/cli/src/main/java/org/onosproject/cli/net/ConnectivityIntentCommand.java
index 308bbf9..713603b 100644
--- a/cli/src/main/java/org/onosproject/cli/net/ConnectivityIntentCommand.java
+++ b/cli/src/main/java/org/onosproject/cli/net/ConnectivityIntentCommand.java
@@ -60,11 +60,11 @@
             required = false, multiValued = false)
     private String ipProtoString = null;
 
-    @Option(name = "--ipSrc", description = "Source IP Address",
+    @Option(name = "--ipSrc", description = "Source IP Prefix",
             required = false, multiValued = false)
     private String srcIpString = null;
 
-    @Option(name = "--ipDst", description = "Destination IP Address",
+    @Option(name = "--ipDst", description = "Destination IP Prefix",
             required = false, multiValued = false)
     private String dstIpString = null;
 
@@ -109,9 +109,47 @@
      * @return traffic selector
      */
     protected TrafficSelector buildTrafficSelector() {
-        TrafficSelector.Builder selectorBuilder = DefaultTrafficSelector.builder();
-        short ethType = EthType.IPV4.value();
+        IpPrefix srcIpPrefix = null;
+        IpPrefix dstIpPrefix = null;
 
+        TrafficSelector.Builder selectorBuilder = DefaultTrafficSelector.builder();
+
+        if (!isNullOrEmpty(srcIpString)) {
+            srcIpPrefix = IpPrefix.valueOf(srcIpString);
+            if (srcIpPrefix.isIp4()) {
+                selectorBuilder.matchIPSrc(srcIpPrefix);
+            } else {
+                selectorBuilder.matchIPv6Src(srcIpPrefix);
+            }
+        }
+
+        if (!isNullOrEmpty(dstIpString)) {
+            dstIpPrefix = IpPrefix.valueOf(dstIpString);
+            if (dstIpPrefix.isIp4()) {
+                selectorBuilder.matchIPDst(dstIpPrefix);
+            } else {
+                selectorBuilder.matchIPv6Dst(dstIpPrefix);
+            }
+        }
+
+        if ((srcIpPrefix != null) && (dstIpPrefix != null) &&
+            (srcIpPrefix.version() != dstIpPrefix.version())) {
+            // ERROR: IP src/dst version mismatch
+            throw new IllegalArgumentException(
+                        "IP source and destination version mismatch");
+        }
+
+        //
+        // Set the default EthType based on the IP version if the matching
+        // source or destination IP prefixes.
+        //
+        short ethType = EthType.IPV4.value();
+        if ((srcIpPrefix != null) && srcIpPrefix.isIp6()) {
+            ethType = EthType.IPV6.value();
+        }
+        if ((dstIpPrefix != null) && dstIpPrefix.isIp6()) {
+            ethType = EthType.IPV6.value();
+        }
         if (!isNullOrEmpty(ethTypeString)) {
             ethType = EthType.parseFromString(ethTypeString);
         }
@@ -130,14 +168,6 @@
             selectorBuilder.matchIPProtocol((byte) ipProtoShort);
         }
 
-        if (!isNullOrEmpty(srcIpString)) {
-            selectorBuilder.matchIPSrc(IpPrefix.valueOf(srcIpString));
-        }
-
-        if (!isNullOrEmpty(dstIpString)) {
-            selectorBuilder.matchIPDst(IpPrefix.valueOf(dstIpString));
-        }
-
         if (!isNullOrEmpty(srcTcpString)) {
             selectorBuilder.matchTcpSrc((short) Integer.parseInt(srcTcpString));
         }