commit | 5c0b476e73dbb1aec475344b502d6f9b554f6011 | [log] [tgz] |
---|---|---|
author | Charles M.C. Chan <rascov@gmail.com> | Sat Jan 10 18:38:37 2015 +0800 |
committer | Pavlin Radoslavov <pavlin@onlab.us> | Sat Jan 10 17:06:31 2015 +0000 |
tree | 778ad8d8f600b6176e5e20f76ed67a572acf4158 | |
parent | 94f37374faf19e9211ccb77f40a989951e7d2e3f [diff] [blame] |
Refactor: Avoid using ternary operator. Remove unnecessary casting. * Apply suggestion in #2192 to previous implemented classes Change-Id: I271d64202dd43968825600cd9afc49eb400371bf
diff --git a/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java b/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java index 5334d54..948b08a 100644 --- a/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java +++ b/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java
@@ -38,7 +38,10 @@ payloadData = this.payload.serialize(); } - int payloadLength = payloadData == null ? 0 : (short) payloadData.length; + int payloadLength = 0; + if (payloadData != null) { + payloadLength = payloadData.length; + } final byte[] data = new byte[HEADER_LENGTH + payloadLength]; final ByteBuffer bb = ByteBuffer.wrap(data);