commit 5c0b476e73dbb1aec475344b502d6f9b554f6011
author Charles M.C. Chan <rascov@gmail.com> Sat Jan 10 18:38:37 2015 +0800
committer Pavlin Radoslavov <pavlin@onlab.us> Sat Jan 10 17:06:31 2015 +0000
tree 778ad8d8f600b6176e5e20f76ed67a572acf4158
parent 94f37374faf19e9211ccb77f40a989951e7d2e3f

Refactor: Avoid using ternary operator. Remove unnecessary casting.

	* Apply suggestion in #2192 to previous implemented classes

Change-Id: I271d64202dd43968825600cd9afc49eb400371bf

utils/misc/src/main/java/org/onlab/packet/ICMP6.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/ICMP6.java b/utils/misc/src/main/java/org/onlab/packet/ICMP6.java
index 13deab2..bb4f204 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ICMP6.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ICMP6.java
@@ -121,7 +121,10 @@
             payloadData = this.payload.serialize();
         }
 
-        int payloadLength = payloadData == null ? 0 : (short) payloadData.length;
+        int payloadLength = 0;
+        if (payloadData != null) {
+            payloadLength = payloadData.length;
+        }
 
         final byte[] data = new byte[HEADER_LENGTH + payloadLength];
         final ByteBuffer bb = ByteBuffer.wrap(data);

utils/misc/src/main/java/org/onlab/packet/IPv6.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/IPv6.java b/utils/misc/src/main/java/org/onlab/packet/IPv6.java
index 16c6687..3bb35c5 100644
--- a/utils/misc/src/main/java/org/onlab/packet/IPv6.java
+++ b/utils/misc/src/main/java/org/onlab/packet/IPv6.java
@@ -218,7 +218,10 @@
             payloadData = this.payload.serialize();
         }
 
-        this.payloadLength = payloadData == null ? 0 : (short) payloadData.length;
+        this.payloadLength = 0;
+        if (payloadData != null) {
+            this.payloadLength = (short) payloadData.length;
+        }
 
         final byte[] data = new byte[FIXED_HEADER_LENGTH + payloadLength];
         final ByteBuffer bb = ByteBuffer.wrap(data);

utils/misc/src/main/java/org/onlab/packet/ndp/NeighborAdvertisement.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborAdvertisement.java b/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborAdvertisement.java
index f144b84..113107a 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborAdvertisement.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborAdvertisement.java
@@ -125,7 +125,10 @@
             payloadData = this.payload.serialize();
         }
 
-        int payloadLength = payloadData == null ? 0 : (short) payloadData.length;
+        int payloadLength = 0;
+        if (payloadData != null) {
+            payloadLength = payloadData.length;
+        }
 
         final byte[] data = new byte[HEADER_LENGTH + payloadLength];
         final ByteBuffer bb = ByteBuffer.wrap(data);

utils/misc/src/main/java/org/onlab/packet/ndp/NeighborSolicitation.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborSolicitation.java b/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborSolicitation.java
index 6da8503..878f939 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborSolicitation.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ndp/NeighborSolicitation.java
@@ -62,7 +62,10 @@
             payloadData = this.payload.serialize();
         }
 
-        int payloadLength = payloadData == null ? 0 : (short) payloadData.length;
+        int payloadLength = 0;
+        if (payloadData != null) {
+            payloadLength = payloadData.length;
+        }
 
         final byte[] data = new byte[HEADER_LENGTH + payloadLength];
         final ByteBuffer bb = ByteBuffer.wrap(data);

utils/misc/src/main/java/org/onlab/packet/ndp/Redirect.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/ndp/Redirect.java b/utils/misc/src/main/java/org/onlab/packet/ndp/Redirect.java
index 2c9450b..a7e7680 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ndp/Redirect.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ndp/Redirect.java
@@ -83,7 +83,10 @@
             payloadData = this.payload.serialize();
         }
 
-        int payloadLength = payloadData == null ? 0 : (short) payloadData.length;
+        int payloadLength = 0;
+        if (payloadData != null) {
+            payloadLength = payloadData.length;
+        }
 
         final byte[] data = new byte[HEADER_LENGTH + payloadLength];
         final ByteBuffer bb = ByteBuffer.wrap(data);

utils/misc/src/main/java/org/onlab/packet/ndp/RouterAdvertisement.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/ndp/RouterAdvertisement.java b/utils/misc/src/main/java/org/onlab/packet/ndp/RouterAdvertisement.java
index 7d36133..ce0c13b 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ndp/RouterAdvertisement.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ndp/RouterAdvertisement.java
@@ -165,7 +165,10 @@
             payloadData = this.payload.serialize();
         }
 
-        int payloadLength = payloadData == null ? 0 : (short) payloadData.length;
+        int payloadLength = 0;
+        if (payloadData != null) {
+            payloadLength = payloadData.length;
+        }
 
         final byte[] data = new byte[HEADER_LENGTH + payloadLength];
         final ByteBuffer bb = ByteBuffer.wrap(data);

utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java b/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java
index 5334d54..948b08a 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ndp/RouterSolicitation.java
@@ -38,7 +38,10 @@
             payloadData = this.payload.serialize();
         }
 
-        int payloadLength = payloadData == null ? 0 : (short) payloadData.length;
+        int payloadLength = 0;
+        if (payloadData != null) {
+            payloadLength = payloadData.length;
+        }
 
         final byte[] data = new byte[HEADER_LENGTH + payloadLength];
         final ByteBuffer bb = ByteBuffer.wrap(data);