removing some TODOs
Change-Id: Ic98c811573a1b37813993eedddec512ec85729f3
diff --git a/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java b/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java
index 044a60d..336c1d6 100644
--- a/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java
+++ b/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java
@@ -111,7 +111,6 @@
@Override
public void removeVertex(V vertex) {
- // TODO Auto-generated method stub
if (vertexes != null && edges != null) {
if (vertexes.contains(vertex)) {
vertexes.remove(vertex);
@@ -149,7 +148,6 @@
@Override
public Graph<V, E> toImmutable() {
- // TODO Auto-generated method stub
return null;
}
diff --git a/utils/misc/src/main/java/org/onlab/packet/BasePacket.java b/utils/misc/src/main/java/org/onlab/packet/BasePacket.java
index 46e3c7e..4aece66 100644
--- a/utils/misc/src/main/java/org/onlab/packet/BasePacket.java
+++ b/utils/misc/src/main/java/org/onlab/packet/BasePacket.java
@@ -118,9 +118,7 @@
} catch (final Exception e) {
throw new RuntimeException("Could not clone packet");
}
- // TODO: we are using serialize()/deserialize() to perform the
- // cloning. Not the most efficient way but simple. We can revisit
- // if we hit performance problems.
+
final byte[] data = this.serialize();
pkt.deserialize(this.serialize(), 0, data.length);
pkt.setParent(this.parent);
diff --git a/utils/misc/src/main/java/org/onlab/packet/ChassisId.java b/utils/misc/src/main/java/org/onlab/packet/ChassisId.java
index 85a3746..0d9f955 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ChassisId.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ChassisId.java
@@ -19,7 +19,6 @@
* The class representing a network device chassisId.
* This class is immutable.
*/
-// TODO: Move this to a reasonable place.
public final class ChassisId {
private static final long UNKNOWN = 0;
diff --git a/utils/misc/src/main/java/org/onlab/packet/IpAddress.java b/utils/misc/src/main/java/org/onlab/packet/IpAddress.java
index 10850b0..cd3a92f 100644
--- a/utils/misc/src/main/java/org/onlab/packet/IpAddress.java
+++ b/utils/misc/src/main/java/org/onlab/packet/IpAddress.java
@@ -262,7 +262,6 @@
*/
public static IpAddress makeMaskedAddress(final IpAddress address,
int prefixLength) {
- // TODO: The code below should go away and replaced with generics
if (address instanceof Ip4Address) {
Ip4Address ip4a = (Ip4Address) address;
return Ip4Address.makeMaskedAddress(ip4a, prefixLength);