removing some TODOs
Change-Id: Ic98c811573a1b37813993eedddec512ec85729f3
diff --git a/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java b/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java
index 044a60d..336c1d6 100644
--- a/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java
+++ b/utils/misc/src/main/java/org/onlab/graph/MutableAdjacencyListsGraph.java
@@ -111,7 +111,6 @@
@Override
public void removeVertex(V vertex) {
- // TODO Auto-generated method stub
if (vertexes != null && edges != null) {
if (vertexes.contains(vertex)) {
vertexes.remove(vertex);
@@ -149,7 +148,6 @@
@Override
public Graph<V, E> toImmutable() {
- // TODO Auto-generated method stub
return null;
}
diff --git a/utils/misc/src/main/java/org/onlab/packet/BasePacket.java b/utils/misc/src/main/java/org/onlab/packet/BasePacket.java
index 46e3c7e..4aece66 100644
--- a/utils/misc/src/main/java/org/onlab/packet/BasePacket.java
+++ b/utils/misc/src/main/java/org/onlab/packet/BasePacket.java
@@ -118,9 +118,7 @@
} catch (final Exception e) {
throw new RuntimeException("Could not clone packet");
}
- // TODO: we are using serialize()/deserialize() to perform the
- // cloning. Not the most efficient way but simple. We can revisit
- // if we hit performance problems.
+
final byte[] data = this.serialize();
pkt.deserialize(this.serialize(), 0, data.length);
pkt.setParent(this.parent);
diff --git a/utils/misc/src/main/java/org/onlab/packet/ChassisId.java b/utils/misc/src/main/java/org/onlab/packet/ChassisId.java
index 85a3746..0d9f955 100644
--- a/utils/misc/src/main/java/org/onlab/packet/ChassisId.java
+++ b/utils/misc/src/main/java/org/onlab/packet/ChassisId.java
@@ -19,7 +19,6 @@
* The class representing a network device chassisId.
* This class is immutable.
*/
-// TODO: Move this to a reasonable place.
public final class ChassisId {
private static final long UNKNOWN = 0;
diff --git a/utils/misc/src/main/java/org/onlab/packet/IpAddress.java b/utils/misc/src/main/java/org/onlab/packet/IpAddress.java
index 10850b0..cd3a92f 100644
--- a/utils/misc/src/main/java/org/onlab/packet/IpAddress.java
+++ b/utils/misc/src/main/java/org/onlab/packet/IpAddress.java
@@ -262,7 +262,6 @@
*/
public static IpAddress makeMaskedAddress(final IpAddress address,
int prefixLength) {
- // TODO: The code below should go away and replaced with generics
if (address instanceof Ip4Address) {
Ip4Address ip4a = (Ip4Address) address;
return Ip4Address.makeMaskedAddress(ip4a, prefixLength);
diff --git a/utils/netty/src/main/java/org/onlab/netty/NettyMessagingService.java b/utils/netty/src/main/java/org/onlab/netty/NettyMessagingService.java
index 771300f..52fa4d6 100644
--- a/utils/netty/src/main/java/org/onlab/netty/NettyMessagingService.java
+++ b/utils/netty/src/main/java/org/onlab/netty/NettyMessagingService.java
@@ -86,7 +86,6 @@
private void initEventLoopGroup() {
// try Epoll first and if that does work, use nio.
- // TODO: make this configurable.
try {
clientGroup = new EpollEventLoopGroup();
serverGroup = new EpollEventLoopGroup();
@@ -107,11 +106,9 @@
}
public NettyMessagingService() {
- // TODO: Default port should be configurable.
this(8080);
}
- // FIXME: Constructor should not throw exceptions.
public NettyMessagingService(int port) {
try {
localEp = new Endpoint(java.net.InetAddress.getLocalHost().getHostName(), port);
@@ -193,7 +190,6 @@
@Override
public void registerHandler(String type, MessageHandler handler) {
- // TODO: Is this the right semantics for handler registration?
handlers.putIfAbsent(type, handler);
}
@@ -210,7 +206,6 @@
ServerBootstrap b = new ServerBootstrap();
b.option(ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK, 32 * 1024);
b.option(ChannelOption.WRITE_BUFFER_LOW_WATER_MARK, 8 * 1024);
- // TODO: Need JVM options to configure PooledByteBufAllocator.
b.option(ChannelOption.ALLOCATOR, PooledByteBufAllocator.DEFAULT);
b.group(serverGroup, clientGroup)
.channel(serverChannelClass)
diff --git a/utils/thirdparty/src/main/java/org/onlab/thirdparty/OnlabThirdparty.java b/utils/thirdparty/src/main/java/org/onlab/thirdparty/OnlabThirdparty.java
index 7405558..217ee02 100644
--- a/utils/thirdparty/src/main/java/org/onlab/thirdparty/OnlabThirdparty.java
+++ b/utils/thirdparty/src/main/java/org/onlab/thirdparty/OnlabThirdparty.java
@@ -19,7 +19,7 @@
/**
* Empty class required to get the onlab-thirdparty module to build properly.
*
- * TODO Figure out how to remove this.
+ * NOTE Required for shade plugin to operate.
*/
public class OnlabThirdparty {