commit 3638de8eb1abdb135e1bee4ee4eb47dd439632d6
author Ray Milkey <ray@opennetworking.org> Fri Feb 01 12:51:45 2019 -0800
committer Ray Milkey <ray@opennetworking.org> Fri Feb 01 12:51:45 2019 -0800
tree c3eea2b8fccde32229d6a5af8e5339f12f28ca1b
parent 794d250740dcf2bdad65ad0f5ebe473d3093a266

Generate error log when unable to load app dependencies

Change-Id: I6303c6ff2e44834678948a89ef121fde754f22d9

core/store/dist/src/main/java/org/onosproject/store/app/DistributedApplicationStore.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/app/DistributedApplicationStore.java b/core/store/dist/src/main/java/org/onosproject/store/app/DistributedApplicationStore.java
index 7c0a4a9..2737b58 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/app/DistributedApplicationStore.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/app/DistributedApplicationStore.java
@@ -328,7 +328,12 @@
                         .noneMatch(requiredApp -> loadFromDisk(requiredApp) == null);
                 pendingApps.remove(appName);
 
-                return success ? create(appDesc, false) : null;
+                if (success) {
+                    return create(appDesc, false);
+                } else {
+                    log.error("Unable to load dependencies for application {}", appName);
+                    return null;
+                }
 
             } catch (Exception e) {
                 log.warn("Unable to load application {} from disk: {}; retrying",
@@ -339,6 +344,7 @@
             }
         }
         pendingApps.remove(appName);
+        log.error("Unable to load application {}", appName);
         return null;
     }