commit 33836dff2a56a5de8b47e96fbda73f082eaf8a51
author Qianqian Hu <Qianqian.Hu@alcatel-sbell.com.cn> Wed Dec 23 20:44:48 2015 +0800
committer Qianqian Hu <Qianqian.Hu@alcatel-sbell.com.cn> Thu Dec 24 05:37:37 2015 +0000
tree 6440fa81f0f06eb65acec2e9f48d2e8688201881
parent ac41bf7081ce84dfd55b0f2090393f0b4ae4e174

Fix bugs for AaaManger and RADIUS

Change-Id: I112a3207ccd9b580e59e8ec328cb6db1e32ca38a

apps/aaa/src/main/java/org/onosproject/aaa/AaaManager.java

diff --git a/apps/aaa/src/main/java/org/onosproject/aaa/AaaManager.java b/apps/aaa/src/main/java/org/onosproject/aaa/AaaManager.java
old mode 100644
new mode 100755
index 30ef879..0339a7e
--- a/apps/aaa/src/main/java/org/onosproject/aaa/AaaManager.java
+++ b/apps/aaa/src/main/java/org/onosproject/aaa/AaaManager.java
@@ -349,6 +349,16 @@
                     sendPacketToSupplicant(eth, stateMachine.supplicantConnectpoint());
 
                     break;
+                case EAPOL.EAPOL_LOGOFF:
+                    if (stateMachine.state() == stateMachine.STATE_AUTHORIZED) {
+                        try {
+                            stateMachine.logoff();
+                        } catch (StateMachineException e) {
+                            e.printStackTrace();
+                        }
+                    }
+
+                    break;
                 case EAPOL.EAPOL_PACKET:
                     RADIUS radiusPayload;
                     // check if this is a Response/Identify or  a Response/TLS
@@ -380,8 +390,10 @@
                                                          stateMachine.identifier(),
                                                          eapPacket);
 
-                                radiusPayload.setAttribute(RADIUSAttribute.RADIUS_ATTR_STATE,
-                                                           stateMachine.challengeState());
+                                if (stateMachine.challengeState() != null) {
+                                    radiusPayload.setAttribute(RADIUSAttribute.RADIUS_ATTR_STATE,
+                                            stateMachine.challengeState());
+                                }
                                 radiusPayload.addMessageAuthenticator(AaaManager.this.radiusSecret);
                                 sendRadiusPacket(radiusPayload);
                             }
@@ -390,8 +402,10 @@
                             // request id access to RADIUS
                             radiusPayload = getRadiusPayload(stateMachine, stateMachine.identifier(), eapPacket);
 
-                            radiusPayload.setAttribute(RADIUSAttribute.RADIUS_ATTR_STATE,
-                                    stateMachine.challengeState());
+                            if (stateMachine.challengeState() != null) {
+                                radiusPayload.setAttribute(RADIUSAttribute.RADIUS_ATTR_STATE,
+                                        stateMachine.challengeState());
+                            }
                             stateMachine.setRequestAuthenticator(radiusPayload.generateAuthCode());
 
                             radiusPayload.addMessageAuthenticator(AaaManager.this.radiusSecret);
@@ -432,8 +446,11 @@
             Ethernet eth;
             switch (radiusPacket.getCode()) {
                 case RADIUS.RADIUS_CODE_ACCESS_CHALLENGE:
-                    byte[] challengeState =
-                            radiusPacket.getAttribute(RADIUSAttribute.RADIUS_ATTR_STATE).getValue();
+                    RADIUSAttribute radiusAttrState = radiusPacket.getAttribute(RADIUSAttribute.RADIUS_ATTR_STATE);
+                    byte[] challengeState = null;
+                    if (radiusAttrState != null) {
+                        challengeState = radiusAttrState.getValue();
+                    }
                     eapPayload = radiusPacket.decapsulateMessage();
                     stateMachine.setChallengeInfo(eapPayload.getIdentifier(), challengeState);
                     eth = buildEapolResponse(stateMachine.supplicantAddress(),

utils/misc/src/main/java/org/onlab/packet/RADIUS.java

diff --git a/utils/misc/src/main/java/org/onlab/packet/RADIUS.java b/utils/misc/src/main/java/org/onlab/packet/RADIUS.java
index de0cb39..0a2b220 100644
--- a/utils/misc/src/main/java/org/onlab/packet/RADIUS.java
+++ b/utils/misc/src/main/java/org/onlab/packet/RADIUS.java
@@ -373,7 +373,7 @@
                 attr.value = new byte[attrLength - 2];
                 bb.get(attr.value, 0, attrLength - 2);
                 radius.attributes.add(attr);
-                remainingLength -= attr.length;
+                remainingLength -= attrLength;
             }
             return radius;
         };