Remove groupId casting to short from rest handler
Problem: The decoder in GroupCodec (used by the REST layer) chopped the
upper 16 bit in caller-provided group IDs. Since group IDs are
inherently greater than 16-bit on any OFDPA-based device, the current
casting rendered the REST layer unusable for such devices.
Fix: removed casting, verified that all tests pass, and verified that I
can now create healthy group entries on OFDPA-based switches.
Change-Id: Ieb51071ff9b0d47f4ff1f90d80970b6c0df946b7
diff --git a/core/common/src/main/java/org/onosproject/codec/impl/GroupCodec.java b/core/common/src/main/java/org/onosproject/codec/impl/GroupCodec.java
index 6a7e404..f6e3e9d 100644
--- a/core/common/src/main/java/org/onosproject/codec/impl/GroupCodec.java
+++ b/core/common/src/main/java/org/onosproject/codec/impl/GroupCodec.java
@@ -113,7 +113,7 @@
// parse group id
int groupIdInt = nullIsIllegal(json.get(GROUP_ID),
GROUP_ID + MISSING_MEMBER_MESSAGE).asInt();
- GroupId groupId = new DefaultGroupId((short) groupIdInt);
+ GroupId groupId = new DefaultGroupId(groupIdInt);
// parse group key (appCookie)
String groupKeyStr = nullIsIllegal(json.get(APP_COOKIE),