Fix port speed
According to OF 1.3 spec, the unit of current speed should be kbps instead of mbps
Change-Id: I68f30f551afd6c8a8030e0a817ff009595113a84
diff --git a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
index fd3b638..c6a4440 100644
--- a/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
+++ b/providers/openflow/device/src/main/java/org/onosproject/provider/of/device/impl/OpenFlowDeviceProvider.java
@@ -120,6 +120,8 @@
private static final Logger LOG = getLogger(OpenFlowDeviceProvider.class);
+ //TODO consider renaming KBPS and MBPS (as they are used to convert by division)
+ private static final long KBPS = 1_000;
private static final long MBPS = 1_000 * 1_000;
private static final Frequency FREQ100 = Frequency.ofGHz(100);
private static final Frequency FREQ193_1 = Frequency.ofTHz(193.1);
@@ -669,7 +671,8 @@
private long portSpeed(OFPortDesc port) {
if (port.getVersion() == OFVersion.OF_13) {
- return port.getCurrSpeed() / MBPS;
+ // Note: getCurrSpeed() returns a value in kbps (this also applies to OF_11 and OF_12)
+ return port.getCurrSpeed() / KBPS;
}
PortSpeed portSpeed = PortSpeed.SPEED_NONE;