commit 22619171cb5596115e9c7fcf7dc53d1eb6d86a61
author Carmelo Cascone <carmelo@opennetworking.org> Thu Jul 13 16:08:17 2017 -0400
committer Carmelo Cascone <carmelo@opennetworking.org> Thu Jul 13 21:42:11 2017 +0000
tree 35b1edb11f3fae78de801ddedca55e62fa7a1626
parent 28c3daa87ff6c0c086357b6cceacbd8733d03a78

Fix equality in PiCriterion

Needs updating the rest of equality checks in PiCriteriaTest

Change-Id: Idacc05df3c984c8d3488e0bc7435159354c2cfb1

core/api/src/main/java/org/onosproject/net/flow/criteria/PiCriterion.java

diff --git a/core/api/src/main/java/org/onosproject/net/flow/criteria/PiCriterion.java b/core/api/src/main/java/org/onosproject/net/flow/criteria/PiCriterion.java
index c9335c2..483b312 100644
--- a/core/api/src/main/java/org/onosproject/net/flow/criteria/PiCriterion.java
+++ b/core/api/src/main/java/org/onosproject/net/flow/criteria/PiCriterion.java
@@ -18,6 +18,7 @@
 
 import com.google.common.annotations.Beta;
 import com.google.common.base.Objects;
+import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Maps;
 import org.onosproject.net.pi.runtime.PiFieldMatch;
 import org.onosproject.net.pi.runtime.PiHeaderFieldId;
@@ -29,25 +30,26 @@
 
 import java.util.Collection;
 import java.util.Map;
+import java.util.Set;
 import java.util.StringJoiner;
 
 import static com.google.common.base.Preconditions.checkArgument;
 import static org.onlab.util.ImmutableByteSequence.copyFrom;
 
 /**
- * Protocol-indepedent criterion.
+ * Protocol-independent criterion.
  */
 @Beta
 public final class PiCriterion implements Criterion {
 
-    private final Collection<PiFieldMatch> fieldMatches;
+    private final Set<PiFieldMatch> fieldMatches;
 
     /**
      * Creates a new protocol-independent criterion for the given match fields.
      *
      * @param fieldMatches fields to match
      */
-    private PiCriterion(Collection<PiFieldMatch> fieldMatches) {
+    private PiCriterion(Set<PiFieldMatch> fieldMatches) {
         this.fieldMatches = fieldMatches;
     }
 
@@ -104,6 +106,7 @@
     @Beta
     public static final class Builder {
 
+        // Use map to guarantee that there's only one field match per field id.
         private final Map<PiHeaderFieldId, PiFieldMatch> piFieldMatches = Maps.newHashMap();
 
         private Builder() {
@@ -331,7 +334,7 @@
          */
         public Criterion build() {
             checkArgument(piFieldMatches.size() > 0);
-            return new PiCriterion(piFieldMatches.values());
+            return new PiCriterion(ImmutableSet.copyOf(piFieldMatches.values()));
         }
     }
 }
\ No newline at end of file

core/api/src/test/java/org/onosproject/net/flow/criteria/PiCriteriaTest.java

diff --git a/core/api/src/test/java/org/onosproject/net/flow/criteria/PiCriteriaTest.java b/core/api/src/test/java/org/onosproject/net/flow/criteria/PiCriteriaTest.java
index d1f30e1..cf32d66 100644
--- a/core/api/src/test/java/org/onosproject/net/flow/criteria/PiCriteriaTest.java
+++ b/core/api/src/test/java/org/onosproject/net/flow/criteria/PiCriteriaTest.java
@@ -488,7 +488,7 @@
     @Test
     public void testPiExactCriterionEquals() {
         new EqualsTester()
-                .addEqualityGroup(matchPiExactByte1)
+                .addEqualityGroup(matchPiExactByte1, sameAsMatchPiExactByte1)
                 .addEqualityGroup(matchPiExactByte2)
                 .testEquals();