commit 215a7e47f6efa8e1dd9381abc65a9d605078463f
author Yuta HIGUCHI <y-higuchi@ak.jp.nec.com> Wed Jul 20 19:54:06 2016 -0700
committer Yuta HIGUCHI <y-higuchi@onlab.us> Thu Jul 21 23:05:30 2016 +0000
tree c6a9d1065801f65099895451f11147d52947ad08
parent eb851cdefd0d2ab8bccdaa3f8a9609babc6c8dd4

DistHostStore: HOST_MOVED based on distributed state

- Use information in the distributed Map to determine
 if the Host has moved instead of instance local cache view.

Change-Id: I374e7cf9f4f03451770b137ef2e835e6c578a463

core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java

diff --git a/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java b/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java
index 0e69e8e..b4449ae 100644
--- a/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java
+++ b/core/store/dist/src/main/java/org/onosproject/store/host/impl/DistributedHostStore.java
@@ -55,7 +55,6 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
-import java.util.concurrent.ConcurrentHashMap;
 import java.util.function.Predicate;
 import java.util.stream.Collectors;
 
@@ -82,9 +81,6 @@
     private ConsistentMap<HostId, DefaultHost> hostsConsistentMap;
     private Map<HostId, DefaultHost> hosts;
 
-    private final ConcurrentHashMap<HostId, DefaultHost> prevHosts =
-            new ConcurrentHashMap<>();
-
     private MapEventListener<HostId, DefaultHost> hostLocationTracker =
             new HostLocationTracker();
 
@@ -101,7 +97,6 @@
 
         hosts = hostsConsistentMap.asJavaMap();
 
-        prevHosts.putAll(hosts);
 
         hostsConsistentMap.addListener(hostLocationTracker);
 
@@ -111,7 +106,6 @@
     @Deactivate
     public void deactivate() {
         hostsConsistentMap.removeListener(hostLocationTracker);
-        prevHosts.clear();
 
         log.info("Stopped");
     }
@@ -283,13 +277,15 @@
     private class HostLocationTracker implements MapEventListener<HostId, DefaultHost> {
         @Override
         public void event(MapEvent<HostId, DefaultHost> event) {
-            DefaultHost host = checkNotNull(event.value().value());
-            Host prevHost = prevHosts.put(host.id(), host);
+            Host host;
             switch (event.type()) {
                 case INSERT:
+                    host = checkNotNull(event.newValue().value());
                     notifyDelegate(new HostEvent(HOST_ADDED, host));
                     break;
                 case UPDATE:
+                    host = checkNotNull(event.newValue().value());
+                    Host prevHost = checkNotNull(event.oldValue().value());
                     if (!Objects.equals(prevHost.location(), host.location())) {
                         notifyDelegate(new HostEvent(HOST_MOVED, host, prevHost));
                     } else if (!Objects.equals(prevHost, host)) {
@@ -297,9 +293,8 @@
                     }
                     break;
                 case REMOVE:
-                    if (prevHosts.remove(host.id()) != null) {
-                        notifyDelegate(new HostEvent(HOST_REMOVED, host));
-                    }
+                    host = checkNotNull(event.oldValue().value());
+                    notifyDelegate(new HostEvent(HOST_REMOVED, host));
                     break;
                 default:
                     log.warn("Unknown map event type: {}", event.type());