commit 10b69e8d673c34ce5f339cf62c7df582d74aeb90
author Yi Tseng <a86487817@gmail.com> Wed Jun 14 13:23:19 2017 -0700
committer Andrea Campanella <andrea@onlab.us> Thu Jun 15 08:35:47 2017 +0000
tree d38cedf0ef24afa35defc809d6971d9ba954fcf0
parent 2162993bee617c32dbc0f90ac139354d573eac41

Avoid multi-thread issue of encoding the installable Intents to json

ArrayNode uses ArrayList to store data, which is not thread-safe

Change-Id: Id3e54afdf036cbab0909b08b094a2c52124b6bb9

core/common/src/main/java/org/onosproject/codec/impl/IntentCodec.java

diff --git a/core/common/src/main/java/org/onosproject/codec/impl/IntentCodec.java b/core/common/src/main/java/org/onosproject/codec/impl/IntentCodec.java
index b21ca4e..ed20958 100644
--- a/core/common/src/main/java/org/onosproject/codec/impl/IntentCodec.java
+++ b/core/common/src/main/java/org/onosproject/codec/impl/IntentCodec.java
@@ -68,15 +68,13 @@
         final ArrayNode jsonResources = result.putArray(RESOURCES);
 
         intent.resources()
-                .parallelStream()
-                .forEach(
-                        resource -> {
-                            if (resource instanceof Link) {
-                                jsonResources.add(context.codec(Link.class).encode((Link) resource, context));
-                            } else {
-                                jsonResources.add(resource.toString());
-                            }
-                        });
+                .forEach(resource -> {
+                    if (resource instanceof Link) {
+                        jsonResources.add(context.codec(Link.class).encode((Link) resource, context));
+                    } else {
+                        jsonResources.add(resource.toString());
+                    }
+                });
 
         IntentService service = context.getService(IntentService.class);
         IntentState state = service.getIntentState(intent.key());