commit 6642333ed2654d1faf749115e858e501ed4f5965
author Felix Meschberger <fmeschbe@apache.org> Wed Aug 22 08:46:34 2007 +0000
committer Felix Meschberger <fmeschbe@apache.org> Wed Aug 22 08:46:34 2007 +0000
tree e6be780b837ff7e87d69d1b4b331fd3a94ed7f7c
parent f0e721459801167c2f842d6e3236562899dd8b13

FELIX-342 NullPointerException after updating a ManagedService when no Configuration exists

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@568514 13f79535-47bb-0310-9956-ffa450edef68

configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java

diff --git a/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java b/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java
index e0a9a76..5a92dd2 100644
--- a/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java
+++ b/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java
@@ -459,10 +459,10 @@
     }
 
 
-    void fireConfigurationEvent( int type, ConfigurationImpl config )
+    void fireConfigurationEvent( int type, String pid, String factoryPid )
     {
 
-        updateThread.schedule( new FireConfigurationEvent( type, config ) );
+        updateThread.schedule( new FireConfigurationEvent( type, pid, factoryPid) );
     }
 
 
@@ -895,7 +895,7 @@
 
             // 104.5.3 CM_UPDATED is sent asynchronously to all
             // ConfigurationListeners
-            fireConfigurationEvent( ConfigurationEvent.CM_UPDATED, cfg );
+            fireConfigurationEvent( ConfigurationEvent.CM_UPDATED, pid, null );
         }
     }
 
@@ -1154,18 +1154,21 @@
                 log( LogService.LOG_ERROR, "Unexpected problem updating configuration", t );
             }
 
-            fireConfigurationEvent( ConfigurationEvent.CM_UPDATED, config );
+            fireConfigurationEvent( ConfigurationEvent.CM_UPDATED, config.getPid(), config.getFactoryPid() );
         }
     }
 
     private class DeleteConfiguration implements Runnable
     {
-        private ConfigurationImpl config;
+
+        private String pid;
+        private String factoryPid;
 
 
         DeleteConfiguration( ConfigurationImpl config )
         {
-            this.config = config;
+            this.pid = config.getPid();
+            this.factoryPid = config.getFactoryPid();
         }
 
 
@@ -1173,10 +1176,10 @@
         {
             try
             {
-                if ( config.getFactoryPid() == null )
+                if ( factoryPid == null )
                 {
                     ServiceReference[] sr = bundleContext.getServiceReferences( ManagedService.class.getName(), "("
-                        + Constants.SERVICE_PID + "=" + config.getPid() + ")" );
+                        + Constants.SERVICE_PID + "=" + pid + ")" );
                     if ( sr != null && sr.length > 0 )
                     {
                         ManagedService srv = ( ManagedService ) bundleContext.getService( sr[0] );
@@ -1193,18 +1196,18 @@
                 else
                 {
                     // remove the pid from the factory
-                    Factory factory = getFactory( config.getFactoryPid() );
-                    factory.removePID( config.getPid() );
+                    Factory factory = getFactory( factoryPid );
+                    factory.removePID( pid );
                     factory.store();
 
                     ServiceReference[] sr = bundleContext.getServiceReferences( ManagedServiceFactory.class.getName(),
-                        "(" + Constants.SERVICE_PID + "=" + config.getFactoryPid() + ")" );
+                        "(" + Constants.SERVICE_PID + "=" + factoryPid + ")" );
                     if ( sr != null && sr.length > 0 )
                     {
                         ManagedServiceFactory srv = ( ManagedServiceFactory ) bundleContext.getService( sr[0] );
                         try
                         {
-                            srv.deleted( config.getPid() );
+                            srv.deleted( pid );
                         }
                         finally
                         {
@@ -1231,7 +1234,7 @@
                 log( LogService.LOG_ERROR, "Unexpected problem updating configuration", t );
             }
 
-            fireConfigurationEvent( ConfigurationEvent.CM_DELETED, config );
+            fireConfigurationEvent( ConfigurationEvent.CM_DELETED, pid, factoryPid );
         }
     }
 
@@ -1239,13 +1242,16 @@
     {
         private int type;
 
-        private ConfigurationImpl config;
+        private String pid;
+        
+        private String factoryPid;
 
 
-        FireConfigurationEvent( int type, ConfigurationImpl config )
+        FireConfigurationEvent( int type, String pid, String factoryPid )
         {
             this.type = type;
-            this.config = config;
+            this.pid = pid;
+            this.factoryPid = factoryPid;
         }
 
 
@@ -1258,8 +1264,7 @@
                 return;
             }
 
-            ConfigurationEvent event = new ConfigurationEvent( configurationAdminReference, type, config
-                .getFactoryPid(), config.getPid() );
+            ConfigurationEvent event = new ConfigurationEvent( configurationAdminReference, type, factoryPid, pid);
 
             for ( int i = 0; i < srs.length; i++ )
             {