commit 31433e5aa879a456b529274139a6c3e92507644d
author Carsten Ziegeler <cziegeler@apache.org> Mon Jul 28 12:47:27 2014 +0000
committer Carsten Ziegeler <cziegeler@apache.org> Mon Jul 28 12:47:27 2014 +0000
tree 6d7df5dc10c56ff1219e4e28cfe00284b534a21d
parent aaabed4d6de561ca8f552c218d46f029dfba7db1

FELIX-4586 : A field must be volatile if methods are generated for a dynamic reference

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1613989 13f79535-47bb-0310-9956-ffa450edef68

scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java

diff --git a/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java b/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
index 29ba89d..e6b1394 100644
--- a/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
+++ b/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
@@ -503,11 +503,6 @@
                             if (!fieldIsVolatile) {
                                 this.logError(ref, "Dynamic field must be declared volatile for unary references");
                             }
-                        } else {
-                            // field should be volatile
-                            if (!fieldIsVolatile) {
-                                this.logError(ref, "Dynamic field should be declared volatile for unary references");
-                            }
                         }
                     }
                 }