Devin Lim | e1346f4 | 2018-05-15 15:41:36 -0700 | [diff] [blame] | 1 | #!groovy |
| 2 | |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 3 | // Copyright 2017 Open Networking Foundation (ONF) |
| 4 | // |
| 5 | // Please refer questions to either the onos test mailing list at <onos-test@onosproject.org>, |
| 6 | // the System Testing Plans and Results wiki page at <https://wiki.onosproject.org/x/voMg>, |
| 7 | // or the System Testing Guide page at <https://wiki.onosproject.org/x/WYQg> |
| 8 | // |
| 9 | // TestON is free software: you can redistribute it and/or modify |
| 10 | // it under the terms of the GNU General Public License as published by |
| 11 | // the Free Software Foundation, either version 2 of the License, or |
| 12 | // (at your option) any later version. |
| 13 | // |
| 14 | // TestON is distributed in the hope that it will be useful, |
| 15 | // but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 16 | // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 17 | // GNU General Public License for more details. |
| 18 | // |
| 19 | // You should have received a copy of the GNU General Public License |
| 20 | // along with TestON. If not, see <http://www.gnu.org/licenses/>. |
| 21 | |
| 22 | // This is the dependency Jenkins script. |
| 23 | // This will provide the portion that will set up the environment of the machine |
| 24 | // and trigger the corresponding jobs. |
| 25 | |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 26 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 27 | def init( commonFuncs ){ |
| 28 | funcs = commonFuncs |
| 29 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 30 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 31 | def lastCommaRemover( str ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 32 | // function that will remove the last comma from the string |
| 33 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 34 | if ( str.size() > 0 && str[ str.size() - 1 ] == ',' ){ |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 35 | str = str.substring( 0, str.size() - 1 ) |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 36 | } |
| 37 | return str |
| 38 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 39 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 40 | def printDaysForTest( AllTheTests ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 41 | // Print the days for what test has. |
| 42 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 43 | result = "" |
| 44 | for ( String test in AllTheTests.keySet() ){ |
| 45 | result += test + " : \n" |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 46 | for ( String each in AllTheTests[ test ].keySet() ){ |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 47 | AllTheTests[ test ][ each ][ "day" ] = lastCommaRemover( AllTheTests[ test ][ each ][ "day" ] ) |
| 48 | result += " " + each + ":[" + AllTheTests[ test ][ each ][ "day" ] + "]\n" |
| 49 | } |
| 50 | result += "\n" |
| 51 | } |
| 52 | return result |
| 53 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 54 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 55 | def runTestSeq( testList ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 56 | // Running the test sequentially |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 57 | return { |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 58 | for ( test in testList.keySet() ){ |
| 59 | testList[ test ].call() |
| 60 | } |
| 61 | } |
| 62 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 63 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 64 | def print_tests( tests ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 65 | // print the list of the tsets to be run |
| 66 | |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 67 | for ( String test in tests.keySet() ){ |
| 68 | if ( tests[ test ][ "tests" ] != "" ){ |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 69 | println test + ":" |
| 70 | println tests[ test ][ "tests" ] |
| 71 | } |
| 72 | } |
| 73 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 74 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 75 | def organize_tests( tests, testcases ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 76 | // organize the test to its category using its name. |
| 77 | // most of the time it will use the first two character of the test name |
| 78 | // but there are some exceptions like FUNCbgpls or FUNCvirNetNB since they are now under USECASE |
| 79 | |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 80 | // depends on the first two letters of the test name, it will decide which category to put the test into. |
| 81 | def prefixes = [ |
| 82 | "FU": "FUNC", |
| 83 | "HA": "HA", |
| 84 | "PL": "USECASE", |
| 85 | "SA": "USECASE", |
| 86 | "SC": "SCPF", |
| 87 | "SR": "SR", |
| 88 | "US": "USECASE", |
| 89 | "VP": "USECASE" |
| 90 | ] |
| 91 | |
| 92 | def testList = tests.tokenize( "\n;, " ) |
| 93 | for ( String test in testList ){ |
| 94 | String prefix = ( test == "FUNCbgpls" || test == "FUNCvirNetNB" ) ? "US" : ( test[ 0..1 ] ) |
| 95 | testcases[ prefixes[ prefix ] ][ "tests" ] += test + "," |
| 96 | } |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 97 | return testcases |
| 98 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 99 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 100 | def trigger( branch, tests, nodeName, jobOn, manuallyRun, onosTag ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 101 | // triggering function that will setup the environment and determine which pipeline to trigger |
| 102 | |
You Wang | 49461a8 | 2018-08-02 13:15:30 -0700 | [diff] [blame] | 103 | println "Job name: " + jobOn + "-pipeline-" + ( manuallyRun ? "manually" : branch ) |
Devin Lim | 6c77b7c | 2018-04-06 19:36:56 -0700 | [diff] [blame] | 104 | def wiki = branch |
You Wang | f7a0752 | 2018-08-02 14:23:25 -0700 | [diff] [blame] | 105 | def onos_branch = funcs.branchWithPrefix( branch ) |
| 106 | def test_branch = funcs.testBranchWithPrefix( branch ) |
You Wang | 49461a8 | 2018-08-02 13:15:30 -0700 | [diff] [blame] | 107 | println "onos_branch with prefix: " + onos_branch |
| 108 | println "test_branch with prefix: " + test_branch |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 109 | node( "TestStation-" + nodeName + "s" ) { |
You Wang | 7952750 | 2018-08-02 12:18:20 -0700 | [diff] [blame] | 110 | envSetup( onos_branch, test_branch, onosTag, jobOn, manuallyRun ) |
| 111 | exportEnvProperty( onos_branch, test_branch, wiki, tests, post_result, manuallyRun, onosTag, isOldFlow ) |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 112 | } |
| 113 | |
| 114 | jobToRun = jobOn + "-pipeline-" + ( manuallyRun ? "manually" : wiki ) |
| 115 | build job: jobToRun, propagate: false |
| 116 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 117 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 118 | def trigger_pipeline( branch, tests, nodeName, jobOn, manuallyRun, onosTag ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 119 | // nodeName : "BM" or "VM" |
| 120 | // jobOn : "SCPF" or "USECASE" or "FUNC" or "HA" |
| 121 | // this will return the function by wrapping them up with return{} to prevent them to be |
| 122 | // executed once this function is called to assign to specific variable. |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 123 | return { |
Devin Lim | 5b22fbb | 2018-04-06 15:30:45 -0700 | [diff] [blame] | 124 | trigger( branch, tests, nodeName, jobOn, manuallyRun, onosTag ) |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 125 | } |
| 126 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 127 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 128 | // export Environment properties. |
| 129 | def exportEnvProperty( onos_branch, test_branch, wiki, tests, postResult, manually_run, onosTag, isOldFlow ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 130 | // export environment properties to the machine. |
| 131 | |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 132 | stage( "export Property" ) { |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 133 | sh ''' |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 134 | echo "ONOSBranch=''' + onos_branch + '''" > /var/jenkins/TestONOS.property |
| 135 | echo "TestONBranch=''' + test_branch + '''" >> /var/jenkins/TestONOS.property |
| 136 | echo "ONOSTag=''' + onosTag + '''" >> /var/jenkins/TestONOS.property |
| 137 | echo "WikiPrefix=''' + wiki + '''" >> /var/jenkins/TestONOS.property |
You Wang | 8e4f4c0 | 2019-01-03 10:49:46 -0800 | [diff] [blame] | 138 | echo "ONOSJAVAOPTS=''' + env.ONOSJAVAOPTS + '''" >> /var/jenkins/TestONOS.property |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 139 | echo "Tests=''' + tests + '''" >> /var/jenkins/TestONOS.property |
| 140 | echo "postResult=''' + postResult + '''" >> /var/jenkins/TestONOS.property |
| 141 | echo "manualRun=''' + manually_run + '''" >> /var/jenkins/TestONOS.property |
| 142 | echo "isOldFlow=''' + isOldFlow + '''" >> /var/jenkins/TestONOS.property |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 143 | ''' |
| 144 | } |
| 145 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 146 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 147 | // Initialize the environment Setup for the onos and OnosSystemTest |
| 148 | def envSetup( onos_branch, test_branch, onos_tag, jobOn, manuallyRun ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 149 | // to setup the environment using the bash script |
You Wang | 49461a8 | 2018-08-02 13:15:30 -0700 | [diff] [blame] | 150 | println "onos_branch is set to " + onos_branch |
| 151 | println "test_branch is set to " + test_branch |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 152 | stage( "envSetup" ) { |
| 153 | // after env: ''' + borrow_mn( jobOn ) + ''' |
| 154 | sh '''#!/bin/bash -l |
| 155 | set +e |
| 156 | . ~/.bashrc |
| 157 | env |
| 158 | ''' + preSetup( onos_branch, test_branch, onos_tag, manuallyRun ) + ''' |
| 159 | ''' + oldFlowCheck( jobOn, onos_branch ) + ''' |
| 160 | ''' + postSetup( onos_branch, test_branch, onos_tag, manuallyRun ) |
Devin Lim | 90b6a59 | 2018-05-09 13:20:33 -0700 | [diff] [blame] | 161 | generateKey() |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 162 | } |
| 163 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 164 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 165 | def tagCheck( onos_tag, onos_branch ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 166 | // check the tag for onos if it is not empty |
| 167 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 168 | result = "git checkout " |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 169 | if ( onos_tag == "" ){ |
| 170 | //create new local branch |
| 171 | result += onos_branch |
| 172 | } |
| 173 | else { |
| 174 | //checkout the tag |
| 175 | result += onos_tag |
| 176 | } |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 177 | return result |
| 178 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 179 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 180 | def preSetup( onos_branch, test_branch, onos_tag, isManual ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 181 | // pre setup part which will clean up and checkout to corresponding branch. |
| 182 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 183 | result = "" |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 184 | if ( !isManual ){ |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 185 | result = '''echo -e "\n##### Set TestON Branch #####" |
| 186 | echo "TestON Branch is set on: ''' + test_branch + '''" |
| 187 | cd ~/OnosSystemTest/ |
| 188 | git checkout HEAD~1 # Make sure you aren't pn a branch |
| 189 | git branch | grep -v "detached from" | xargs git branch -d # delete all local branches merged with remote |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 190 | git branch -D ''' + test_branch + ''' # just in case there are local changes. This will normally result in a branch not found error |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 191 | git clean -df # clean any local files |
| 192 | git fetch --all # update all caches from remotes |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 193 | git reset --hard origin/''' + test_branch + ''' # force local index to match remote branch |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 194 | git clean -df # clean any local files |
| 195 | git checkout ''' + test_branch + ''' #create new local branch |
| 196 | git branch |
| 197 | git log -1 --decorate |
| 198 | echo -e "\n##### Set ONOS Branch #####" |
| 199 | echo "ONOS Branch is set on: ''' + onos_branch + '''" |
| 200 | echo -e "\n #### check karaf version ######" |
| 201 | env |grep karaf |
| 202 | cd ~/onos |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 203 | git checkout HEAD~1 # Make sure you aren't pn a branch |
| 204 | git branch | grep -v "detached from" | xargs git branch -d # delete all local branches merged with remote |
| 205 | git branch -D ''' + onos_branch + ''' # just incase there are local changes. This will normally result in a branch not found error |
| 206 | git clean -df # clean any local files |
| 207 | git fetch --all # update all caches from remotes |
| 208 | git reset --hard origin/''' + onos_branch + ''' # force local index to match remote branch |
| 209 | git clean -df # clean any local files |
Jon Hall | 5b05626 | 2018-09-25 11:44:41 -0700 | [diff] [blame] | 210 | rm -rf buck-out |
| 211 | rm -rf bazel-* |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 212 | ''' + tagCheck( onos_tag, onos_branch ) + ''' |
| 213 | git branch |
| 214 | git log -1 --decorate |
| 215 | echo -e "\n##### set jvm heap size to 8G #####" |
You Wang | 8e4f4c0 | 2019-01-03 10:49:46 -0800 | [diff] [blame] | 216 | echo ${ONOSJAVAOPTS} |
| 217 | inserted_line="export JAVA_OPTS=\"\${ONOSJAVAOPTS}\"" |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 218 | sed -i "s/bash/bash\\n$inserted_line/" ~/onos/tools/package/bin/onos-service |
| 219 | echo "##### Check onos-service setting..... #####" |
| 220 | cat ~/onos/tools/package/bin/onos-service |
| 221 | export JAVA_HOME=/usr/lib/jvm/java-8-oracle''' |
| 222 | } |
| 223 | return result |
| 224 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 225 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 226 | def oldFlowCheck( jobOn, onos_branch ){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 227 | // part that will check if it is oldFlow. If so, it will switch to use old flow. Only affected with SCPF. |
| 228 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 229 | result = "" |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 230 | if ( jobOn == "SCPF" && ( onos_branch == "master" || onos_branch == "onos-1.12" ) ) |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 231 | result = '''sed -i -e 's/@Component(immediate = true)/@Component(enabled = false)/g' ~/onos/core/store/dist/src/main/java/org/onosproject/store/flow/impl/''' + ( isOldFlow ? "DistributedFlowRuleStore" : "ECFlowRuleStore" ) + '''.java |
| 232 | sed -i -e 's/@Component(enabled = false)/@Component(immediate = true)/g' ~/onos/core/store/dist/src/main/java/org/onosproject/store/flow/impl/''' + ( isOldFlow ? "ECFlowRuleStore" : "DistributedFlowRuleStore" ) + ".java" |
| 233 | return result |
| 234 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 235 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 236 | def postSetup( onos_branch, test_branch, onos_tag, isManual ){ |
Jon Hall | 3e6edb3 | 2018-08-21 16:20:30 -0700 | [diff] [blame] | 237 | // setup that will build ONOS |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 238 | |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 239 | result = "" |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 240 | if ( !isManual ){ |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 241 | result = '''echo -e "\n##### build ONOS skip unit tests ######" |
Jon Hall | 3e6edb3 | 2018-08-21 16:20:30 -0700 | [diff] [blame] | 242 | cd ~/onos |
| 243 | . tools/dev/bash_profile |
| 244 | op |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 245 | sleep 30 |
| 246 | echo -e "\n##### Stop all running instances of Karaf #####" |
| 247 | kill $(ps -efw | grep karaf | grep -v grep | awk '{print $2}') |
| 248 | sleep 30 |
Devin Lim | 2d7371a | 2018-05-08 18:02:05 -0700 | [diff] [blame] | 249 | git branch |
Devin Lim | 2d7371a | 2018-05-08 18:02:05 -0700 | [diff] [blame] | 250 | ''' |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 251 | } |
| 252 | return result |
| 253 | } |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 254 | |
Devin Lim | 90b6a59 | 2018-05-09 13:20:33 -0700 | [diff] [blame] | 255 | def generateKey(){ |
Devin Lim | f517519 | 2018-05-14 19:13:22 -0700 | [diff] [blame] | 256 | // generate cluster-key of the onos |
| 257 | |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 258 | try { |
Devin Lim | 018203a | 2018-05-09 11:33:20 -0700 | [diff] [blame] | 259 | sh ''' |
| 260 | #!/bin/bash -l |
| 261 | set +e |
| 262 | . ~/.bashrc |
| 263 | env |
Devin Lim | 90b6a59 | 2018-05-09 13:20:33 -0700 | [diff] [blame] | 264 | onos-push-bits-through-proxy |
| 265 | onos-gen-cluster-key -f |
Devin Lim | 018203a | 2018-05-09 11:33:20 -0700 | [diff] [blame] | 266 | ''' |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 267 | } catch ( all ){ |
| 268 | } |
Devin Lim | 018203a | 2018-05-09 11:33:20 -0700 | [diff] [blame] | 269 | } |
Devin Lim | 431408d | 2018-03-23 17:51:31 -0700 | [diff] [blame] | 270 | |
Jon Hall | 6af749d | 2018-05-29 12:59:47 -0700 | [diff] [blame] | 271 | return this |