Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 1 | package net.onrc.onos.ofcontroller.proxyarp; |
| 2 | |
| 3 | import java.io.IOException; |
| 4 | import java.net.InetAddress; |
| 5 | import java.net.UnknownHostException; |
| 6 | import java.util.ArrayList; |
| 7 | import java.util.Collection; |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 8 | import java.util.Iterator; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 9 | import java.util.List; |
| 10 | import java.util.Map; |
| 11 | import java.util.Set; |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 12 | import java.util.Timer; |
| 13 | import java.util.TimerTask; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 14 | |
| 15 | import net.floodlightcontroller.core.FloodlightContext; |
| 16 | import net.floodlightcontroller.core.IFloodlightProviderService; |
| 17 | import net.floodlightcontroller.core.IOFMessageListener; |
| 18 | import net.floodlightcontroller.core.IOFSwitch; |
| 19 | import net.floodlightcontroller.packet.ARP; |
| 20 | import net.floodlightcontroller.packet.Ethernet; |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 21 | import net.floodlightcontroller.packet.IPv4; |
Jonathan Hart | 5afde49 | 2013-10-01 12:30:53 +1300 | [diff] [blame] | 22 | import net.floodlightcontroller.restserver.IRestApiService; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 23 | import net.floodlightcontroller.topology.ITopologyService; |
Jonathan Hart | 8ec133c | 2013-06-26 15:25:18 +1200 | [diff] [blame] | 24 | import net.floodlightcontroller.util.MACAddress; |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 25 | import net.onrc.onos.ofcontroller.bgproute.ILayer3InfoService; |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 26 | import net.onrc.onos.ofcontroller.bgproute.Interface; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 27 | |
| 28 | import org.openflow.protocol.OFMessage; |
| 29 | import org.openflow.protocol.OFPacketIn; |
| 30 | import org.openflow.protocol.OFPacketOut; |
| 31 | import org.openflow.protocol.OFPort; |
| 32 | import org.openflow.protocol.OFType; |
| 33 | import org.openflow.protocol.action.OFAction; |
| 34 | import org.openflow.protocol.action.OFActionOutput; |
Jonathan Hart | 8ec133c | 2013-06-26 15:25:18 +1200 | [diff] [blame] | 35 | import org.openflow.util.HexString; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 36 | import org.slf4j.Logger; |
| 37 | import org.slf4j.LoggerFactory; |
| 38 | |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 39 | import com.google.common.collect.HashMultimap; |
| 40 | import com.google.common.collect.Multimaps; |
| 41 | import com.google.common.collect.SetMultimap; |
| 42 | |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 43 | public class ProxyArpManager implements IProxyArpService, IOFMessageListener { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 44 | private final static Logger log = LoggerFactory.getLogger(ProxyArpManager.class); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 45 | |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 46 | private final long ARP_TIMER_PERIOD = 60000; //ms (== 1 min) |
Jonathan Hart | da4d0e1 | 2013-09-30 21:00:20 +1300 | [diff] [blame] | 47 | |
| 48 | private static final int ARP_REQUEST_TIMEOUT = 2000; //ms |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 49 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 50 | private final IFloodlightProviderService floodlightProvider; |
| 51 | private final ITopologyService topology; |
| 52 | private final ILayer3InfoService layer3; |
Jonathan Hart | 5afde49 | 2013-10-01 12:30:53 +1300 | [diff] [blame] | 53 | private final IRestApiService restApi; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 54 | |
Jonathan Hart | 1cf9de0 | 2013-10-21 17:42:29 -0700 | [diff] [blame] | 55 | private short vlan; |
| 56 | private static final short NO_VLAN = 0; |
| 57 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 58 | private final ArpCache arpCache; |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 59 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 60 | private final SetMultimap<InetAddress, ArpRequest> arpRequests; |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 61 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 62 | private static class ArpRequest { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 63 | private final IArpRequester requester; |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 64 | private final boolean retry; |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 65 | private long requestTime; |
| 66 | |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 67 | public ArpRequest(IArpRequester requester, boolean retry){ |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 68 | this.requester = requester; |
| 69 | this.retry = retry; |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 70 | this.requestTime = System.currentTimeMillis(); |
| 71 | } |
| 72 | |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 73 | public ArpRequest(ArpRequest old) { |
| 74 | this.requester = old.requester; |
| 75 | this.retry = old.retry; |
| 76 | this.requestTime = System.currentTimeMillis(); |
| 77 | } |
| 78 | |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 79 | public boolean isExpired() { |
Jonathan Hart | da4d0e1 | 2013-09-30 21:00:20 +1300 | [diff] [blame] | 80 | return (System.currentTimeMillis() - requestTime) > ARP_REQUEST_TIMEOUT; |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 81 | } |
| 82 | |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 83 | public boolean shouldRetry() { |
| 84 | return retry; |
| 85 | } |
| 86 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 87 | public void dispatchReply(InetAddress ipAddress, MACAddress replyMacAddress) { |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 88 | requester.arpResponse(ipAddress, replyMacAddress); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 89 | } |
| 90 | } |
| 91 | |
Jonathan Hart | da4d0e1 | 2013-09-30 21:00:20 +1300 | [diff] [blame] | 92 | private class HostArpRequester implements IArpRequester { |
| 93 | private final ARP arpRequest; |
| 94 | private final long dpid; |
| 95 | private final short port; |
| 96 | |
| 97 | public HostArpRequester(ARP arpRequest, long dpid, short port) { |
| 98 | this.arpRequest = arpRequest; |
| 99 | this.dpid = dpid; |
| 100 | this.port = port; |
| 101 | } |
| 102 | |
| 103 | @Override |
| 104 | public void arpResponse(InetAddress ipAddress, MACAddress macAddress) { |
| 105 | ProxyArpManager.this.sendArpReply(arpRequest, dpid, port, macAddress); |
| 106 | } |
| 107 | } |
| 108 | |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 109 | public ProxyArpManager(IFloodlightProviderService floodlightProvider, |
Jonathan Hart | 5afde49 | 2013-10-01 12:30:53 +1300 | [diff] [blame] | 110 | ITopologyService topology, ILayer3InfoService layer3, |
| 111 | IRestApiService restApi){ |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 112 | this.floodlightProvider = floodlightProvider; |
| 113 | this.topology = topology; |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 114 | this.layer3 = layer3; |
Jonathan Hart | 5afde49 | 2013-10-01 12:30:53 +1300 | [diff] [blame] | 115 | this.restApi = restApi; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 116 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 117 | arpCache = new ArpCache(); |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 118 | |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 119 | arpRequests = Multimaps.synchronizedSetMultimap( |
| 120 | HashMultimap.<InetAddress, ArpRequest>create()); |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 121 | } |
| 122 | |
Jonathan Hart | 1cf9de0 | 2013-10-21 17:42:29 -0700 | [diff] [blame] | 123 | public void startUp(short vlan) { |
| 124 | this.vlan = vlan; |
| 125 | log.info("vlan set to {}", this.vlan); |
| 126 | |
Jonathan Hart | 5afde49 | 2013-10-01 12:30:53 +1300 | [diff] [blame] | 127 | restApi.addRestletRoutable(new ArpWebRoutable()); |
| 128 | |
Jonathan Hart | 4aa2b4e | 2013-09-24 14:50:23 +1200 | [diff] [blame] | 129 | Timer arpTimer = new Timer("arp-processing"); |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 130 | arpTimer.scheduleAtFixedRate(new TimerTask() { |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 131 | @Override |
| 132 | public void run() { |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 133 | doPeriodicArpProcessing(); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 134 | } |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 135 | }, 0, ARP_TIMER_PERIOD); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 136 | } |
| 137 | |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 138 | /* |
| 139 | * Function that runs periodically to manage the asynchronous request mechanism. |
| 140 | * It basically cleans up old ARP requests if we don't get a response for them. |
| 141 | * The caller can designate that a request should be retried indefinitely, and |
| 142 | * this task will handle that as well. |
| 143 | */ |
| 144 | private void doPeriodicArpProcessing() { |
| 145 | SetMultimap<InetAddress, ArpRequest> retryList |
| 146 | = HashMultimap.<InetAddress, ArpRequest>create(); |
| 147 | |
| 148 | //Have to synchronize externally on the Multimap while using an iterator, |
| 149 | //even though it's a synchronizedMultimap |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 150 | synchronized (arpRequests) { |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 151 | log.debug("Current have {} outstanding requests", |
| 152 | arpRequests.size()); |
| 153 | |
| 154 | Iterator<Map.Entry<InetAddress, ArpRequest>> it |
| 155 | = arpRequests.entries().iterator(); |
| 156 | |
| 157 | while (it.hasNext()) { |
| 158 | Map.Entry<InetAddress, ArpRequest> entry |
| 159 | = it.next(); |
| 160 | ArpRequest request = entry.getValue(); |
| 161 | if (request.isExpired()) { |
| 162 | log.debug("Cleaning expired ARP request for {}", |
| 163 | entry.getKey().getHostAddress()); |
| 164 | |
| 165 | it.remove(); |
| 166 | |
| 167 | if (request.shouldRetry()) { |
| 168 | retryList.put(entry.getKey(), request); |
| 169 | } |
| 170 | } |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 171 | } |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 172 | } |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 173 | |
| 174 | for (Map.Entry<InetAddress, Collection<ArpRequest>> entry |
| 175 | : retryList.asMap().entrySet()) { |
| 176 | |
| 177 | InetAddress address = entry.getKey(); |
| 178 | |
| 179 | log.debug("Resending ARP request for {}", address.getHostAddress()); |
| 180 | |
| 181 | sendArpRequestForAddress(address); |
| 182 | |
| 183 | for (ArpRequest request : entry.getValue()) { |
| 184 | arpRequests.put(address, new ArpRequest(request)); |
| 185 | } |
| 186 | } |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 187 | } |
| 188 | |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 189 | @Override |
| 190 | public String getName() { |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 191 | return "ProxyArpManager"; |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 192 | } |
| 193 | |
| 194 | @Override |
| 195 | public boolean isCallbackOrderingPrereq(OFType type, String name) { |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 196 | return false; |
| 197 | } |
| 198 | |
| 199 | @Override |
| 200 | public boolean isCallbackOrderingPostreq(OFType type, String name) { |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 201 | return false; |
| 202 | } |
| 203 | |
| 204 | @Override |
| 205 | public Command receive( |
| 206 | IOFSwitch sw, OFMessage msg, FloodlightContext cntx) { |
| 207 | |
| 208 | if (msg.getType() != OFType.PACKET_IN){ |
| 209 | return Command.CONTINUE; |
| 210 | } |
| 211 | |
| 212 | OFPacketIn pi = (OFPacketIn) msg; |
| 213 | |
| 214 | Ethernet eth = IFloodlightProviderService.bcStore.get(cntx, |
| 215 | IFloodlightProviderService.CONTEXT_PI_PAYLOAD); |
| 216 | |
| 217 | if (eth.getEtherType() == Ethernet.TYPE_ARP){ |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 218 | ARP arp = (ARP) eth.getPayload(); |
| 219 | |
| 220 | if (arp.getOpCode() == ARP.OP_REQUEST) { |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 221 | handleArpRequest(sw, pi, arp); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 222 | } |
| 223 | else if (arp.getOpCode() == ARP.OP_REPLY) { |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 224 | handleArpReply(sw, pi, arp); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 225 | } |
| 226 | } |
| 227 | |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 228 | //TODO should we propagate ARP or swallow it? |
| 229 | //Always propagate for now so DeviceManager can learn the host location |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 230 | return Command.CONTINUE; |
| 231 | } |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 232 | |
Jonathan Hart | 1912afc | 2013-10-11 12:02:44 +1300 | [diff] [blame] | 233 | private void handleArpRequest(IOFSwitch sw, OFPacketIn pi, ARP arp) { |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 234 | if (log.isTraceEnabled()) { |
| 235 | log.trace("ARP request received for {}", |
| 236 | inetAddressToString(arp.getTargetProtocolAddress())); |
| 237 | } |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 238 | |
| 239 | InetAddress target; |
| 240 | try { |
| 241 | target = InetAddress.getByAddress(arp.getTargetProtocolAddress()); |
| 242 | } catch (UnknownHostException e) { |
| 243 | log.debug("Invalid address in ARP request", e); |
| 244 | return; |
| 245 | } |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 246 | |
| 247 | if (layer3.fromExternalNetwork(sw.getId(), pi.getInPort())) { |
| 248 | //If the request came from outside our network, we only care if |
| 249 | //it was a request for one of our interfaces. |
| 250 | if (layer3.isInterfaceAddress(target)) { |
| 251 | log.trace("ARP request for our interface. Sending reply {} => {}", |
| 252 | target.getHostAddress(), layer3.getRouterMacAddress()); |
| 253 | |
| 254 | sendArpReply(arp, sw.getId(), pi.getInPort(), |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 255 | layer3.getRouterMacAddress()); |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 256 | } |
Jonathan Hart | 6e61821 | 2013-08-21 22:28:43 +1200 | [diff] [blame] | 257 | |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 258 | return; |
| 259 | } |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 260 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 261 | MACAddress macAddress = arpCache.lookup(target); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 262 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 263 | if (macAddress == null){ |
| 264 | //MAC address is not in our ARP cache. |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 265 | |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 266 | //Record where the request came from so we know where to send the reply |
Jonathan Hart | 9ea3121 | 2013-08-12 21:40:34 +1200 | [diff] [blame] | 267 | arpRequests.put(target, new ArpRequest( |
Jonathan Hart | da4d0e1 | 2013-09-30 21:00:20 +1300 | [diff] [blame] | 268 | new HostArpRequester(arp, sw.getId(), pi.getInPort()), false)); |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 269 | |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 270 | //Flood the request out edge ports |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 271 | sendArpRequestToSwitches(target, pi.getPacketData(), sw.getId(), pi.getInPort()); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 272 | } |
| 273 | else { |
| 274 | //We know the address, so send a reply |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 275 | if (log.isTraceEnabled()) { |
| 276 | log.trace("Sending reply: {} => {} to host at {}/{}", new Object [] { |
| 277 | inetAddressToString(arp.getTargetProtocolAddress()), |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 278 | macAddress.toString(), |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 279 | HexString.toHexString(sw.getId()), pi.getInPort()}); |
| 280 | } |
Jonathan Hart | 1633a40 | 2013-08-24 11:38:56 +1200 | [diff] [blame] | 281 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 282 | sendArpReply(arp, sw.getId(), pi.getInPort(), macAddress); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 283 | } |
| 284 | } |
| 285 | |
Jonathan Hart | 1912afc | 2013-10-11 12:02:44 +1300 | [diff] [blame] | 286 | private void handleArpReply(IOFSwitch sw, OFPacketIn pi, ARP arp){ |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 287 | if (log.isTraceEnabled()) { |
| 288 | log.trace("ARP reply recieved: {} => {}, on {}/{}", new Object[] { |
| 289 | inetAddressToString(arp.getSenderProtocolAddress()), |
| 290 | HexString.toHexString(arp.getSenderHardwareAddress()), |
| 291 | HexString.toHexString(sw.getId()), pi.getInPort()}); |
| 292 | } |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 293 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 294 | InetAddress senderIpAddress; |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 295 | try { |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 296 | senderIpAddress = InetAddress.getByAddress(arp.getSenderProtocolAddress()); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 297 | } catch (UnknownHostException e) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 298 | log.debug("Invalid address in ARP reply", e); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 299 | return; |
| 300 | } |
| 301 | |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 302 | MACAddress senderMacAddress = MACAddress.valueOf(arp.getSenderHardwareAddress()); |
| 303 | |
| 304 | arpCache.update(senderIpAddress, senderMacAddress); |
| 305 | |
| 306 | //See if anyone's waiting for this ARP reply |
| 307 | Set<ArpRequest> requests = arpRequests.get(senderIpAddress); |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 308 | |
| 309 | //Synchronize on the Multimap while using an iterator for one of the sets |
Jonathan Hart | e751e1c | 2013-08-23 00:48:47 +1200 | [diff] [blame] | 310 | List<ArpRequest> requestsToSend = new ArrayList<ArpRequest>(requests.size()); |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 311 | synchronized (arpRequests) { |
| 312 | Iterator<ArpRequest> it = requests.iterator(); |
| 313 | while (it.hasNext()) { |
| 314 | ArpRequest request = it.next(); |
| 315 | it.remove(); |
Jonathan Hart | e751e1c | 2013-08-23 00:48:47 +1200 | [diff] [blame] | 316 | requestsToSend.add(request); |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 317 | } |
| 318 | } |
Jonathan Hart | e751e1c | 2013-08-23 00:48:47 +1200 | [diff] [blame] | 319 | |
| 320 | //Don't hold an ARP lock while dispatching requests |
| 321 | for (ArpRequest request : requestsToSend) { |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 322 | request.dispatchReply(senderIpAddress, senderMacAddress); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 323 | } |
| 324 | } |
| 325 | |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 326 | private void sendArpRequestForAddress(InetAddress ipAddress) { |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 327 | //TODO what should the sender IP address and MAC address be if no |
| 328 | //IP addresses are configured? Will there ever be a need to send |
| 329 | //ARP requests from the controller in that case? |
| 330 | //All-zero MAC address doesn't seem to work - hosts don't respond to it |
| 331 | |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 332 | byte[] zeroIpv4 = {0x0, 0x0, 0x0, 0x0}; |
| 333 | byte[] zeroMac = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 334 | byte[] genericNonZeroMac = {0x0, 0x0, 0x0, 0x0, 0x0, 0x01}; |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 335 | byte[] broadcastMac = {(byte)0xff, (byte)0xff, (byte)0xff, |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 336 | (byte)0xff, (byte)0xff, (byte)0xff}; |
| 337 | |
| 338 | ARP arpRequest = new ARP(); |
| 339 | |
| 340 | arpRequest.setHardwareType(ARP.HW_TYPE_ETHERNET) |
| 341 | .setProtocolType(ARP.PROTO_TYPE_IP) |
| 342 | .setHardwareAddressLength((byte)Ethernet.DATALAYER_ADDRESS_LENGTH) |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 343 | .setProtocolAddressLength((byte)IPv4.ADDRESS_LENGTH) |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 344 | .setOpCode(ARP.OP_REQUEST) |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 345 | .setTargetHardwareAddress(zeroMac) |
| 346 | .setTargetProtocolAddress(ipAddress.getAddress()); |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 347 | |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 348 | MACAddress routerMacAddress = layer3.getRouterMacAddress(); |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 349 | //TODO hack for now as it's unclear what the MAC address should be |
| 350 | byte[] senderMacAddress = genericNonZeroMac; |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 351 | if (routerMacAddress != null) { |
| 352 | senderMacAddress = routerMacAddress.toBytes(); |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 353 | } |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 354 | arpRequest.setSenderHardwareAddress(senderMacAddress); |
| 355 | |
| 356 | byte[] senderIPAddress = zeroIpv4; |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 357 | Interface intf = layer3.getOutgoingInterface(ipAddress); |
| 358 | if (intf != null) { |
| 359 | senderIPAddress = intf.getIpAddress().getAddress(); |
| 360 | } |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 361 | |
| 362 | arpRequest.setSenderProtocolAddress(senderIPAddress); |
| 363 | |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 364 | Ethernet eth = new Ethernet(); |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 365 | eth.setSourceMACAddress(senderMacAddress) |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 366 | .setDestinationMACAddress(broadcastMac) |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 367 | .setEtherType(Ethernet.TYPE_ARP) |
| 368 | .setPayload(arpRequest); |
| 369 | |
Jonathan Hart | 1cf9de0 | 2013-10-21 17:42:29 -0700 | [diff] [blame] | 370 | if (vlan != NO_VLAN) { |
| 371 | eth.setVlanID(vlan) |
| 372 | .setPriorityCode((byte)0); |
| 373 | } |
| 374 | |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 375 | sendArpRequestToSwitches(ipAddress, eth.serialize()); |
| 376 | } |
| 377 | |
| 378 | private void sendArpRequestToSwitches(InetAddress dstAddress, byte[] arpRequest) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 379 | sendArpRequestToSwitches(dstAddress, arpRequest, |
| 380 | 0, OFPort.OFPP_NONE.getValue()); |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 381 | } |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 382 | |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 383 | private void sendArpRequestToSwitches(InetAddress dstAddress, byte[] arpRequest, |
| 384 | long inSwitch, short inPort) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 385 | |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 386 | if (layer3.hasLayer3Configuration()) { |
| 387 | Interface intf = layer3.getOutgoingInterface(dstAddress); |
| 388 | if (intf != null) { |
| 389 | sendArpRequestOutPort(arpRequest, intf.getDpid(), intf.getPort()); |
| 390 | } |
| 391 | else { |
| 392 | //TODO here it should be broadcast out all non-interface edge ports. |
| 393 | //I think we can assume that if it's not a request for an external |
| 394 | //network, it's an ARP for a host in our own network. So we want to |
| 395 | //send it out all edge ports that don't have an interface configured |
| 396 | //to ensure it reaches all hosts in our network. |
| 397 | log.debug("No interface found to send ARP request for {}", |
| 398 | dstAddress.getHostAddress()); |
| 399 | } |
| 400 | } |
| 401 | else { |
| 402 | broadcastArpRequestOutEdge(arpRequest, inSwitch, inPort); |
| 403 | } |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 404 | } |
| 405 | |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 406 | private void broadcastArpRequestOutEdge(byte[] arpRequest, long inSwitch, short inPort) { |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 407 | for (IOFSwitch sw : floodlightProvider.getSwitches().values()){ |
| 408 | Collection<Short> enabledPorts = sw.getEnabledPortNumbers(); |
| 409 | Set<Short> linkPorts = topology.getPortsWithLinks(sw.getId()); |
| 410 | |
Jonathan Hart | 8ec133c | 2013-06-26 15:25:18 +1200 | [diff] [blame] | 411 | if (linkPorts == null){ |
| 412 | //I think this means the switch isn't known to topology yet. |
| 413 | //Maybe it only just joined. |
| 414 | continue; |
| 415 | } |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 416 | |
| 417 | OFPacketOut po = new OFPacketOut(); |
| 418 | po.setInPort(OFPort.OFPP_NONE) |
| 419 | .setBufferId(-1) |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 420 | .setPacketData(arpRequest); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 421 | |
| 422 | List<OFAction> actions = new ArrayList<OFAction>(); |
| 423 | |
| 424 | for (short portNum : enabledPorts){ |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 425 | if (linkPorts.contains(portNum) || |
| 426 | (sw.getId() == inSwitch && portNum == inPort)){ |
| 427 | //If this port isn't an edge port or is the ingress port |
| 428 | //for the ARP, don't broadcast out it |
| 429 | continue; |
| 430 | } |
| 431 | |
| 432 | actions.add(new OFActionOutput(portNum)); |
| 433 | } |
| 434 | |
| 435 | po.setActions(actions); |
| 436 | short actionsLength = (short) (actions.size() * OFActionOutput.MINIMUM_LENGTH); |
| 437 | po.setActionsLength(actionsLength); |
| 438 | po.setLengthU(OFPacketOut.MINIMUM_LENGTH + actionsLength |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 439 | + arpRequest.length); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 440 | |
| 441 | List<OFMessage> msgList = new ArrayList<OFMessage>(); |
| 442 | msgList.add(po); |
| 443 | |
| 444 | try { |
| 445 | sw.write(msgList, null); |
| 446 | sw.flush(); |
| 447 | } catch (IOException e) { |
| 448 | log.error("Failure writing packet out to switch", e); |
| 449 | } |
| 450 | } |
| 451 | } |
| 452 | |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 453 | private void sendArpRequestOutPort(byte[] arpRequest, long dpid, short port) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 454 | if (log.isTraceEnabled()) { |
| 455 | log.trace("Sending ARP request out {}/{}", |
| 456 | HexString.toHexString(dpid), port); |
| 457 | } |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 458 | |
| 459 | OFPacketOut po = new OFPacketOut(); |
| 460 | po.setInPort(OFPort.OFPP_NONE) |
| 461 | .setBufferId(-1) |
| 462 | .setPacketData(arpRequest); |
| 463 | |
| 464 | List<OFAction> actions = new ArrayList<OFAction>(); |
| 465 | actions.add(new OFActionOutput(port)); |
| 466 | po.setActions(actions); |
| 467 | short actionsLength = (short) (actions.size() * OFActionOutput.MINIMUM_LENGTH); |
| 468 | po.setActionsLength(actionsLength); |
| 469 | po.setLengthU(OFPacketOut.MINIMUM_LENGTH + actionsLength |
| 470 | + arpRequest.length); |
| 471 | |
| 472 | IOFSwitch sw = floodlightProvider.getSwitches().get(dpid); |
| 473 | |
| 474 | if (sw == null) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 475 | log.warn("Switch not found when sending ARP request"); |
Jonathan Hart | 2f790d2 | 2013-08-15 14:01:24 +1200 | [diff] [blame] | 476 | return; |
| 477 | } |
| 478 | |
| 479 | try { |
| 480 | sw.write(po, null); |
| 481 | sw.flush(); |
| 482 | } catch (IOException e) { |
| 483 | log.error("Failure writing packet out to switch", e); |
| 484 | } |
| 485 | } |
| 486 | |
Jonathan Hart | da4d0e1 | 2013-09-30 21:00:20 +1300 | [diff] [blame] | 487 | private void sendArpReply(ARP arpRequest, long dpid, short port, MACAddress targetMac) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 488 | if (log.isTraceEnabled()) { |
| 489 | log.trace("Sending reply {} => {} to {}", new Object[] { |
| 490 | inetAddressToString(arpRequest.getTargetProtocolAddress()), |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 491 | targetMac, |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 492 | inetAddressToString(arpRequest.getSenderProtocolAddress())}); |
| 493 | } |
Jonathan Hart | 1633a40 | 2013-08-24 11:38:56 +1200 | [diff] [blame] | 494 | |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 495 | ARP arpReply = new ARP(); |
| 496 | arpReply.setHardwareType(ARP.HW_TYPE_ETHERNET) |
| 497 | .setProtocolType(ARP.PROTO_TYPE_IP) |
| 498 | .setHardwareAddressLength((byte)Ethernet.DATALAYER_ADDRESS_LENGTH) |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 499 | .setProtocolAddressLength((byte)IPv4.ADDRESS_LENGTH) |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 500 | .setOpCode(ARP.OP_REPLY) |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 501 | .setSenderHardwareAddress(targetMac.toBytes()) |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 502 | .setSenderProtocolAddress(arpRequest.getTargetProtocolAddress()) |
| 503 | .setTargetHardwareAddress(arpRequest.getSenderHardwareAddress()) |
| 504 | .setTargetProtocolAddress(arpRequest.getSenderProtocolAddress()); |
| 505 | |
Jonathan Hart | 1cf9de0 | 2013-10-21 17:42:29 -0700 | [diff] [blame] | 506 | |
| 507 | |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 508 | Ethernet eth = new Ethernet(); |
| 509 | eth.setDestinationMACAddress(arpRequest.getSenderHardwareAddress()) |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 510 | .setSourceMACAddress(targetMac.toBytes()) |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 511 | .setEtherType(Ethernet.TYPE_ARP) |
| 512 | .setPayload(arpReply); |
| 513 | |
Jonathan Hart | 1cf9de0 | 2013-10-21 17:42:29 -0700 | [diff] [blame] | 514 | if (vlan != NO_VLAN) { |
| 515 | eth.setVlanID(vlan) |
| 516 | .setPriorityCode((byte)0); |
| 517 | } |
| 518 | |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 519 | List<OFAction> actions = new ArrayList<OFAction>(); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 520 | actions.add(new OFActionOutput(port)); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 521 | |
| 522 | OFPacketOut po = new OFPacketOut(); |
| 523 | po.setInPort(OFPort.OFPP_NONE) |
| 524 | .setBufferId(-1) |
Jonathan Hart | 8ec133c | 2013-06-26 15:25:18 +1200 | [diff] [blame] | 525 | .setPacketData(eth.serialize()) |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 526 | .setActions(actions) |
| 527 | .setActionsLength((short)OFActionOutput.MINIMUM_LENGTH) |
| 528 | .setLengthU(OFPacketOut.MINIMUM_LENGTH + OFActionOutput.MINIMUM_LENGTH |
| 529 | + po.getPacketData().length); |
| 530 | |
| 531 | List<OFMessage> msgList = new ArrayList<OFMessage>(); |
| 532 | msgList.add(po); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 533 | |
| 534 | IOFSwitch sw = floodlightProvider.getSwitches().get(dpid); |
| 535 | |
| 536 | if (sw == null) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 537 | log.warn("Switch {} not found when sending ARP reply", |
Jonathan Hart | 1633a40 | 2013-08-24 11:38:56 +1200 | [diff] [blame] | 538 | HexString.toHexString(dpid)); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 539 | return; |
| 540 | } |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 541 | |
| 542 | try { |
| 543 | sw.write(msgList, null); |
| 544 | sw.flush(); |
| 545 | } catch (IOException e) { |
Jonathan Hart | 5b803bc | 2013-09-23 14:46:11 +1200 | [diff] [blame] | 546 | log.error("Failure writing packet out to switch", e); |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 547 | } |
| 548 | } |
Jonathan Hart | da4d0e1 | 2013-09-30 21:00:20 +1300 | [diff] [blame] | 549 | |
| 550 | private String inetAddressToString(byte[] bytes) { |
| 551 | try { |
| 552 | return InetAddress.getByAddress(bytes).getHostAddress(); |
| 553 | } catch (UnknownHostException e) { |
| 554 | log.debug("Invalid IP address", e); |
| 555 | return ""; |
| 556 | } |
| 557 | } |
| 558 | |
| 559 | /* |
| 560 | * IProxyArpService methods |
| 561 | */ |
Jonathan Hart | c824ad0 | 2013-07-03 15:58:45 +1200 | [diff] [blame] | 562 | |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 563 | @Override |
Jonathan Hart | abad6a5 | 2013-09-30 18:17:21 +1300 | [diff] [blame] | 564 | public MACAddress getMacAddress(InetAddress ipAddress) { |
| 565 | return arpCache.lookup(ipAddress); |
Jonathan Hart | 6261dcd | 2013-07-22 17:58:35 +1200 | [diff] [blame] | 566 | } |
Jonathan Hart | 4dfc365 | 2013-08-02 20:22:36 +1200 | [diff] [blame] | 567 | |
| 568 | @Override |
| 569 | public void sendArpRequest(InetAddress ipAddress, IArpRequester requester, |
| 570 | boolean retry) { |
Jonathan Hart | df6ec33 | 2013-08-04 01:37:14 +1200 | [diff] [blame] | 571 | arpRequests.put(ipAddress, new ArpRequest(requester, retry)); |
Jonathan Hart | f0c0dcb | 2013-07-24 15:28:42 +1200 | [diff] [blame] | 572 | |
Jonathan Hart | 6e61821 | 2013-08-21 22:28:43 +1200 | [diff] [blame] | 573 | //Sanity check to make sure we don't send a request for our own address |
Jonathan Hart | 08ee852 | 2013-09-22 17:34:43 +1200 | [diff] [blame] | 574 | if (!layer3.isInterfaceAddress(ipAddress)) { |
Jonathan Hart | 6e61821 | 2013-08-21 22:28:43 +1200 | [diff] [blame] | 575 | sendArpRequestForAddress(ipAddress); |
| 576 | } |
| 577 | } |
Jonathan Hart | 5afde49 | 2013-10-01 12:30:53 +1300 | [diff] [blame] | 578 | |
| 579 | @Override |
| 580 | public List<String> getMappings() { |
| 581 | return arpCache.getMappings(); |
| 582 | } |
Jonathan Hart | c7ca35d | 2013-06-25 20:54:25 +1200 | [diff] [blame] | 583 | } |