commit da7187bd95674b4152b83d8a1ff42f9e1e2d9773
author Pankaj Berde <pankaj@onlab.us> Mon Mar 18 15:24:59 2013 -0700
committer Pankaj Berde <pankaj@onlab.us> Mon Mar 18 15:24:59 2013 -0700
tree ebf51ed88eaa03bdb3e2a68266043794514418c7
parent 66ba53afe452fe8c30df9f2d923a5445adb4ebcd

fixed #229: handling rapid switch flapping race conditions gracefully

src/main/java/net/floodlightcontroller/core/internal/Controller.java

diff --git a/src/main/java/net/floodlightcontroller/core/internal/Controller.java b/src/main/java/net/floodlightcontroller/core/internal/Controller.java
index 60dbc69..f4a6263 100644
--- a/src/main/java/net/floodlightcontroller/core/internal/Controller.java
+++ b/src/main/java/net/floodlightcontroller/core/internal/Controller.java
@@ -560,7 +560,9 @@
                     removeSwitch(sw);
                 }
                 synchronized(roleChanger) {
-                	registryService.releaseControl(sw.getId());
+                	if (controlRequested) {
+                		registryService.releaseControl(sw.getId());
+                	}
                     connectedSwitches.remove(sw);
                 }
                 sw.setConnected(false);
@@ -795,9 +797,10 @@
                     dfuture);
 
         }
-        
+ 
+      	volatile Boolean controlRequested = Boolean.FALSE;
         protected void checkSwitchReady() {
-        	Boolean controlRequested = Boolean.TRUE;
+  
             if (state.hsState == HandshakeState.FEATURES_REPLY &&
                     state.hasDescription && state.hasGetConfigReply) {
                 
@@ -822,6 +825,7 @@
                     	
                     	//Request control of the switch from the global registry
                     	try {
+                    		controlRequested = Boolean.TRUE;
 							registryService.requestControl(sw.getId(), 
 									new RoleChangeCallback());
 						} catch (RegistryException e) {