Enforced Checkstyle rule to limit line length.
Maximum line length is 120 right now (but we might want to think about
reducing it further in the future).
I've fixed the existing lines we had that violated the rule.
Change-Id: I077d0c427d35e1c5033aab45ed3fbbbf1d106e89
diff --git a/src/main/java/net/onrc/onos/apps/forwarding/Forwarding.java b/src/main/java/net/onrc/onos/apps/forwarding/Forwarding.java
index e59b33c..8d37611 100644
--- a/src/main/java/net/onrc/onos/apps/forwarding/Forwarding.java
+++ b/src/main/java/net/onrc/onos/apps/forwarding/Forwarding.java
@@ -58,7 +58,8 @@
private static final int DEFAULT_IDLE_TIMEOUT = 5;
private int idleTimeout = DEFAULT_IDLE_TIMEOUT;
- private static final ScheduledExecutorService EXECUTOR_SERVICE = Executors.newScheduledThreadPool(NUMBER_OF_THREAD_FOR_EXECUTOR);
+ private static final ScheduledExecutorService EXECUTOR_SERVICE =
+ Executors.newScheduledThreadPool(NUMBER_OF_THREAD_FOR_EXECUTOR);
private final String callerId = "Forwarding";
@@ -233,15 +234,18 @@
String destinationMac =
HexString.toHexString(eth.getDestinationMACAddress());
- //FIXME getDeviceByMac() is a blocking call, so it may be better way to handle it to avoid the condition.
- Device deviceObject = topology.getDeviceByMac(MACAddress.valueOf(destinationMac));
+ // FIXME getDeviceByMac() is a blocking call, so it may be better way
+ // to handle it to avoid the condition.
+ Device deviceObject = topology.getDeviceByMac(
+ MACAddress.valueOf(destinationMac));
if (deviceObject == null) {
log.debug("No device entry found for {}",
destinationMac);
//Device is not in the DB, so wait it until the device is added.
- EXECUTOR_SERVICE.schedule(new WaitDeviceArp(sw, inPort, eth), SLEEP_TIME_FOR_DB_DEVICE_INSTALLED, TimeUnit.MILLISECONDS);
+ EXECUTOR_SERVICE.schedule(new WaitDeviceArp(sw, inPort, eth),
+ SLEEP_TIME_FOR_DB_DEVICE_INSTALLED, TimeUnit.MILLISECONDS);
return;
}
@@ -264,11 +268,14 @@
public void run() {
Device deviceObject = topology.getDeviceByMac(MACAddress.valueOf(eth.getDestinationMACAddress()));
if (deviceObject == null) {
- log.debug("wait {}ms and device was not found. Send broadcast packet and the thread finish.", SLEEP_TIME_FOR_DB_DEVICE_INSTALLED);
+ log.debug("wait {}ms and device was not found. " +
+ "Send broadcast packet and the thread finish.",
+ SLEEP_TIME_FOR_DB_DEVICE_INSTALLED);
handleBroadcast(sw, inPort, eth);
return;
}
- log.debug("wait {}ms and device {} was found, continue", SLEEP_TIME_FOR_DB_DEVICE_INSTALLED, deviceObject.getMacAddress());
+ log.debug("wait {}ms and device {} was found, continue",
+ SLEEP_TIME_FOR_DB_DEVICE_INSTALLED, deviceObject.getMacAddress());
continueHandlePacketIn(sw, inPort, eth, deviceObject);
}
}
@@ -461,7 +468,8 @@
private void flowInstalled(PathIntent installedPath) {
if (log.isTraceEnabled()) {
- log.trace("Installed intent ID {}, path {}", installedPath.getParentIntent().getId(), installedPath.getPath());
+ log.trace("Installed intent ID {}, path {}",
+ installedPath.getParentIntent().getId(), installedPath.getPath());
}
ShortestPathIntent spfIntent = (ShortestPathIntent) installedPath.getParentIntent();
diff --git a/src/main/java/net/onrc/onos/apps/proxyarp/ArpCache.java b/src/main/java/net/onrc/onos/apps/proxyarp/ArpCache.java
index 6216f59..39dc119 100644
--- a/src/main/java/net/onrc/onos/apps/proxyarp/ArpCache.java
+++ b/src/main/java/net/onrc/onos/apps/proxyarp/ArpCache.java
@@ -137,7 +137,8 @@
if (arpEntry != null && arpEntry.getMacAddress().equals(macAddress)) {
arpEntry.setTimeLastSeen(System.currentTimeMillis());
- log.debug("The same ArpCache, ip {}, mac {}. Update local cache last seen time only.", ipAddress, macAddress);
+ log.debug("The same ArpCache, ip {}, mac {}. " +
+ "Update local cache last seen time only.", ipAddress, macAddress);
} else {
arpCache.put(ipAddress, new ArpCacheEntry(macAddress));
kvArpCache.forceCreate(ipAddress, macAddress.toBytes());
diff --git a/src/main/java/net/onrc/onos/apps/sdnip/PatriciaTree.java b/src/main/java/net/onrc/onos/apps/sdnip/PatriciaTree.java
index 844ba35..cce2630 100644
--- a/src/main/java/net/onrc/onos/apps/sdnip/PatriciaTree.java
+++ b/src/main/java/net/onrc/onos/apps/sdnip/PatriciaTree.java
@@ -125,7 +125,8 @@
while (node != null
&& node.prefix.getPrefixLength() <= p.getPrefixLength()
- && key_match(node.prefix.getAddress(), node.prefix.getPrefixLength(), p.getAddress(), p.getPrefixLength()) == true) {
+ && key_match(node.prefix.getAddress(), node.prefix.getPrefixLength(),
+ p.getAddress(), p.getPrefixLength()) == true) {
if (node.prefix.getPrefixLength() == p.getPrefixLength()) {
//return addReference(node);
return node.rib;
diff --git a/src/main/java/net/onrc/onos/apps/sdnip/Ptree.java b/src/main/java/net/onrc/onos/apps/sdnip/Ptree.java
index c99ea09..c47ef1d 100644
--- a/src/main/java/net/onrc/onos/apps/sdnip/Ptree.java
+++ b/src/main/java/net/onrc/onos/apps/sdnip/Ptree.java
@@ -15,7 +15,9 @@
private int maxKeyOctets;
//private int refCount;
private PtreeNode top;
- private byte[] maskBits = {(byte) 0x00, (byte) 0x80, (byte) 0xc0, (byte) 0xe0, (byte) 0xf0, (byte) 0xf8, (byte) 0xfc, (byte) 0xfe, (byte) 0xff};
+ private byte[] maskBits =
+ {(byte) 0x00, (byte) 0x80, (byte) 0xc0, (byte) 0xe0, (byte) 0xf0,
+ (byte) 0xf8, (byte) 0xfc, (byte) 0xfe, (byte) 0xff};
public Ptree(int maxKeyBits) {
this.maxKeyBits = maxKeyBits;