tree 5475f9538aecab9d28ea3a61f9ac74482b73ca2e
parent 1364a9356cc9a1b536578bc9dafae390198502c2
author Pavlin Radoslavov <pavlin@onlab.us> 1397257733 -0700
committer Pavlin Radoslavov <pavlin@onlab.us> 1397522582 -0700

Fix issues found by FindBugs: EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC

http://findbugs.sourceforge.net/bugDescriptions.html#EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC

Note that the problem with implementing equals() in both the
base and derived class is fundamental:
http://www.angelikalanger.com/Articles/JavaSolutions/SecretsOfEquals/Equals.html
http://www.artima.com/lejava/articles/equality.html

Note: The Floodlight fix in LLDPTLV.java and
LLDPOrganizationalTLV.java is incorrect, because inside LLDPTLV.java
the equals() implementation is using "instanceof" instead of "getClass()":

https://github.com/floodlight/floodlight/blob/master/src/main/java/net/floodlightcontroller/packet/LLDPTLV.java
https://github.com/floodlight/floodlight/blob/master/src/main/java/net/floodlightcontroller/packet/LLDPOrganizationalTLV.java

Change-Id: I0ff28a8ba1190036dbef87c6a0982c79bba115c8