Enable checkstyle rule for too many formal parameters
Enable the "ParameterNumber" checkstyle rule and fix
any violations it uncovers.
There were 4 places in the code that violated this rule.
Changing these APIs was outside of the scope of the current work,
so suppressions were put in place for these 4 classes:
net.onrc.onos.core.intent.ConstrainedShortestPathIntent
net.onrc.onos.core.intent.runtime.PathCalcRuntimeModule
net.onrc.onos.core.linkdiscovery.internal.LinkDiscoveryManager
net.onrc.onos.core.topology.INetworkGraphListener
Change-Id: Iedc4177668efa33347f5c2300005dece68c36925
diff --git a/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java b/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java
index 306bbbb..e3d8432 100644
--- a/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java
+++ b/src/main/java/net/onrc/onos/core/linkdiscovery/internal/LinkDiscoveryManager.java
@@ -1844,10 +1844,13 @@
evTopoSwitch = evHistTopologySwitch.put(evTopoSwitch, actn);
}
+ // CHECKSTYLE:OFF suppress warning about too many parameters
private void evHistTopoLink(long srcDpid, long dstDpid, short srcPort,
short dstPort, int srcPortState, int dstPortState,
ILinkDiscovery.LinkType linkType,
EvAction actn, String reason) {
+ // CHECKSTYLE:ON
+
if (evTopoLink == null) {
evTopoLink = new EventHistoryTopologyLink();
}