commit 938a0155a2cd8fb8aa543ebba52ef157b7a743f0
author Jonathan Hart <jono@onlab.us> Mon Apr 07 18:27:31 2014 -0700
committer Jonathan Hart <jono@onlab.us> Tue Apr 08 11:38:53 2014 -0700
tree a27c0d5e841fe1198603d2b346ba94d21c2f9a6e
parent 2476cac9ba2c237fac11469cadb891cd83902af6

Cleaned up PMD violations in SDN-IP

Change-Id: I325c2a451cb8ab17c00f7ceda8f1958b2aba6cfb

src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResource.java

diff --git a/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResource.java b/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResource.java
index 2ac3414..5c14db1 100644
--- a/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResource.java
+++ b/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResource.java
@@ -138,7 +138,8 @@
         log.debug("sysuptime: {}", strSysuptime);
         log.debug("sequence: {}", strSequence);
 
-        String reply = "";
+        //String reply = "";
+        StringBuilder replyStringBuilder = new StringBuilder(80);
 
         if (capability == null) {
             // this is a prefix delete
@@ -149,11 +150,11 @@
                 sysUpTime = Long.parseLong(strSysuptime);
                 sequenceNum = Long.parseLong(strSequence);
             } catch (NumberFormatException e) {
-                reply = "[DELE: mask format is wrong]";
+                String reply = "[DELE: mask format is wrong]";
                 log.info(reply);
                 return reply + "\n";
             } catch (IllegalArgumentException e1) {
-                reply = "[DELE: prefix format is wrong]";
+                String reply = "[DELE: prefix format is wrong]";
                 log.info(reply);
                 return reply + "\n";
             }
@@ -162,18 +163,25 @@
 
             bgpRoute.newRibUpdate(new RibUpdate(Operation.DELETE, p, r));
 
-            reply = reply + "[DELE: " + prefix + "/" + mask + ":" + nextHop
-                    + "]";
+            replyStringBuilder.append("[DELE: ")
+                .append(prefix)
+                .append('/')
+                .append(mask)
+                .append(':')
+                .append(nextHop)
+                .append(']');
         } else {
             // clear the local rib: Ptree
             bgpRoute.clearPtree();
-            reply = "[DELE-capability: " + capability
-                    + "; The local RibEntry is cleared!]\n";
+            replyStringBuilder.append("[DELE-capability: ")
+                    .append(capability)
+                    .append("; The local RibEntry is cleared!]\n");
 
             // to store the number in the top node of the Ptree
         }
 
-        log.info(reply);
-        return reply + "\n";
+        log.info(replyStringBuilder.toString());
+        replyStringBuilder.append('\n');
+        return replyStringBuilder.toString();
     }
 }