commit 7fb16415fd579ff2f03e6c99737d3735f5fa1c36
author Pavlin Radoslavov <pavlin@onlab.us> Fri Apr 11 18:45:19 2014 -0700
committer Gerrit Code Review <gerrit2@onos-services> Mon Apr 14 18:20:55 2014 -0700
tree 9a2398d264367f929a3482f22cd5b079d29a87d0
parent adc3ec1530a2a9d721634bcda7f000bb38c31ec5

Fix issues found by FindBugs: EQ_DOESNT_OVERRIDE_EQUALS

http://findbugs.sourceforge.net/bugDescriptions.html#EQ_DOESNT_OVERRIDE_EQUALS

Added @Override implementations of equals() and hashCode() in the derived classes.

TODO: The implementations in the derived classes redirect to the implementations
in the base class. This needs to be revised and fixed/updated as appropriate.

Change-Id: Ib586ebea685c57af281eaea6630e284240e2376a

src/main/java/net/onrc/onos/core/intent/ConstrainedShortestPathIntent.java

diff --git a/src/main/java/net/onrc/onos/core/intent/ConstrainedShortestPathIntent.java b/src/main/java/net/onrc/onos/core/intent/ConstrainedShortestPathIntent.java
index 1e025b5..2f02857 100644
--- a/src/main/java/net/onrc/onos/core/intent/ConstrainedShortestPathIntent.java
+++ b/src/main/java/net/onrc/onos/core/intent/ConstrainedShortestPathIntent.java
@@ -23,4 +23,16 @@
     public double getBandwidth() {
         return bandwidth;
     }
+
+    @Override
+    public int hashCode() {
+        // TODO: Is this the intended behavior?
+        return (super.hashCode());
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        // TODO: Is this the intended behavior?
+        return (super.equals(obj));
+    }
 }

src/main/java/net/onrc/onos/core/intent/ErrorIntent.java

diff --git a/src/main/java/net/onrc/onos/core/intent/ErrorIntent.java b/src/main/java/net/onrc/onos/core/intent/ErrorIntent.java
index 44ef6c3..c1722fd 100644
--- a/src/main/java/net/onrc/onos/core/intent/ErrorIntent.java
+++ b/src/main/java/net/onrc/onos/core/intent/ErrorIntent.java
@@ -28,4 +28,16 @@
         this.message = message;
         this.parentIntent = parentIntent;
     }
+
+    @Override
+    public int hashCode() {
+        // TODO: Is this the intended behavior?
+        return (super.hashCode());
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        // TODO: Is this the intended behavior?
+        return (super.equals(obj));
+    }
 }

src/main/java/net/onrc/onos/core/intent/PathIntent.java

diff --git a/src/main/java/net/onrc/onos/core/intent/PathIntent.java b/src/main/java/net/onrc/onos/core/intent/PathIntent.java
index b936ea4..154a61a 100644
--- a/src/main/java/net/onrc/onos/core/intent/PathIntent.java
+++ b/src/main/java/net/onrc/onos/core/intent/PathIntent.java
@@ -53,6 +53,18 @@
     }
 
     @Override
+    public int hashCode() {
+        // TODO: Is this the intended behavior?
+        return (super.hashCode());
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        // TODO: Is this the intended behavior?
+        return (super.equals(obj));
+    }
+
+    @Override
     public String toString() {
         return String.format("%s, %s, %s", getId(), getState(), getPath());
     }

src/main/java/net/onrc/onos/core/intent/ShortestPathIntent.java

diff --git a/src/main/java/net/onrc/onos/core/intent/ShortestPathIntent.java b/src/main/java/net/onrc/onos/core/intent/ShortestPathIntent.java
index 38892b2..f62ec38 100644
--- a/src/main/java/net/onrc/onos/core/intent/ShortestPathIntent.java
+++ b/src/main/java/net/onrc/onos/core/intent/ShortestPathIntent.java
@@ -66,6 +66,18 @@
     }
 
     @Override
+    public int hashCode() {
+        // TODO: Is this the intended behavior?
+        return (super.hashCode());
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        // TODO: Is this the intended behavior?
+        return (super.equals(obj));
+    }
+
+    @Override
     public String toString() {
         return String.format("id:%s, state:%s, srcDpid:%s, srcPort:%d, srcMac:%s, dstDpid:%s, dstPort:%d, dstMac:%s",
                 getId(), getState(),