commit 738980f0be9db2486b9578fa519adfe6e40d5148
author Jonathan Hart <jono@onlab.us> Fri Apr 04 10:11:15 2014 -0700
committer Jonathan Hart <jono@onlab.us> Mon Apr 07 10:17:57 2014 -0700
tree 5ae93d7f97f43f777b1b4276310cecbb48a6a73f
parent 1cd9029c05b48cb8ed9ace40c3c56319009cd7b4

Fixed some PMD issues in the SDN-IP module

Change-Id: Iaf002e70c1a00f0008edef5e77b91579acf146aa

src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResourceSynch.java

diff --git a/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResourceSynch.java b/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResourceSynch.java
index 20fc71b..b38a400 100644
--- a/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResourceSynch.java
+++ b/src/main/java/net/onrc/onos/apps/bgproute/BgpRouteResourceSynch.java
@@ -1,17 +1,13 @@
 package net.onrc.onos.apps.bgproute;
 
-
 import org.restlet.resource.Delete;
 import org.restlet.resource.Post;
 import org.restlet.resource.ServerResource;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-
 public class BgpRouteResourceSynch extends ServerResource {
-
-    protected final static Logger log = LoggerFactory
-            .getLogger(BgpRouteResource.class);
+    private final static Logger log = LoggerFactory.getLogger(BgpRouteResourceSynch.class);
 
     @Post
     public String store(String fmJson) {
@@ -19,20 +15,16 @@
         IBgpRouteService bgpRoute = (IBgpRouteService) getContext().getAttributes().
                 get(IBgpRouteService.class.getCanonicalName());
 
-        String router_id = (String) getRequestAttributes().get("routerid");
+        String routerId = (String) getRequestAttributes().get("routerid");
         String prefix = (String) getRequestAttributes().get("prefix");
         String mask = (String) getRequestAttributes().get("mask");
         String nexthop = (String) getRequestAttributes().get("nexthop");
 
-        try {
+        String bgpdRestIp = bgpRoute.getBGPdRestIp();
 
-            String BGPdRestIp = bgpRoute.getBGPdRestIp();
-
-            //bgpdRestIp includes port number, such as 1.1.1.1:8080
-            RestClient.post("http://" + BGPdRestIp + "/wm/bgp/" + router_id + "/" + prefix + "/" + mask + "/" + nexthop);
-        } catch (Exception e) {
-            e.printStackTrace();
-        }
+        // bgpdRestIp includes port number, e.g. 1.1.1.1:8080
+        RestClient.post("http://" + bgpdRestIp + "/wm/bgp/" + routerId + "/" + prefix + "/"
+                + mask + "/" + nexthop);
 
         String reply = "";
         reply = "[POST: " + prefix + "/" + mask + ":" + nexthop + "/synch]";
@@ -40,7 +32,6 @@
 
         return reply + "\n";
 
-
     }
 
     @Delete
@@ -54,20 +45,16 @@
         String nextHop = (String) getRequestAttributes().get("nexthop");
 
         String reply = "";
-        try {
-            String BGPdRestIp = bgpRoute.getBGPdRestIp();
 
-            RestClient.delete("http://" + BGPdRestIp + "/wm/bgp/" + routerId + "/" + prefix + "/" + mask + "/" + nextHop);
+        String bgpdRestIp = bgpRoute.getBGPdRestIp();
 
-        } catch (Exception e) {
-            e.printStackTrace();
-        }
+        RestClient.delete("http://" + bgpdRestIp + "/wm/bgp/" + routerId + "/" + prefix + "/"
+                + mask + "/" + nextHop);
 
         reply = reply + "[DELE: " + prefix + "/" + mask + ":" + nextHop + "/synch]";
 
         log.info(reply);
 
-
         return reply + "\n";
     }
 }