commit 6c4f2fe4213aa9ead064efe46b8aba9289b11d64
author Ray Milkey <ray@onlab.us> Fri Apr 11 09:47:23 2014 -0700
committer Ray Milkey <ray@onlab.us> Fri Apr 11 09:50:04 2014 -0700
tree 3f110f5b5a733a236f523eec57c9e6150efa3d58
parent 318d9d18efd31e4a46d2f5f42b265c7438d0ef4a

Enable checkstyle rule to check for boolean simplifications

Enable the checkstyle "SimplifyBooleanExpression" rule and
fix any violations it reports.

Change-Id: If8a0226829da3339b9209324a8ea36a28f2138c4

src/main/java/net/onrc/onos/apps/bgproute/Ptree.java

diff --git a/src/main/java/net/onrc/onos/apps/bgproute/Ptree.java b/src/main/java/net/onrc/onos/apps/bgproute/Ptree.java
index e370fdf..3c51c90 100644
--- a/src/main/java/net/onrc/onos/apps/bgproute/Ptree.java
+++ b/src/main/java/net/onrc/onos/apps/bgproute/Ptree.java
@@ -37,14 +37,14 @@
 
         while (node != null
                 && node.keyBits <= keyBits
-                && key_match(node.key, node.keyBits, key, keyBits) == true) {
+                && key_match(node.key, node.keyBits, key, keyBits)) {
             if (node.keyBits == keyBits) {
                 return addReference(node);
             }
 
             match = node;
 
-            if (bit_check(key, node.keyBits) == true) {
+            if (bit_check(key, node.keyBits)) {
                 node = node.right;
             } else {
                 node = node.left;
@@ -91,12 +91,12 @@
 
         while (node != null
                 && node.keyBits <= keyBits
-                && key_match(node.key, node.keyBits, key, keyBits) == true) {
+                && key_match(node.key, node.keyBits, key, keyBits)) {
             if (node.keyBits == keyBits) {
                 return addReference(node);
             }
 
-            if (bit_check(key, node.keyBits) == true) {
+            if (bit_check(key, node.keyBits)) {
                 node = node.right;
             } else {
                 node = node.left;
@@ -116,10 +116,10 @@
 
             while (node != null
                     && node.keyBits <= keyBits
-                    && key_match(node.key, node.keyBits, key, keyBits) == true) {
+                    && key_match(node.key, node.keyBits, key, keyBits)) {
                 matched = node;
 
-                if (bit_check(key, node.keyBits) == true) {
+                if (bit_check(key, node.keyBits)) {
                     node = node.right;
                 } else {
                     node = node.left;
@@ -230,7 +230,7 @@
     private void node_link(PtreeNode node, PtreeNode add) {
         boolean bit = bit_check(add.key, node.keyBits);
 
-        if (bit == true) {
+        if (bit) {
             node.right = add;
         } else {
             node.left = add;