commit 608fac3bd462ee55e67b2f04bbd66968c3e2c2d3
author Pavlin Radoslavov <pavlin@onlab.us> Wed Apr 09 12:40:24 2014 -0700
committer Gerrit Code Review <gerrit2@onos-services> Wed Apr 09 13:40:19 2014 -0700
tree 729c42a88394749cf54230bb785f39916d030505
parent b6e0ac88e6dce7ddde84f15e64a8df10764fac68

Fix issues found by FindBugs: MS_SHOULD_BE_FINAL

http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL

Change-Id: I9c08c8002722eb93b4f7bab8f47737a6a6aea38d

src/main/java/net/onrc/onos/core/packet/UDP.java

diff --git a/src/main/java/net/onrc/onos/core/packet/UDP.java b/src/main/java/net/onrc/onos/core/packet/UDP.java
index 6b7cee6..f12f34f 100644
--- a/src/main/java/net/onrc/onos/core/packet/UDP.java
+++ b/src/main/java/net/onrc/onos/core/packet/UDP.java
@@ -25,17 +25,17 @@
  * @author David Erickson (daviderickson@cs.stanford.edu)
  */
 public class UDP extends BasePacket {
-    public static Map<Short, Class<? extends IPacket>> decodeMap;
-    public static short DHCP_SERVER_PORT = (short) 67;
-    public static short DHCP_CLIENT_PORT = (short) 68;
+    public static final short DHCP_SERVER_PORT = (short) 67;
+    public static final short DHCP_CLIENT_PORT = (short) 68;
+    public static final Map<Short, Class<? extends IPacket>> DECODE_MAP;
 
     static {
-        decodeMap = new HashMap<Short, Class<? extends IPacket>>();
+        DECODE_MAP = new HashMap<Short, Class<? extends IPacket>>();
         /*
          * Disable DHCP until the deserialize code is hardened to deal with garbage input
          */
-        UDP.decodeMap.put(DHCP_SERVER_PORT, DHCP.class);
-        UDP.decodeMap.put(DHCP_CLIENT_PORT, DHCP.class);
+        UDP.DECODE_MAP.put(DHCP_SERVER_PORT, DHCP.class);
+        UDP.DECODE_MAP.put(DHCP_CLIENT_PORT, DHCP.class);
 
     }
 
@@ -208,15 +208,15 @@
         this.length = bb.getShort();
         this.checksum = bb.getShort();
 
-        if (UDP.decodeMap.containsKey(this.destinationPort)) {
+        if (UDP.DECODE_MAP.containsKey(this.destinationPort)) {
             try {
-                this.payload = UDP.decodeMap.get(this.destinationPort).getConstructor().newInstance();
+                this.payload = UDP.DECODE_MAP.get(this.destinationPort).getConstructor().newInstance();
             } catch (Exception e) {
                 throw new RuntimeException("Failure instantiating class", e);
             }
-        } else if (UDP.decodeMap.containsKey(this.sourcePort)) {
+        } else if (UDP.DECODE_MAP.containsKey(this.sourcePort)) {
             try {
-                this.payload = UDP.decodeMap.get(this.sourcePort).getConstructor().newInstance();
+                this.payload = UDP.DECODE_MAP.get(this.sourcePort).getConstructor().newInstance();
             } catch (Exception e) {
                 throw new RuntimeException("Failure instantiating class", e);
             }