commit 608fac3bd462ee55e67b2f04bbd66968c3e2c2d3
author Pavlin Radoslavov <pavlin@onlab.us> Wed Apr 09 12:40:24 2014 -0700
committer Gerrit Code Review <gerrit2@onos-services> Wed Apr 09 13:40:19 2014 -0700
tree 729c42a88394749cf54230bb785f39916d030505
parent b6e0ac88e6dce7ddde84f15e64a8df10764fac68

Fix issues found by FindBugs: MS_SHOULD_BE_FINAL

http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL

Change-Id: I9c08c8002722eb93b4f7bab8f47737a6a6aea38d

src/main/java/net/onrc/onos/core/packet/IPv4.java

diff --git a/src/main/java/net/onrc/onos/core/packet/IPv4.java b/src/main/java/net/onrc/onos/core/packet/IPv4.java
index 1195c7c..f1efd7b 100644
--- a/src/main/java/net/onrc/onos/core/packet/IPv4.java
+++ b/src/main/java/net/onrc/onos/core/packet/IPv4.java
@@ -34,13 +34,13 @@
     public static final byte PROTOCOL_ICMP = 0x1;
     public static final byte PROTOCOL_TCP = 0x6;
     public static final byte PROTOCOL_UDP = 0x11;
-    public static Map<Byte, Class<? extends IPacket>> protocolClassMap;
+    public static final Map<Byte, Class<? extends IPacket>> PROTOCOL_CLASS_MAP;
 
     static {
-        protocolClassMap = new HashMap<Byte, Class<? extends IPacket>>();
-        protocolClassMap.put(PROTOCOL_ICMP, ICMP.class);
-        protocolClassMap.put(PROTOCOL_TCP, TCP.class);
-        protocolClassMap.put(PROTOCOL_UDP, UDP.class);
+        PROTOCOL_CLASS_MAP = new HashMap<Byte, Class<? extends IPacket>>();
+        PROTOCOL_CLASS_MAP.put(PROTOCOL_ICMP, ICMP.class);
+        PROTOCOL_CLASS_MAP.put(PROTOCOL_TCP, TCP.class);
+        PROTOCOL_CLASS_MAP.put(PROTOCOL_UDP, UDP.class);
     }
 
     protected byte version;
@@ -362,8 +362,8 @@
         }
 
         IPacket payload;
-        if (IPv4.protocolClassMap.containsKey(this.protocol)) {
-            Class<? extends IPacket> clazz = IPv4.protocolClassMap.get(this.protocol);
+        if (IPv4.PROTOCOL_CLASS_MAP.containsKey(this.protocol)) {
+            Class<? extends IPacket> clazz = IPv4.PROTOCOL_CLASS_MAP.get(this.protocol);
             try {
                 payload = clazz.newInstance();
             } catch (Exception e) {