commit | 608fac3bd462ee55e67b2f04bbd66968c3e2c2d3 | [log] [tgz] |
---|---|---|
author | Pavlin Radoslavov <pavlin@onlab.us> | Wed Apr 09 12:40:24 2014 -0700 |
committer | Gerrit Code Review <gerrit2@onos-services> | Wed Apr 09 13:40:19 2014 -0700 |
tree | 729c42a88394749cf54230bb785f39916d030505 | |
parent | b6e0ac88e6dce7ddde84f15e64a8df10764fac68 [diff] [blame] |
Fix issues found by FindBugs: MS_SHOULD_BE_FINAL http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL Change-Id: I9c08c8002722eb93b4f7bab8f47737a6a6aea38d
diff --git a/src/main/java/net/onrc/onos/core/packet/DHCP.java b/src/main/java/net/onrc/onos/core/packet/DHCP.java index ee3052b..e414802 100644 --- a/src/main/java/net/onrc/onos/core/packet/DHCP.java +++ b/src/main/java/net/onrc/onos/core/packet/DHCP.java
@@ -53,11 +53,11 @@ * ------------------------------------------ */ // Header + magic without options - public static int MIN_HEADER_LENGTH = 240; - public static byte OPCODE_REQUEST = 0x1; - public static byte OPCODE_REPLY = 0x2; + public static final int MIN_HEADER_LENGTH = 240; + public static final byte OPCODE_REQUEST = 0x1; + public static final byte OPCODE_REPLY = 0x2; - public static byte HWTYPE_ETHERNET = 0x1; + public static final byte HWTYPE_ETHERNET = 0x1; public enum DHCPOptionCode { OptionCode_SubnetMask((byte) 1),